[PATCH] x86_64: show apicid for cpu in proc

[PATCH] x86_64: show apicid for cpu in proc

[Yinghai Lu]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: x86_64_show_apicid.patch --]
[-- Type: text/x-patch; name=x86_64_show_apicid.patch, Size: 576 bytes --]

[PATCH] x86_64: show apicid for cpu in proc

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>

diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index 15043a3..caedfe0 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -59,6 +59,7 @@ static void show_cpuinfo_core(struct seq_file *m, struct cpuinfo_x86 *c,
 			   cpus_weight(per_cpu(cpu_core_map, cpu)));
 		seq_printf(m, "core id\t\t: %d\n", c->cpu_core_id);
 		seq_printf(m, "cpu cores\t: %d\n", c->booted_cores);
+		seq_printf(m, "apicid\t: %02x\n", c->apicid);
 	}
 #endif
 }

Re: [PATCH] x86_64: show apicid for cpu in proc

[Ingo Molnar]

* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> +		seq_printf(m, "apicid\t: %02x\n", c->apicid);

thanks, applied.

Note that the number of tabs were off and we generally print these IDs 
in %d, so i committed:

  seq_printf(m, "apicid\t\t: %d\n", c->apicid);

	Ingo

Re: [PATCH] x86_64: show apicid for cpu in proc

[Andi Kleen]

"Yinghai Lu" <yhlu.kernel@gmail.com> writes:

>  			   cpus_weight(per_cpu(cpu_core_map, cpu)));
>  		seq_printf(m, "core id\t\t: %d\n", c->cpu_core_id);
>  		seq_printf(m, "cpu cores\t: %d\n", c->booted_cores);
> +		seq_printf(m, "apicid\t: %02x\n", c->apicid);

Seems a little redundant with the boot log, but ok.

But it's unclear to the user which apic ID is meant by that. There are
two different ones. The one in the LAPIC mapping and the one reported by
CPUID. They are not necessarily the same. I think you should clarify that
by renaming the field or perhaps report both.

-Andi

Re: [PATCH] x86_64: show apicid for cpu in proc

[Yinghai Lu]

On 06 Mar 2008 12:41:46 +0100, Andi Kleen <andi@firstfloor.org> wrote:
> "Yinghai Lu" <yhlu.kernel@gmail.com> writes:
>
>  >                          cpus_weight(per_cpu(cpu_core_map, cpu)));
>  >               seq_printf(m, "core id\t\t: %d\n", c->cpu_core_id);
>  >               seq_printf(m, "cpu cores\t: %d\n", c->booted_cores);
>
> > +             seq_printf(m, "apicid\t: %02x\n", c->apicid);
>
>  Seems a little redundant with the boot log, but ok.
>
>  But it's unclear to the user which apic ID is meant by that. There are
>  two different ones. The one in the LAPIC mapping and the one reported by
>  CPUID. They are not necessarily the same. I think you should clarify that
>  by renaming the field or perhaps report both.

report the apicid and initial apicid at the same time?

but in current code, we didn't use the initial apicid...., actually
initial apic id is more better to get the responding to node/core.

will look at it.

YH