LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Yinghai Lu" <yinghai@kernel.org>
To: "Daniele Calore" <orkaan@orkaan.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.27] x86: memtest fix use of reserve_early()
Date: Tue, 21 Oct 2008 11:42:24 -0700	[thread overview]
Message-ID: <86802c440810211142v30cf5b4s4f71aa1261526c08@mail.gmail.com> (raw)
In-Reply-To: <20081013103412.6fec375a@buddha>

On Mon, Oct 13, 2008 at 1:34 AM, Daniele Calore <orkaan@orkaan.org> wrote:
> Hi all,
>
> Wrong usage of 2nd parameter in reserve_early call.
> 66/75: reserve_early(start_bad, last_bad - start_bad, "BAD RAM");
>                                ^^^^^^^^^^^^^^^^^^^^
>
> The correct way is to use 'end' address and not 'size'.
> As a bonus a fix to the printk format.
>
> Signed-off-by: Daniele Calore <orkaan@orkaan.org>
>
> ---
> diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
> index 672e17f..9cab18b 100644
> --- a/arch/x86/mm/memtest.c
> +++ b/arch/x86/mm/memtest.c
> @@ -61,9 +61,9 @@ static void __init memtest(unsigned long start_phys, unsigned long size,
>                                last_bad += incr;
>                        } else {
>                                if (start_bad) {
> -                                       printk(KERN_CONT "\n  %010lx bad mem addr %010lx - %010lx reserved",
> +                                       printk(KERN_CONT "\n  %016lx bad mem addr %010lx - %010lx reserved",
>                                                val, start_bad, last_bad + incr);
> -                                       reserve_early(start_bad, last_bad - start_bad, "BAD RAM");
> +                                       reserve_early(start_bad, last_bad + incr, "BAD RAM");
>                                }
>                                start_bad = last_bad = start_phys_aligned;
>                        }
> @@ -72,9 +72,8 @@ static void __init memtest(unsigned long start_phys, unsigned long size,
>        if (start_bad) {
>                printk(KERN_CONT "\n  %016lx bad mem addr %010lx - %010lx reserved",
>                        val, start_bad, last_bad + incr);
> -               reserve_early(start_bad, last_bad - start_bad, "BAD RAM");
> +               reserve_early(start_bad, last_bad + incr, "BAD RAM");
>        }
> -
>  }
>
>  /* default is disabled */

Acked-by: Yinghai Lu <yinghai@kernel.org>

Thanks

YH

  parent reply	other threads:[~2008-10-21 18:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  8:34 Daniele Calore
2008-10-21  8:08 ` Daniele Calore
2008-10-21 18:42 ` Yinghai Lu [this message]
2008-10-22  1:48   ` He_Bob
2008-10-22 15:08   ` [PATCH 2.6.27] x86: memtest fix use of reserve_early() Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440810211142v30cf5b4s4f71aa1261526c08@mail.gmail.com \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=orkaan@orkaan.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 2.6.27] x86: memtest fix use of reserve_early()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).