LKML Archive on
help / color / mirror / Atom feed
From: Neil Armstrong <>
To: Rob Herring <>, Jerome Brunet <>
Cc: Kevin Hilman <>,
	Carlo Caione <>,,
	linux-clk <>,,
	"" <>,
Subject: Re: [PATCH 1/4] dt-bindings: clock: meson: update documentation with hhi syscon
Date: Mon, 26 Mar 2018 09:49:51 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 23/03/2018 04:04, Rob Herring wrote:
> On Sun, Mar 18, 2018 at 10:09 AM, Jerome Brunet <> wrote:
>> On Sun, 2018-03-18 at 07:52 -0500, Rob Herring wrote:
>>> On Thu, Mar 15, 2018 at 12:55:42PM +0100, Jerome Brunet wrote:
>>>> The HHI register region hosts more than just clocks and needs to
>>>> accessed drivers other than the clock controller, such as the display
>>>> driver.
>>>> This register region should be managed by syscon. It is already the case
>>>> on gxbb/gxl and it soon will be on axg. The clock controllers must use
>>>> this system controller instead of directly mapping the registers.
>>> Sounds like a kernel problem, not a DT one.
>> It's a platform problem, so it has much a kernel problem (solution already
>> merged) as a DT problem
>> DT wise, we've got two devices mapping the same region
>> in arch/arm64/boot/dts/amlogic/meson-gx.dtsi:
>>> system-controller@0
>> which is used by the display device.
>> and in arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi (same for gxl)
>>> clock-controller@0
>> It has worked so far because the clock controller claims the region w/o
>> reserving it but it remains unsafe since both device may access the same region.
>> The fix is to have the clock controller go through the existing syscon.
> We certainly want to avoid multiple nodes using the same mmio region.
>>> With a single child, there is really no point to this change. A single
>>> node can provide multiple functions. Look at nodes that are both reset
>>> and clock providers.
>> There is more than a single user, as explained above and in the cover letter of
>> this series.
> Right, but a single node can support more than a single user (or
> provider). You don't have to have multiple nodes to have multiple
> users/providers.
> Rob

Hi Rob,

It's a question about user/provider, the syscon node represents the entire mmio
region which has multiple sparse registers for multiple features, is used
indirectly by the display driver, ... and has multiple features, non limited to,
clock controller, multiple power domains,... and it is simpler to represent these
as subnodes instead of a big fat node.

Today, it is already represented like this within the Documentation/devicetree/bindings/power/amlogic,meson-gx-pwrc.txt
So this binding is only an extension for the clock controller which was mis-architectured
at the time due to a mis-knowledge of the HW architecture.


  reply	other threads:[~2018-03-26  7:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 11:55 [PATCH 0/4] ARM64: dts: meson: hhi syscon and clock controllers Jerome Brunet
2018-03-15 11:55 ` [PATCH 1/4] dt-bindings: clock: meson: update documentation with hhi syscon Jerome Brunet
2018-03-18 12:52   ` Rob Herring
2018-03-18 15:09     ` Jerome Brunet
2018-03-23  3:04       ` Rob Herring
2018-03-26  7:49         ` Neil Armstrong [this message]
2018-03-15 11:55 ` [PATCH 2/4] ARM64: dts: meson-gx: sysctrl is the parent of the clock controller Jerome Brunet
2018-03-15 11:55 ` [PATCH 3/4] ARM64: dts: meson-axg: use hhi syscon for " Jerome Brunet
2018-03-15 11:55 ` [PATCH 4/4] ARM64: dts: meson-gx: fix gxl clock controller compatible Jerome Brunet
2018-04-19 17:41 ` [PATCH 0/4] ARM64: dts: meson: hhi syscon and clock controllers Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/4] dt-bindings: clock: meson: update documentation with hhi syscon' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).