LKML Archive on
help / color / mirror / Atom feed
From: "Bjørn Mork" <>
To: Darren Hart <>
Cc: "Lad, Prabhakar" <>,
	"Giedrius Statkevičius" <>,
	"Mattia Dongili" <>,,
	LKML <>,
	"David Miller" <>
Subject: Re: [PATCH] Sony-laptop: fix sparse warning
Date: Sat, 07 Feb 2015 12:33:16 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Darren Hart's message of "Fri, 6 Feb 2015 19:08:27 -0800")

Darren Hart <> writes:
> On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
>> Lad, Prabhakar <>
>> Lad, Prabhakar <>
> I think there may be a problem with this in an unquoted email address. The
> unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
> and . separators.

Yes, but that is not applicable to the git commit tags.  They are not
RFC2822 header fields.  Nothing will ever parse "Lad" as an unqualified
local destination in a SOB, and therefore there is no problem using the
comma there.

Note that names using non-ascii characters are often written without
quotes i SOBs (wonder how I know this? :-).  In practice I believe the
character set is only limited by what you will allow in your git log.
The only characters with a special meaning are :<>#, and the latter is
somewhat dubious.  But it's often used as a comment separator in stable
CCs, so I guess it should be avoided for other uses.

Scripts etc trying to parse these tags into email headers must be
prepared to do the necessary stripping and quoting of any text outside
the <> brackets.

Requiring a full name is of course good for accountability, but do let
people format their names as they want them to appear in the log.
Different cultures have different traditions. Wookey has collected a few
links on this subject if anyone is interested:


  reply	other threads:[~2015-02-07 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 14:49 Lad Prabhakar
2015-02-05 15:55 ` Giedrius Statkevičius
2015-02-05 16:00   ` Lad, Prabhakar
2015-02-07  3:08     ` Darren Hart
2015-02-07 11:33       ` Bjørn Mork [this message]
2015-02-07 20:07         ` Darren Hart
2015-02-07 20:10 ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Sony-laptop: fix sparse warning' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).