LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Vipin Mehta <vmehta@atheros.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 06/15] staging: ath6kl: Convert bypasswmi to bool
Date: Thu, 27 Jan 2011 20:04:23 -0800 [thread overview]
Message-ID: <873b7965aad07cf2d0da0d462aa4819a3979e27c.1296186677.git.joe@perches.com> (raw)
In-Reply-To: <cover.1296186677.git.joe@perches.com>
Types should match logical uses.
Remove unused extern, make static.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/staging/ath6kl/os/linux/ar6000_drv.c | 8 ++++----
drivers/staging/ath6kl/os/linux/ioctl.c | 1 -
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c b/drivers/staging/ath6kl/os/linux/ar6000_drv.c
index 9ed95e3..3ad3d57 100644
--- a/drivers/staging/ath6kl/os/linux/ar6000_drv.c
+++ b/drivers/staging/ath6kl/os/linux/ar6000_drv.c
@@ -123,7 +123,7 @@ int bmienable = BMIENABLE_DEFAULT;
char ifname[IFNAMSIZ] = {0,};
int wlaninitmode = WLAN_INIT_MODE_DEFAULT;
-unsigned int bypasswmi = 0;
+static bool bypasswmi;
unsigned int debuglevel = 0;
int tspecCompliance = ATHEROS_COMPLIANCE;
unsigned int busspeedlow = 0;
@@ -165,7 +165,7 @@ unsigned int eppingtest=0;
module_param_string(ifname, ifname, sizeof(ifname), 0644);
module_param(wlaninitmode, int, 0644);
module_param(bmienable, int, 0644);
-module_param(bypasswmi, uint, 0644);
+module_param(bypasswmi, bool, 0644);
module_param(debuglevel, uint, 0644);
module_param(tspecCompliance, int, 0644);
module_param(onebitmode, uint, 0644);
@@ -1024,7 +1024,7 @@ ar6000_transfer_bin_file(AR_SOFTC_T *ar, AR6K_BIN_FILE file, A_UINT32 address, A
}
if (eppingtest) {
- bypasswmi = TRUE;
+ bypasswmi = true;
if (ar->arVersion.target_ver == AR6003_REV1_VERSION) {
filename = AR6003_REV1_EPPING_FIRMWARE_FILE;
} else if (ar->arVersion.target_ver == AR6003_REV2_VERSION) {
@@ -3512,7 +3512,7 @@ ar6000_tx_complete(void *Context, HTC_PACKET_QUEUE *pPacketQueue)
A_NETBUF_FREE(pktSkb);
}
- if ((ar->arConnected == TRUE) || (bypasswmi)) {
+ if ((ar->arConnected == TRUE) || bypasswmi) {
if (!flushing) {
/* don't wake the queue if we are flushing, other wise it will just
* keep queueing packets, which will keep failing */
diff --git a/drivers/staging/ath6kl/os/linux/ioctl.c b/drivers/staging/ath6kl/os/linux/ioctl.c
index ea1f202..9a508c4 100644
--- a/drivers/staging/ath6kl/os/linux/ioctl.c
+++ b/drivers/staging/ath6kl/os/linux/ioctl.c
@@ -34,7 +34,6 @@ extern unsigned int wmitimeout;
extern A_WAITQUEUE_HEAD arEvent;
extern int tspecCompliance;
extern int bmienable;
-extern int bypasswmi;
extern int loghci;
static int
--
1.7.4.rc3
next prev parent reply other threads:[~2011-01-28 4:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 4:04 [git pull-request and PATCH 00/15] staging: ath6kl: Cleanups Joe Perches
2011-01-28 4:04 ` [PATCH 01/15] staging: ath6kl: Update cfg80211 to recent calling convention changes Joe Perches
2011-01-28 7:35 ` Dan Carpenter
2011-01-28 7:41 ` Dan Carpenter
2011-01-28 4:04 ` [PATCH 02/15] staging: ath6kl: Convert enum A_STATUS to int Joe Perches
2011-01-28 4:04 ` [PATCH 03/15] staging: ath6kl: Remove A_SUCCESS macro Joe Perches
2011-01-28 4:04 ` [PATCH 04/15] staging: ath6kl: Remove A_FAILED macro Joe Perches
2011-01-28 4:04 ` Joe Perches [this message]
2011-01-28 4:04 ` [PATCH 07/15] staging: ath6kl: Convert type of streamExists to A_UINT8 Joe Perches
2011-01-28 4:04 ` [PATCH 08/15] staging: ath6kl: Convert BDADDR_Present uses to TRUE/FALSE bugfix Joe Perches
2011-01-28 4:04 ` [PATCH 09/15] staging: ath6kl: Convert A_BOOL compressed sets from 0 to FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 10/15] staging: ath6kl: Convert " Joe Perches
2011-01-28 4:04 ` [PATCH 11/15] staging: ath6kl: cfg80211: Convert forceFgScan to A_UINT32 Joe Perches
2011-01-28 4:04 ` [PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and is_acl_data_frame to A_BOOL Joe Perches
2011-01-28 11:42 ` Dan Carpenter
2011-01-28 15:45 ` Joe Perches
2011-01-28 4:04 ` [PATCH 13/15] staging: ath6kl: Convert A_NETBUF_QUEUE_EMPTY to return TRUE or FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 14/15] staging: ath6kl: Convert sets of scanSpecificSsid to TRUE/FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 15/15] staging: ath6kl: Convert tspecCompliance from A_BOOL to int Joe Perches
[not found] ` <d1deb8a42497651898ad03bda9018d9deca93f12.1296186677.git.joe@perches.com>
2011-01-28 6:22 ` [PATCH 05/15] staging: ath6kl: wmi.h: Convert packed structures with A_BOOL to u32 Denis Kirjanov
2011-01-28 19:47 ` [git pull-request and PATCH 00/15] staging: ath6kl: Cleanups Vipin Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873b7965aad07cf2d0da0d462aa4819a3979e27c.1296186677.git.joe@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vmehta@atheros.com \
--subject='Re: [PATCH 06/15] staging: ath6kl: Convert bypasswmi to bool' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).