LKML Archive on
help / color / mirror / Atom feed
From: Kalle Valo <>
To: Jia-Ju Bai <>
Subject: Re: [PATCH] net: wireless: b43: Avoid possible double calls to b43_one_core_detach()
Date: Mon, 06 May 2019 11:21:55 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Jia-Ju Bai's message of "Sat, 4 May 2019 17:10:00 +0800")

Jia-Ju Bai <> writes:

> In b43_request_firmware(), when ieee80211_register_hw() fails,
> b43_one_core_detach() is called. In b43_bcma_remove() and
> b43_ssb_remove(), b43_one_core_detach() is called again. In this case, 
> null-pointer dereferences and double-free problems can occur when 
> the driver is removed.
> To fix this bug, the call to b43_one_core_detach() in
> b43_request_firmware() is deleted.
> This bug is found by a runtime fuzzing tool named FIZZER written by us.
> Signed-off-by: Jia-Ju Bai <>
> ---
>  drivers/net/wireless/broadcom/b43/main.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

You can use just "b43:" as prefix, no need to have "net:" nor
"wireless:" in the title. I'll fix it this time, but please use correct
style in the future.

Kalle Valo

  reply	other threads:[~2019-05-06  8:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-04  9:10 Jia-Ju Bai
2019-05-06  8:21 ` Kalle Valo [this message]
2019-05-28 12:43 ` [PATCH] " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] net: wireless: b43: Avoid possible double calls to b43_one_core_detach()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).