LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals
@ 2015-03-30 13:03 Ioan Nicu
  2015-04-02 11:22 ` Alexander Sverdlin
  2015-04-03 20:00 ` Wolfram Sang
  0 siblings, 2 replies; 4+ messages in thread
From: Ioan Nicu @ 2015-03-30 13:03 UTC (permalink / raw)
  To: Peter Korsgaard, Wolfram Sang, linux-i2c, linux-kernel
  Cc: Alexander Sverdlin, Mathias Rulf

Probe deferral is not an error case. It happens only when
the necessary dependencies are not there yet.

The driver core is already printing a message when a driver
requests probe deferral, so this can be traced in the logs
without these error prints.

This patch removes the error messages for these deferral cases.

Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>
---
 drivers/i2c/muxes/i2c-mux-gpio.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index f5798eb..70db992 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -76,10 +76,9 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
 		return -ENODEV;
 	}
 	adapter = of_find_i2c_adapter_by_node(adapter_np);
-	if (!adapter) {
-		dev_err(&pdev->dev, "Cannot find parent bus\n");
+	if (!adapter)
 		return -EPROBE_DEFER;
-	}
+
 	mux->data.parent = i2c_adapter_id(adapter);
 	put_device(&adapter->dev);
 
@@ -177,11 +176,8 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
 	}
 
 	parent = i2c_get_adapter(mux->data.parent);
-	if (!parent) {
-		dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
-			mux->data.parent);
+	if (!parent)
 		return -EPROBE_DEFER;
-	}
 
 	mux->parent = parent;
 	mux->gpio_base = gpio_base;
-- 
1.7.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals
  2015-03-30 13:03 [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals Ioan Nicu
@ 2015-04-02 11:22 ` Alexander Sverdlin
  2015-04-02 11:25   ` Peter Korsgaard
  2015-04-03 20:00 ` Wolfram Sang
  1 sibling, 1 reply; 4+ messages in thread
From: Alexander Sverdlin @ 2015-04-02 11:22 UTC (permalink / raw)
  To: linux-i2c, linux-kernel
  Cc: Ioan Nicu, Peter Korsgaard, Wolfram Sang, Mathias Rulf

On 30/03/15 15:03, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
> 
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
> 
> This patch removes the error messages for these deferral cases.
> 
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>

Acked-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index f5798eb..70db992 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -76,10 +76,9 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
>  		return -ENODEV;
>  	}
>  	adapter = of_find_i2c_adapter_by_node(adapter_np);
> -	if (!adapter) {
> -		dev_err(&pdev->dev, "Cannot find parent bus\n");
> +	if (!adapter)
>  		return -EPROBE_DEFER;
> -	}
> +
>  	mux->data.parent = i2c_adapter_id(adapter);
>  	put_device(&adapter->dev);
>  
> @@ -177,11 +176,8 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>  	}
>  
>  	parent = i2c_get_adapter(mux->data.parent);
> -	if (!parent) {
> -		dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
> -			mux->data.parent);
> +	if (!parent)
>  		return -EPROBE_DEFER;
> -	}
>  
>  	mux->parent = parent;
>  	mux->gpio_base = gpio_base;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals
  2015-04-02 11:22 ` Alexander Sverdlin
@ 2015-04-02 11:25   ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2015-04-02 11:25 UTC (permalink / raw)
  To: Alexander Sverdlin
  Cc: linux-i2c, linux-kernel, Ioan Nicu, Wolfram Sang, Mathias Rulf

>>>>> "AS" == Alexander Sverdlin <alexander.sverdlin@nokia.com> writes:

Hi,

AS> On 30/03/15 15:03, Ioan Nicu wrote:
>> Probe deferral is not an error case. It happens only when
>> the necessary dependencies are not there yet.
>>
>> The driver core is already printing a message when a driver
>> requests probe deferral, so this can be traced in the logs
>> without these error prints.
>>
>> This patch removes the error messages for these deferral cases.
>>
>> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>

AS> Acked-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>

--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals
  2015-03-30 13:03 [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals Ioan Nicu
  2015-04-02 11:22 ` Alexander Sverdlin
@ 2015-04-03 20:00 ` Wolfram Sang
  1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2015-04-03 20:00 UTC (permalink / raw)
  To: Ioan Nicu
  Cc: Peter Korsgaard, linux-i2c, linux-kernel, Alexander Sverdlin,
	Mathias Rulf

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

On Mon, Mar 30, 2015 at 03:03:38PM +0200, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
> 
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
> 
> This patch removes the error messages for these deferral cases.
> 
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-04-03 20:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-30 13:03 [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals Ioan Nicu
2015-04-02 11:22 ` Alexander Sverdlin
2015-04-02 11:25   ` Peter Korsgaard
2015-04-03 20:00 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).