From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE2EC07542 for ; Tue, 28 May 2019 01:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16F2A208C3 for ; Tue, 28 May 2019 01:16:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727813AbfE1BQd (ORCPT ); Mon, 27 May 2019 21:16:33 -0400 Received: from ozlabs.org ([203.11.71.1]:44227 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727736AbfE1BQc (ORCPT ); Mon, 27 May 2019 21:16:32 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45CbXG1YsPz9s3Z; Tue, 28 May 2019 11:16:30 +1000 (AEST) From: Michael Ellerman To: "Rafael J. Wysocki" , Mathieu Malaterre Cc: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , Pavel Machek , Len Brown , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2] powerpc/power: Expose pfn_is_nosave prototype In-Reply-To: <1929721.iDiXxTFbjN@kreacher> References: <20190523114736.30268-1-malat@debian.org> <20190524104418.17194-1-malat@debian.org> <1929721.iDiXxTFbjN@kreacher> Date: Tue, 28 May 2019 11:16:30 +1000 Message-ID: <875zpvqsy9.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Rafael J. Wysocki" writes: > On Friday, May 24, 2019 12:44:18 PM CEST Mathieu Malaterre wrote: >> The declaration for pfn_is_nosave is only available in >> kernel/power/power.h. Since this function can be override in arch, >> expose it globally. Having a prototype will make sure to avoid warning >> (sometime treated as error with W=1) such as: >> >> arch/powerpc/kernel/suspend.c:18:5: error: no previous prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] >> >> This moves the declaration into a globally visible header file and add >> missing include to avoid a warning on powerpc. Also remove the >> duplicated prototypes since not required anymore. >> >> Cc: Christophe Leroy >> Signed-off-by: Mathieu Malaterre >> --- >> v2: As suggestion by christophe remove duplicates prototypes >> >> arch/powerpc/kernel/suspend.c | 1 + >> arch/s390/kernel/entry.h | 1 - >> include/linux/suspend.h | 1 + >> kernel/power/power.h | 2 -- >> 4 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/kernel/power/power.h b/kernel/power/power.h >> index 9e58bdc8a562..44bee462ff57 100644 >> --- a/kernel/power/power.h >> +++ b/kernel/power/power.h >> @@ -75,8 +75,6 @@ static inline void hibernate_reserved_size_init(void) {} >> static inline void hibernate_image_size_init(void) {} >> #endif /* !CONFIG_HIBERNATION */ >> >> -extern int pfn_is_nosave(unsigned long); >> - >> #define power_attr(_name) \ >> static struct kobj_attribute _name##_attr = { \ >> .attr = { \ >> > > With an ACK from the powerpc maintainers, I could apply this one. Sent. cheers