LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: show apicid for cpu in proc
Date: 06 Mar 2008 12:41:46 +0100	[thread overview]
Message-ID: <8763w0gjut.fsf@basil.nowhere.org> (raw)
In-Reply-To: <86802c440803060113s5b09c8b7w3a9da92ca15eff03@mail.gmail.com>

"Yinghai Lu" <yhlu.kernel@gmail.com> writes:

>  			   cpus_weight(per_cpu(cpu_core_map, cpu)));
>  		seq_printf(m, "core id\t\t: %d\n", c->cpu_core_id);
>  		seq_printf(m, "cpu cores\t: %d\n", c->booted_cores);
> +		seq_printf(m, "apicid\t: %02x\n", c->apicid);

Seems a little redundant with the boot log, but ok.

But it's unclear to the user which apic ID is meant by that. There are
two different ones. The one in the LAPIC mapping and the one reported by
CPUID. They are not necessarily the same. I think you should clarify that
by renaming the field or perhaps report both.

-Andi

  parent reply	other threads:[~2008-03-06 11:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06  9:13 Yinghai Lu
2008-03-06 10:21 ` Ingo Molnar
2008-03-06 11:41 ` Andi Kleen [this message]
2008-03-06 19:23   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8763w0gjut.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    --subject='Re: [PATCH] x86_64: show apicid for cpu in proc' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).