LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Colin King <colin.king@canonical.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rsnd: make some arrays static const, makes object smaller
Date: 02 Aug 2021 08:11:22 +0900	[thread overview]
Message-ID: <877dh4yd45.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20210801063237.137998-1-colin.king@canonical.com>


Hi Colin

Thank you for your patch

> Don't populate arrays on the stack but instead them static const.
> Makes the object code smaller by 242 bytes.
> 
> Before:
>    text    data     bss     dec     hex filename
>   23827    8764       0   32591    7f4f ./sound/soc/sh/rcar/ssi.o
> 
> After:
>    text    data     bss     dec     hex filename
>   23361    8988       0   32349    7e5d ./sound/soc/sh/rcar/ssi.o
> 
> gcc version 10.2.0)
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Nice to know.

	Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Do you think we need similar patch to below ?
(In my quick check)

	core.c	rsnd_get_busif_shift()
		volume_ramp_rate[] // need static ?
	adg.c	rsnd_adg_clk_query()
		rsnd_adg_get_clkout()

Thank you for your help !!

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2021-08-01 23:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01  6:32 Colin King
2021-08-01 23:11 ` Kuninori Morimoto [this message]
2021-08-02 15:02 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dh4yd45.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH] ASoC: rsnd: make some arrays static const, makes object smaller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).