From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA1DC432BE for ; Sun, 1 Aug 2021 23:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4406603E7 for ; Sun, 1 Aug 2021 23:11:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231466AbhHAXLd (ORCPT ); Sun, 1 Aug 2021 19:11:33 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:31262 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229955AbhHAXLc (ORCPT ); Sun, 1 Aug 2021 19:11:32 -0400 Date: 02 Aug 2021 08:11:22 +0900 X-IronPort-AV: E=Sophos;i="5.84,287,1620658800"; d="scan'208";a="89441322" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 02 Aug 2021 08:11:22 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 7CB1C4002C17; Mon, 2 Aug 2021 08:11:22 +0900 (JST) Message-ID: <877dh4yd45.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Colin King Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: rsnd: make some arrays static const, makes object smaller In-Reply-To: <20210801063237.137998-1-colin.king@canonical.com> References: <20210801063237.137998-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin Thank you for your patch > Don't populate arrays on the stack but instead them static const. > Makes the object code smaller by 242 bytes. > > Before: > text data bss dec hex filename > 23827 8764 0 32591 7f4f ./sound/soc/sh/rcar/ssi.o > > After: > text data bss dec hex filename > 23361 8988 0 32349 7e5d ./sound/soc/sh/rcar/ssi.o > > gcc version 10.2.0) > > Signed-off-by: Colin Ian King > --- Nice to know. Reviewed-by: Kuninori Morimoto Do you think we need similar patch to below ? (In my quick check) core.c rsnd_get_busif_shift() volume_ramp_rate[] // need static ? adg.c rsnd_adg_clk_query() rsnd_adg_get_clkout() Thank you for your help !! Best regards --- Kuninori Morimoto