LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Rafał Miłecki" <zajec5@gmail.com>, "Michael Büsch" <m@bues.ch>,
	"Matt Redfearn" <matt.redfearn@mips.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"
Date: Sat, 12 May 2018 10:50:42 +0300	[thread overview]
Message-ID: <877eo9b9d9.fsf@codeaurora.org> (raw)
In-Reply-To: <727571cb-5d1f-2d99-b050-979edd02106f@lwfinger.net> (Larry Finger's message of "Fri, 11 May 2018 07:08:48 -0500")

Larry Finger <Larry.Finger@lwfinger.net> writes:

> On 05/11/2018 05:13 AM, Kalle Valo wrote:
>> Rafał Miłecki <zajec5@gmail.com> writes:
>>
>>> On 11 May 2018 at 11:17, Rafał Miłecki <zajec5@gmail.com> wrote:
>>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>>
>>>> This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e.
>>>>
>>>> Above commit added "SSB = y" dependency to the wrong symbol
>>>> SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being
>>>> selected when needed. PCI core driver for core running in clienthost
>>>> mode is important for bus initialization. It's perfectly valid scenario
>>>> to have ssb built as module and use it with buses on PCI cards.
>>>>
>>>> This fixes regression that affected all *module* users with PCI cards.
>>>>
>>>> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1572349
>>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> As these patches fix regression/build error, I believe both should get
>>> into 4.17.
>>
>> How much confidence do we have that we don't need to end up reverting
>> patch 2 as well? I rather be pushing patch 2 to 4.18 so that there's
>> more time for testing and waiting for feedback.
>
> Although I do not have the hardware to test the builds, I worked
> closely with the OP in the bug at b.r.c noted above. From that effort,
> it became clear what configuration variables were missing to cause the
> x86 failures. Patch 2 satisfies the requirement, and prevents the
> build problems found by the MIPS users. Both patches are needed in
> 4.17.

And I assume Michael is ok with this approach as well as I haven't heard
from him. I'll then push both of these to 4.17.

-- 
Kalle Valo

  reply	other threads:[~2018-05-12  7:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11  9:17 Rafał Miłecki
2018-05-11  9:17 ` [PATCH V2 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
2018-05-11  9:21 ` [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module" Rafał Miłecki
2018-05-11 10:13   ` Kalle Valo
2018-05-11 10:25     ` Rafał Miłecki
2018-05-11 12:08     ` Larry Finger
2018-05-12  7:50       ` Kalle Valo [this message]
2018-05-12  8:01         ` Michael Büsch
2018-05-12 10:00           ` Rafał Miłecki
2018-05-12 10:14             ` Michael Büsch
2018-05-12  8:40 ` [V2, " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eo9b9d9.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=hauke@hauke-m.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=matt.redfearn@mips.com \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    --subject='Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).