LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: SeongJae Park <sj38.park@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Thara Gopinath <thara.gopinath@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build
Date: Tue, 24 Aug 2021 22:16:04 -0400	[thread overview]
Message-ID: <8784.1629857764@turing-police> (raw)
In-Reply-To: <20210824091430.20367-1-sjpark@amazon.de>

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Tue, 24 Aug 2021 09:14:30 -0000, SeongJae Park said:

> > > ERROR: modpost: "cpu_scale" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
> >
> > That's a different patch, am working on fixing that one now..
>
> I didn't take a deep look here, so I unsure if this is an appropriate fix, but
> I was able to work-around this issue for my use case with below change.
>

>  DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE;
> +EXPORT_PER_CPU_SYMBOL_GPL(cpu_scale);

Aha.  That's the part I wasn't finding.  Would you like to submit your patch,
or shall I send it in with a "Suggested-by" for you?


[-- Attachment #2: Type: application/pgp-signature, Size: 494 bytes --]

  reply	other threads:[~2021-08-25  2:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-22 20:10 Valdis Klētnieks
2021-08-22 21:08 ` Randy Dunlap
2021-08-22 21:14   ` Valdis Klētnieks
2021-08-24  9:14     ` SeongJae Park
2021-08-25  2:16       ` Valdis Klētnieks [this message]
2021-08-25  4:41         ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8784.1629857764@turing-police \
    --to=valdis.kletnieks@vt.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sj38.park@gmail.com \
    --cc=sudeep.holla@arm.com \
    --cc=thara.gopinath@linaro.org \
    --subject='Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix '\''make allmodconfig'\'' build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).