LKML Archive on
help / color / mirror / Atom feed
From: "Bjørn Mork" <>
To: Imre Deak <>
	"Daniel Vetter" <>,
	"Jani Nikula" <>,,,,
	"Ville Syrjälä" <>
Subject: Re: [PATCH] drm/i915: fix failure to power off after hibernate
Date: Tue, 24 Feb 2015 20:00:56 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Imre Deak's message of "Tue, 24 Feb 2015 18:12:20 +0200")

Imre Deak <> writes:

> The poweroff handlers undo the actions of the thaw handlers. As the
> original commit stated saving the registers is not needed there, but
> it's also not a big overhead and there should be no problem doing it. We
> are planning to optimize the hibernation sequence by for example not
> shutting down the display between freeze and thaw, and also getting rid
> of unnecessary steps at the power off phase. But before that we want to
> actually unify things rather than having special cases, as maintaining
> the special code paths caused already quite a lot of problems for us so
> far.

That sounds like a worthy goal.  I don't understand what you hope to
achieve by having a poweroff_late hook, since there aren't really
anything useful left to do at the point it is called, but if you want a
dummy callback there for code structure reasons then fine.

But you cannot just run around breaking stuff while slowly moving
towards this goal over multiple releases... v3.19 is currently broken
and that seems totally unnecessary.

In any case: You should have noticed this problem while testing your
patches.  The breakage is 100% reproducible. Unfortunately I had to do a
bisect to realize what you had done to the i915 driver, something I
unfortunately didn't find time to do before v3.19 was released.  But I
do find it unnecessary to release with such bugs.  Any attempt to
exercise the code path you modified would have revealed the bug.

> Reverting the commit may hide some other issue, so before doing that
> could you try the following patch:

Makes no difference.  I assume that patch fixes an unrelated bug? The
age and reported symptoms indicates so.  Note that I am reporting a
regression introduced after v3.18, while that seems to fix a bug
introduced in v3.17. Both v3.17 and v3.18 (including v3.18.6), as
well as earlier releases, work fine for me.

> If with that you still get the hang could you try on top of that the
> patch below, first having only pci_set_power_state uncommented, then
> both pci_set_power_state and pci_disable_device uncommented?

That patch fixes the problem, with only pci_set_power_state commented
out.  Do you still want me to try with pci_disable_device() commented
out as well?


  reply	other threads:[~2015-02-24 19:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 14:49 [BISECTED REGRESSION v3.18->v3.19-rc1] drm/i915: failure to poweroff after hibernation Bjørn Mork
2015-02-24 14:58 ` [PATCH] drm/i915: fix failure to power off after hibernate Bjørn Mork
2015-02-24 16:12   ` Imre Deak
2015-02-24 19:00     ` Bjørn Mork [this message]
2015-02-25 18:33       ` Imre Deak
2015-02-26  9:34         ` Bjørn Mork
2015-02-26 18:50           ` Imre Deak
2015-02-26 19:20             ` Bjørn Mork
2015-02-26 20:01             ` [Intel-gfx] " Daniel Vetter
2015-02-27 12:15               ` David Weinehall
2015-02-27 18:23                 ` Imre Deak
2015-03-02  8:55                   ` David Weinehall
2015-02-26 20:05             ` Ville Syrjälä
2015-02-26 20:29               ` Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] drm/i915: fix failure to power off after hibernate' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).