LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Michel Machado <michel@digirati.com.br>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Linux XIA - merge proposal
Date: Tue, 03 Mar 2015 17:33:18 -0600	[thread overview]
Message-ID: <87a8ztwta9.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <54F5EF6E.9090303@digirati.com.br> (Michel Machado's message of "Tue, 03 Mar 2015 12:29:18 -0500")

Michel Machado <michel@digirati.com.br> writes:

>    Linux XIA is not yet mature enough for production, but we do think
> that broader exposure will help us to move forward faster, and get
> more in tune with the interested community. Thus, we are writing to
> ask to merge our work into the Linux kernel.

I took a quick glance at the code to see if could figure out what
you were talking about.   Especialy as I could not find any documents
on the packet format.  The code does not transmit packets.  All of the
packet transmit functions are stubs.  I can think of no greater failure
for a networking protocol.

Since the code does nothing except have buzz-word compliant descriptions
that are content free I respectfully suggest you make it mostly work
before foisting it on people.

My advice for a future day when you have code that can transmit packets
is to start small.  Have patches that do things and do them clearly.
Once you have a minimal version of working code merged then work your
way up.

For just sharing your code you might simply want to have your own tree
that you publish publicly.

Eric

  reply	other threads:[~2015-03-03 23:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 17:29 Michel Machado
2015-03-03 23:33 ` Eric W. Biederman [this message]
2015-03-04  0:14   ` Michel Machado
2015-03-04  0:01 ` Daniel Borkmann
2015-03-04  0:31   ` Michel Machado
2015-03-04  5:49     ` Greg KH
2015-03-04 13:01       ` Michel Machado
2015-03-05 16:31 ` Alex Elsayed
2015-03-05 18:34 ` Michel Machado
2015-03-10 17:01 ` Bjorn Helgaas
2015-03-10 17:19   ` Eric Dumazet
2015-03-10 22:01     ` Bjorn Helgaas
2015-03-13 15:26   ` Michel Machado
2015-03-15  9:37     ` Greg KH
2015-03-15 10:03       ` Oded Gabbay
2015-03-17 12:37         ` Michel Machado
2015-03-17 12:25       ` Michel Machado
2015-03-18 10:27         ` Oded Gabbay
2015-03-20 18:46           ` Michel Machado
2015-03-20 19:41             ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8ztwta9.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@digirati.com.br \
    --cc=netdev@vger.kernel.org \
    --subject='Re: Linux XIA - merge proposal' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).