LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
@ 2021-09-03 15:24 Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
                   ` (14 more replies)
  0 siblings, 15 replies; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The drivers currently rely on irq_set_affinity_hint() to either set the
affinity_hint that is consumed by the userspace and/or to enforce a custom
affinity.

irq_set_affinity_hint() as the name suggests is originally introduced to
only set the affinity_hint to help the userspace in guiding the interrupts
and not the affinity itself. However, since the commit

        e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"

irq_set_affinity_hint() also started applying the provided cpumask (if not
NULL) as the affinity for the interrupts. The issue that this commit was
trying to solve is to allow the drivers to enforce their affinity mask to
distribute the interrupts across the CPUs such that they don't always end
up on CPU0. This issue has been resolved within the irq subsystem since the
commit

        a0c9259dc4e1 "irq/matrix: Spread interrupts on allocation"

Hence, there is no need for the drivers to overwrite the affinity to spread
as it is dynamically performed at the time of allocation.

Also, irq_set_affinity_hint() setting affinity unconditionally introduces
issues for the drivers that only want to set their affinity_hint and not the
affinity itself as for these driver interrupts the default_smp_affinity_mask
is completely ignored (for detailed investigation please refer to [1]).

Unfortunately reverting the commit e2e64a932556 is not an option at this
point for two reasons [2]:

- Several drivers for a valid reason (performance) rely on this API to
  enforce their affinity mask

- Until very recently this was the only exported interface that was
  available

To clear this out Thomas has come up with the following interfaces:

- irq_set_affinity(): only sets affinity of an IRQ [3]
- irq_update_affinity_hint(): Only sets the hint [4]
- irq_set_affinity_and_hint(): Sets both affinity and the hint mask [4]

The first API is already merged in the linus's tree and the patch
that introduces the other two interfaces is included with this patch-set.

To move to the stage where we can safely get rid of the
irq_set_affinity_hint(), which has been marked deprecated, we have to
move all its consumers to these new interfaces. In this patch-set, I have
done that for a few drivers and will hopefully try to move the remaining of
them in the coming days.

The two patches in this series that still needs to be reviewed are:
   be2net: Use irq_update_affinity_hint
   hinic: Use irq_set_affinity_and_hint

any help there will be much appreciated.

Change from v5 [5]
------------------

- Rebased on top of the latest Linus's tree:
	a9c9a6f741cd  "Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi"
- Added reviewed-by/acked-by in the patches


Change from v4 [6]
------------------
- Fixed kernel-doc warnings (Jakub Kicinski)

- Renamed the cover to "Cleanup the abuse of irq_set_affinity_hint()", what
  Thomas originally used as this series is an extension of the work that
  he started and proposed [7].

Change from v3 [8]
------------------
- Replaced irq_set_affinity_and_hint with irq_update_affinity_hint in irdma
  (Leon Romanovsky)
- rebased the patches on top of 5.14-rc2


Change from v2 [9]
------------------

- Rebased on top of 5.14-rc1 (Leon Romanovsky)
  + After discussion with Leon [10], made changes in the mlx5 patch to use
    irq_set_affinity_and_hint over irq_update_affinity_hint
  + i40iw is replaced with irdma driver, hence made the respective changes
    in irdma (also replcaed irq_update_affinity_hint with
    irq_set_affinity_and_hint).

Change from v1 [11]
------------------
- Fixed compilation error by adding the new interface definitions for cases
  where CONFIG_SMP is not defined

- Fixed function usage in megaraid_sas and removed unnecessary variable
  (Robin Murphy)

- Removed unwanted #if/endif from mlx4 (Leon Romanovsky)

- Other indentation related fixes

 
[1] https://lore.kernel.org/lkml/1a044a14-0884-eedb-5d30-28b4bec24b23@redhat.com/
[2] https://lore.kernel.org/linux-pci/d1d5e797-49ee-4968-88c6-c07119343492@arm.com/
[3] https://lore.kernel.org/linux-arm-kernel/20210518091725.046774792@linutronix.de/
[4] https://lore.kernel.org/patchwork/patch/1434326/
[5] https://lore.kernel.org/netdev/20210720232624.1493424-10-nitesh@redhat.com/T/
[6] https://lore.kernel.org/lkml/20210719180746.1008665-1-nitesh@redhat.com/
[7] https://lore.kernel.org/linux-arm-kernel/20210518091725.046774792@linutronix.de/
[8] https://lore.kernel.org/linux-scsi/20210713211502.464259-1-nitesh@redhat.com/
[9] https://lore.kernel.org/lkml/20210629152746.2953364-1-nitesh@redhat.com/
[10] https://lore.kernel.org/lkml/YO0eKv2GJcADQTHH@unreal/
[11] https://lore.kernel.org/linux-scsi/20210617182242.8637-1-nitesh@redhat.com/

Nitesh Narayan Lal (13):
  iavf: Use irq_update_affinity_hint
  i40e: Use irq_update_affinity_hint
  scsi: megaraid_sas: Use irq_set_affinity_and_hint
  scsi: mpt3sas: Use irq_set_affinity_and_hint
  RDMA/irdma: Use irq_update_affinity_hint
  enic: Use irq_update_affinity_hint
  be2net: Use irq_update_affinity_hint
  ixgbe: Use irq_update_affinity_hint
  mailbox: Use irq_update_affinity_hint
  scsi: lpfc: Use irq_set_affinity
  hinic: Use irq_set_affinity_and_hint
  net/mlx5: Use irq_set_affinity_and_hint
  net/mlx4: Use irq_update_affinity_hint

Thomas Gleixner (1):
  genirq: Provide new interfaces for affinity hints

 drivers/infiniband/hw/irdma/hw.c              |  4 +-
 drivers/mailbox/bcm-flexrm-mailbox.c          |  4 +-
 drivers/net/ethernet/cisco/enic/enic_main.c   |  8 +--
 drivers/net/ethernet/emulex/benet/be_main.c   |  4 +-
 drivers/net/ethernet/huawei/hinic/hinic_rx.c  |  4 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c   |  8 +--
 drivers/net/ethernet/intel/iavf/iavf_main.c   |  8 +--
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++--
 drivers/net/ethernet/mellanox/mlx4/eq.c       |  8 ++-
 .../net/ethernet/mellanox/mlx5/core/pci_irq.c |  8 +--
 drivers/scsi/lpfc/lpfc_init.c                 |  4 +-
 drivers/scsi/megaraid/megaraid_sas_base.c     | 27 +++++-----
 drivers/scsi/mpt3sas/mpt3sas_base.c           | 21 ++++----
 include/linux/interrupt.h                     | 53 ++++++++++++++++++-
 kernel/irq/manage.c                           |  8 +--
 15 files changed, 114 insertions(+), 65 deletions(-)

--  


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 01/14] genirq: Provide new interfaces for affinity hints
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

From: Thomas Gleixner <tglx@linutronix.de>

The discussion about removing the side effect of irq_set_affinity_hint() of
actually applying the cpumask (if not NULL) as affinity to the interrupt,
unearthed a few unpleasantries:

  1) The modular perf drivers rely on the current behaviour for the very
     wrong reasons.

  2) While none of the other drivers prevents user space from changing
     the affinity, a cursorily inspection shows that there are at least
     expectations in some drivers.

#1 needs to be cleaned up anyway, so that's not a problem

#2 might result in subtle regressions especially when irqbalanced (which
   nowadays ignores the affinity hint) is disabled.

Provide new interfaces:

  irq_update_affinity_hint()  - Only sets the affinity hint pointer
  irq_set_affinity_and_hint() - Set the pointer and apply the affinity to
                                the interrupt

Make irq_set_affinity_hint() a wrapper around irq_apply_affinity_hint() and
document it to be phased out.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Link: https://lore.kernel.org/r/20210501021832.743094-1-jesse.brandeburg@intel.com
Reviewed-by: Ming Lei <ming.lei@redhat.com>
---
 include/linux/interrupt.h | 53 ++++++++++++++++++++++++++++++++++++++-
 kernel/irq/manage.c       |  8 +++---
 2 files changed, 56 insertions(+), 5 deletions(-)

diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 1f22a30c0963..9367f1cb2e3c 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -329,7 +329,46 @@ extern int irq_force_affinity(unsigned int irq, const struct cpumask *cpumask);
 extern int irq_can_set_affinity(unsigned int irq);
 extern int irq_select_affinity(unsigned int irq);
 
-extern int irq_set_affinity_hint(unsigned int irq, const struct cpumask *m);
+extern int __irq_apply_affinity_hint(unsigned int irq, const struct cpumask *m,
+				     bool setaffinity);
+
+/**
+ * irq_update_affinity_hint - Update the affinity hint
+ * @irq:	Interrupt to update
+ * @m:		cpumask pointer (NULL to clear the hint)
+ *
+ * Updates the affinity hint, but does not change the affinity of the interrupt.
+ */
+static inline int
+irq_update_affinity_hint(unsigned int irq, const struct cpumask *m)
+{
+	return __irq_apply_affinity_hint(irq, m, false);
+}
+
+/**
+ * irq_set_affinity_and_hint - Update the affinity hint and apply the provided
+ *			     cpumask to the interrupt
+ * @irq:	Interrupt to update
+ * @m:		cpumask pointer (NULL to clear the hint)
+ *
+ * Updates the affinity hint and if @m is not NULL it applies it as the
+ * affinity of that interrupt.
+ */
+static inline int
+irq_set_affinity_and_hint(unsigned int irq, const struct cpumask *m)
+{
+	return __irq_apply_affinity_hint(irq, m, true);
+}
+
+/*
+ * Deprecated. Use irq_update_affinity_hint() or irq_set_affinity_and_hint()
+ * instead.
+ */
+static inline int irq_set_affinity_hint(unsigned int irq, const struct cpumask *m)
+{
+	return irq_set_affinity_and_hint(irq, m);
+}
+
 extern int irq_update_affinity_desc(unsigned int irq,
 				    struct irq_affinity_desc *affinity);
 
@@ -361,6 +400,18 @@ static inline int irq_can_set_affinity(unsigned int irq)
 
 static inline int irq_select_affinity(unsigned int irq)  { return 0; }
 
+static inline int irq_update_affinity_hint(unsigned int irq,
+					   const struct cpumask *m)
+{
+	return -EINVAL;
+}
+
+static inline int irq_set_affinity_and_hint(unsigned int irq,
+					    const struct cpumask *m)
+{
+	return -EINVAL;
+}
+
 static inline int irq_set_affinity_hint(unsigned int irq,
 					const struct cpumask *m)
 {
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 27667e82ecc9..707ad7be3378 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -486,7 +486,8 @@ int irq_force_affinity(unsigned int irq, const struct cpumask *cpumask)
 }
 EXPORT_SYMBOL_GPL(irq_force_affinity);
 
-int irq_set_affinity_hint(unsigned int irq, const struct cpumask *m)
+int __irq_apply_affinity_hint(unsigned int irq, const struct cpumask *m,
+			      bool setaffinity)
 {
 	unsigned long flags;
 	struct irq_desc *desc = irq_get_desc_lock(irq, &flags, IRQ_GET_DESC_CHECK_GLOBAL);
@@ -495,12 +496,11 @@ int irq_set_affinity_hint(unsigned int irq, const struct cpumask *m)
 		return -EINVAL;
 	desc->affinity_hint = m;
 	irq_put_desc_unlock(desc, flags);
-	/* set the initial affinity to prevent every interrupt being on CPU0 */
-	if (m)
+	if (m && setaffinity)
 		__irq_set_affinity(irq, m, false);
 	return 0;
 }
-EXPORT_SYMBOL_GPL(irq_set_affinity_hint);
+EXPORT_SYMBOL_GPL(__irq_apply_affinity_hint);
 
 static void irq_affinity_notify(struct work_struct *work)
 {
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 02/14] iavf: Use irq_update_affinity_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] iavf: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 03/14] i40e: Use irq_update_affinity_hint Nitesh Narayan Lal
                   ` (12 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() for two purposes:

- To set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- To apply an affinity that it provides for the iavf interrupts

The latter is done to ensure that all the interrupts are evenly spread
across all available CPUs. However, since commit a0c9259dc4e1 ("irq/matrix:
Spread interrupts on allocation") the spreading of interrupts is
dynamically performed at the time of allocation. Hence, there is no need
for the drivers to enforce their own affinity for the spreading of
interrupts.

Also, irq_set_affinity_hint() applying the provided cpumask as an affinity
for the interrupt is an undocumented side effect. To remove this side
effect irq_set_affinity_hint() has been marked as deprecated and new
interfaces have been introduced. Hence, replace the irq_set_affinity_hint()
with the new interface irq_update_affinity_hint() that only sets the
pointer for the affinity_hint.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
 drivers/net/ethernet/intel/iavf/iavf_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 23762a7ef740..1be2998d1a16 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -470,10 +470,10 @@ iavf_request_traffic_irqs(struct iavf_adapter *adapter, char *basename)
 		irq_set_affinity_notifier(irq_num, &q_vector->affinity_notify);
 		/* Spread the IRQ affinity hints across online CPUs. Note that
 		 * get_cpu_mask returns a mask with a permanent lifetime so
-		 * it's safe to use as a hint for irq_set_affinity_hint.
+		 * it's safe to use as a hint for irq_update_affinity_hint.
 		 */
 		cpu = cpumask_local_spread(q_vector->v_idx, -1);
-		irq_set_affinity_hint(irq_num, get_cpu_mask(cpu));
+		irq_update_affinity_hint(irq_num, get_cpu_mask(cpu));
 	}
 
 	return 0;
@@ -483,7 +483,7 @@ iavf_request_traffic_irqs(struct iavf_adapter *adapter, char *basename)
 		vector--;
 		irq_num = adapter->msix_entries[vector + NONQ_VECS].vector;
 		irq_set_affinity_notifier(irq_num, NULL);
-		irq_set_affinity_hint(irq_num, NULL);
+		irq_update_affinity_hint(irq_num, NULL);
 		free_irq(irq_num, &adapter->q_vectors[vector]);
 	}
 	return err;
@@ -535,7 +535,7 @@ static void iavf_free_traffic_irqs(struct iavf_adapter *adapter)
 	for (vector = 0; vector < q_vectors; vector++) {
 		irq_num = adapter->msix_entries[vector + NONQ_VECS].vector;
 		irq_set_affinity_notifier(irq_num, NULL);
-		irq_set_affinity_hint(irq_num, NULL);
+		irq_update_affinity_hint(irq_num, NULL);
 		free_irq(irq_num, &adapter->q_vectors[vector]);
 	}
 }
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 03/14] i40e: Use irq_update_affinity_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] i40e: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
                   ` (11 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() for two purposes:

- To set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- To apply an affinity that it provides for the i40e interrupts

The latter is done to ensure that all the interrupts are evenly spread
across all available CPUs. However, since commit a0c9259dc4e1 ("irq/matrix:
Spread interrupts on allocation") the spreading of interrupts is
dynamically performed at the time of allocation. Hence, there is no need
for the drivers to enforce their own affinity for the spreading of
interrupts.

Also, irq_set_affinity_hint() applying the provided cpumask as an affinity
for the interrupt is an undocumented side effect. To remove this side
effect irq_set_affinity_hint() has been marked as deprecated and new
interfaces have been introduced. Hence, replace the irq_set_affinity_hint()
with the new interface irq_update_affinity_hint() that only sets the
pointer for the affinity_hint.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 2f20980dd9a5..399aeceecdb2 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -3873,10 +3873,10 @@ static int i40e_vsi_request_irq_msix(struct i40e_vsi *vsi, char *basename)
 		 *
 		 * get_cpu_mask returns a static constant mask with
 		 * a permanent lifetime so it's ok to pass to
-		 * irq_set_affinity_hint without making a copy.
+		 * irq_update_affinity_hint without making a copy.
 		 */
 		cpu = cpumask_local_spread(q_vector->v_idx, -1);
-		irq_set_affinity_hint(irq_num, get_cpu_mask(cpu));
+		irq_update_affinity_hint(irq_num, get_cpu_mask(cpu));
 	}
 
 	vsi->irqs_ready = true;
@@ -3887,7 +3887,7 @@ static int i40e_vsi_request_irq_msix(struct i40e_vsi *vsi, char *basename)
 		vector--;
 		irq_num = pf->msix_entries[base + vector].vector;
 		irq_set_affinity_notifier(irq_num, NULL);
-		irq_set_affinity_hint(irq_num, NULL);
+		irq_update_affinity_hint(irq_num, NULL);
 		free_irq(irq_num, &vsi->q_vectors[vector]);
 	}
 	return err;
@@ -4708,7 +4708,7 @@ static void i40e_vsi_free_irq(struct i40e_vsi *vsi)
 			/* clear the affinity notifier in the IRQ descriptor */
 			irq_set_affinity_notifier(irq_num, NULL);
 			/* remove our suggested affinity mask for this IRQ */
-			irq_set_affinity_hint(irq_num, NULL);
+			irq_update_affinity_hint(irq_num, NULL);
 			synchronize_irq(irq_num);
 			free_irq(irq_num, vsi->q_vectors[i]);
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (2 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 03/14] i40e: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] scsi: megaraid_sas: Use irq_set_affinity_and_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 05/14] scsi: mpt3sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
                   ` (10 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() specifically for the high IOPS
queue interrupts for two purposes:

- To set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- To apply an affinity that it provides

The driver enforces its own affinity to bind the high IOPS queue interrupts
to the local NUMA node. However, irq_set_affinity_hint() applying the
provided cpumask as an affinity for the interrupt is an undocumented side
effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Change the megasas_set_high_iops_queue_affinity_hint function name to
megasas_set_high_iops_queue_affinity_and_hint to clearly indicate that the
function is setting both affinity and affinity_hint.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 27 +++++++++++++----------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index e4298bf4a482..f39642b1ffe7 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5718,7 +5718,7 @@ megasas_setup_irqs_msix(struct megasas_instance *instance, u8 is_probe)
 				"Failed to register IRQ for vector %d.\n", i);
 			for (j = 0; j < i; j++) {
 				if (j < instance->low_latency_index_start)
-					irq_set_affinity_hint(
+					irq_update_affinity_hint(
 						pci_irq_vector(pdev, j), NULL);
 				free_irq(pci_irq_vector(pdev, j),
 					 &instance->irq_context[j]);
@@ -5761,7 +5761,7 @@ megasas_destroy_irqs(struct megasas_instance *instance) {
 	if (instance->msix_vectors)
 		for (i = 0; i < instance->msix_vectors; i++) {
 			if (i < instance->low_latency_index_start)
-				irq_set_affinity_hint(
+				irq_update_affinity_hint(
 				    pci_irq_vector(instance->pdev, i), NULL);
 			free_irq(pci_irq_vector(instance->pdev, i),
 				 &instance->irq_context[i]);
@@ -5892,22 +5892,25 @@ int megasas_get_device_list(struct megasas_instance *instance)
 }
 
 /**
- * megasas_set_high_iops_queue_affinity_hint -	Set affinity hint for high IOPS queues
- * @instance:					Adapter soft state
- * return:					void
+ * megasas_set_high_iops_queue_affinity_and_hint -	Set affinity and hint
+ *							for high IOPS queues
+ * @instance:						Adapter soft state
+ * return:						void
  */
 static inline void
-megasas_set_high_iops_queue_affinity_hint(struct megasas_instance *instance)
+megasas_set_high_iops_queue_affinity_and_hint(struct megasas_instance *instance)
 {
 	int i;
-	int local_numa_node;
+	unsigned int irq;
+	const struct cpumask *mask;
 
 	if (instance->perf_mode == MR_BALANCED_PERF_MODE) {
-		local_numa_node = dev_to_node(&instance->pdev->dev);
+		mask = cpumask_of_node(dev_to_node(&instance->pdev->dev));
 
-		for (i = 0; i < instance->low_latency_index_start; i++)
-			irq_set_affinity_hint(pci_irq_vector(instance->pdev, i),
-				cpumask_of_node(local_numa_node));
+		for (i = 0; i < instance->low_latency_index_start; i++) {
+			irq = pci_irq_vector(instance->pdev, i);
+			irq_set_affinity_and_hint(irq, mask);
+		}
 	}
 }
 
@@ -5996,7 +5999,7 @@ megasas_alloc_irq_vectors(struct megasas_instance *instance)
 		instance->msix_vectors = 0;
 
 	if (instance->smp_affinity_enable)
-		megasas_set_high_iops_queue_affinity_hint(instance);
+		megasas_set_high_iops_queue_affinity_and_hint(instance);
 }
 
 /**
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 05/14] scsi: mpt3sas: Use irq_set_affinity_and_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (3 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] scsi: mpt3sas: Use irq_set_affinity_and_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 06/14] RDMA/irdma: Use irq_update_affinity_hint Nitesh Narayan Lal
                   ` (9 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() specifically for the high IOPS
queue interrupts for two purposes:

- To set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- To apply an affinity that it provides

The driver enforces its own affinity to bind the high IOPS queue interrupts
to the local NUMA node. However, irq_set_affinity_hint() applying the
provided cpumask as an affinity (if not NULL) for the interrupt is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Reviewed-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 6c82435bc9cc..48b826b3414f 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -3084,6 +3084,7 @@ _base_check_enable_msix(struct MPT3SAS_ADAPTER *ioc)
 void
 mpt3sas_base_free_irq(struct MPT3SAS_ADAPTER *ioc)
 {
+	unsigned int irq;
 	struct adapter_reply_queue *reply_q, *next;
 
 	if (list_empty(&ioc->reply_queue_list))
@@ -3096,9 +3097,10 @@ mpt3sas_base_free_irq(struct MPT3SAS_ADAPTER *ioc)
 			continue;
 		}
 
-		if (ioc->smp_affinity_enable)
-			irq_set_affinity_hint(pci_irq_vector(ioc->pdev,
-			    reply_q->msix_index), NULL);
+		if (ioc->smp_affinity_enable) {
+			irq = pci_irq_vector(ioc->pdev, reply_q->msix_index);
+			irq_update_affinity_hint(irq, NULL);
+		}
 		free_irq(pci_irq_vector(ioc->pdev, reply_q->msix_index),
 			 reply_q);
 		kfree(reply_q);
@@ -3165,18 +3167,15 @@ _base_request_irq(struct MPT3SAS_ADAPTER *ioc, u8 index)
  * @ioc: per adapter object
  *
  * The enduser would need to set the affinity via /proc/irq/#/smp_affinity
- *
- * It would nice if we could call irq_set_affinity, however it is not
- * an exported symbol
  */
 static void
 _base_assign_reply_queues(struct MPT3SAS_ADAPTER *ioc)
 {
-	unsigned int cpu, nr_cpus, nr_msix, index = 0;
+	unsigned int cpu, nr_cpus, nr_msix, index = 0, irq;
 	struct adapter_reply_queue *reply_q;
-	int local_numa_node;
 	int iopoll_q_count = ioc->reply_queue_count -
 	    ioc->iopoll_q_start_index;
+	const struct cpumask *mask;
 
 	if (!_base_is_controller_msix_enabled(ioc))
 		return;
@@ -3199,11 +3198,11 @@ _base_assign_reply_queues(struct MPT3SAS_ADAPTER *ioc)
 		 * corresponding to high iops queues.
 		 */
 		if (ioc->high_iops_queues) {
-			local_numa_node = dev_to_node(&ioc->pdev->dev);
+			mask = cpumask_of_node(dev_to_node(&ioc->pdev->dev));
 			for (index = 0; index < ioc->high_iops_queues;
 			    index++) {
-				irq_set_affinity_hint(pci_irq_vector(ioc->pdev,
-				    index), cpumask_of_node(local_numa_node));
+				irq = pci_irq_vector(ioc->pdev, index);
+				irq_set_affinity_and_hint(irq, mask);
 			}
 		}
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 06/14] RDMA/irdma: Use irq_update_affinity_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (4 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 05/14] scsi: mpt3sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] RDMA/irdma: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 07/14] enic: Use irq_update_affinity_hint Nitesh Narayan Lal
                   ` (8 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Acked-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
---
 drivers/infiniband/hw/irdma/hw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
index 00de5ee9a260..cc165065447a 100644
--- a/drivers/infiniband/hw/irdma/hw.c
+++ b/drivers/infiniband/hw/irdma/hw.c
@@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
 	struct irdma_sc_dev *dev = &rf->sc_dev;
 
 	dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx);
-	irq_set_affinity_hint(msix_vec->irq, NULL);
+	irq_update_affinity_hint(msix_vec->irq, NULL);
 	free_irq(msix_vec->irq, dev_id);
 }
 
@@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq,
 	}
 	cpumask_clear(&msix_vec->mask);
 	cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask);
-	irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask);
+	irq_update_affinity_hint(msix_vec->irq, &msix_vec->mask);
 	if (status) {
 		ibdev_dbg(&rf->iwdev->ibdev, "ERR: ceq irq config fail\n");
 		return IRDMA_ERR_CFG;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 07/14] enic: Use irq_update_affinity_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (5 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 06/14] RDMA/irdma: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] enic: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 08/14] be2net: Use irq_update_affinity_hint Nitesh Narayan Lal
                   ` (7 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Reviewed-by: Christian Benvenuti <benve@cisco.com>
---
 drivers/net/ethernet/cisco/enic/enic_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index d0a8f7106958..97eb5bd62855 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -150,10 +150,10 @@ static void enic_set_affinity_hint(struct enic *enic)
 		    !cpumask_available(enic->msix[i].affinity_mask) ||
 		    cpumask_empty(enic->msix[i].affinity_mask))
 			continue;
-		err = irq_set_affinity_hint(enic->msix_entry[i].vector,
-					    enic->msix[i].affinity_mask);
+		err = irq_update_affinity_hint(enic->msix_entry[i].vector,
+					       enic->msix[i].affinity_mask);
 		if (err)
-			netdev_warn(enic->netdev, "irq_set_affinity_hint failed, err %d\n",
+			netdev_warn(enic->netdev, "irq_update_affinity_hint failed, err %d\n",
 				    err);
 	}
 
@@ -173,7 +173,7 @@ static void enic_unset_affinity_hint(struct enic *enic)
 	int i;
 
 	for (i = 0; i < enic->intr_count; i++)
-		irq_set_affinity_hint(enic->msix_entry[i].vector, NULL);
+		irq_update_affinity_hint(enic->msix_entry[i].vector, NULL);
 }
 
 static int enic_udp_tunnel_set_port(struct net_device *netdev,
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 08/14] be2net: Use irq_update_affinity_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (6 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 07/14] enic: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] be2net: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 09/14] ixgbe: Use irq_update_affinity_hint Nitesh Narayan Lal
                   ` (6 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 361c1c87c183..ece6c0692826 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3491,7 +3491,7 @@ static int be_msix_register(struct be_adapter *adapter)
 		if (status)
 			goto err_msix;
 
-		irq_set_affinity_hint(vec, eqo->affinity_mask);
+		irq_update_affinity_hint(vec, eqo->affinity_mask);
 	}
 
 	return 0;
@@ -3552,7 +3552,7 @@ static void be_irq_unregister(struct be_adapter *adapter)
 	/* MSIx */
 	for_all_evt_queues(adapter, eqo, i) {
 		vec = be_msix_vec_get(adapter, eqo);
-		irq_set_affinity_hint(vec, NULL);
+		irq_update_affinity_hint(vec, NULL);
 		free_irq(vec, eqo);
 	}
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 09/14] ixgbe: Use irq_update_affinity_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (7 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 08/14] be2net: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] ixgbe: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 10/14] mailbox: Use irq_update_affinity_hint Nitesh Narayan Lal
                   ` (5 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 24e06ba6f5e9..66669f07d980 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -3242,8 +3242,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter)
 		/* If Flow Director is enabled, set interrupt affinity */
 		if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE) {
 			/* assign the mask for this irq */
-			irq_set_affinity_hint(entry->vector,
-					      &q_vector->affinity_mask);
+			irq_update_affinity_hint(entry->vector,
+						 &q_vector->affinity_mask);
 		}
 	}
 
@@ -3259,8 +3259,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter)
 free_queue_irqs:
 	while (vector) {
 		vector--;
-		irq_set_affinity_hint(adapter->msix_entries[vector].vector,
-				      NULL);
+		irq_update_affinity_hint(adapter->msix_entries[vector].vector,
+					 NULL);
 		free_irq(adapter->msix_entries[vector].vector,
 			 adapter->q_vector[vector]);
 	}
@@ -3393,7 +3393,7 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter)
 			continue;
 
 		/* clear the affinity_mask in the IRQ descriptor */
-		irq_set_affinity_hint(entry->vector, NULL);
+		irq_update_affinity_hint(entry->vector, NULL);
 
 		free_irq(entry->vector, q_vector);
 	}
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 10/14] mailbox: Use irq_update_affinity_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (8 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 09/14] ixgbe: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] mailbox: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
                   ` (4 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() to:

- Set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- Enforce affinity

As per commit 6ac17fe8c14a ("mailbox: bcm-flexrm-mailbox: Set IRQ affinity
hint for FlexRM ring IRQs") the latter is done to ensure that the FlexRM
ring interrupts are evenly spread across all available CPUs. However, since
commit a0c9259dc4e1 ("irq/matrix: Spread interrupts on allocation") the
spreading of interrupts is dynamically performed at the time of allocation.
Hence, there is no need for the drivers to enforce their own affinity for
the spreading of interrupts.

Also, irq_set_affinity_hint() applying the provided cpumask as an affinity
for the interrupt is an undocumented side effect. To remove this side
effect irq_set_affinity_hint() has been marked as deprecated and new
interfaces have been introduced. Hence, replace the irq_set_affinity_hint()
with the new interface irq_update_affinity_hint() that only sets the
affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
---
 drivers/mailbox/bcm-flexrm-mailbox.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index 78073ad1f2f1..16982c13d323 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1298,7 +1298,7 @@ static int flexrm_startup(struct mbox_chan *chan)
 	val = (num_online_cpus() < val) ? val / num_online_cpus() : 1;
 	cpumask_set_cpu((ring->num / val) % num_online_cpus(),
 			&ring->irq_aff_hint);
-	ret = irq_set_affinity_hint(ring->irq, &ring->irq_aff_hint);
+	ret = irq_update_affinity_hint(ring->irq, &ring->irq_aff_hint);
 	if (ret) {
 		dev_err(ring->mbox->dev,
 			"failed to set IRQ affinity hint for ring%d\n",
@@ -1425,7 +1425,7 @@ static void flexrm_shutdown(struct mbox_chan *chan)
 
 	/* Release IRQ */
 	if (ring->irq_requested) {
-		irq_set_affinity_hint(ring->irq, NULL);
+		irq_update_affinity_hint(ring->irq, NULL);
 		free_irq(ring->irq, ring);
 		ring->irq_requested = false;
 	}
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 11/14] scsi: lpfc: Use irq_set_affinity
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (9 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 10/14] mailbox: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] scsi: lpfc: Use irq_set_affinity() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
                   ` (3 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint to set the affinity for the lpfc
interrupts to a mask corresponding to the local NUMA node to avoid
performance overhead on AMD architectures.

However, irq_set_affinity_hint() setting the affinity is an undocumented
side effect that this function also sets the affinity under the hood.
To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced.

Also, as per the commit dcaa21367938 ("scsi: lpfc: Change default IRQ model
on AMD architectures"):
"On AMD architecture, revert the irq allocation to the normal style
(non-managed) and then use irq_set_affinity_hint() to set the cpu affinity
and disable user-space rebalancing."
we don't really need to set the affinity_hint as user-space rebalancing for
the lpfc interrupts is not desired.

Hence, replace the irq_set_affinity_hint() with irq_set_affinity() which
only applies the affinity for the interrupts.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Reviewed-by: James Smart <jsmart2021@gmail.com>
---
 drivers/scsi/lpfc/lpfc_init.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 0ec322f0e3cb..5d761ad642a5 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -12617,7 +12617,7 @@ lpfc_irq_set_aff(struct lpfc_hba_eq_hdl *eqhdl, unsigned int cpu)
 	cpumask_clear(&eqhdl->aff_mask);
 	cpumask_set_cpu(cpu, &eqhdl->aff_mask);
 	irq_set_status_flags(eqhdl->irq, IRQ_NO_BALANCING);
-	irq_set_affinity_hint(eqhdl->irq, &eqhdl->aff_mask);
+	irq_set_affinity(eqhdl->irq, &eqhdl->aff_mask);
 }
 
 /**
@@ -12906,7 +12906,6 @@ lpfc_sli4_enable_msix(struct lpfc_hba *phba)
 	for (--index; index >= 0; index--) {
 		eqhdl = lpfc_get_eq_hdl(index);
 		lpfc_irq_clear_aff(eqhdl);
-		irq_set_affinity_hint(eqhdl->irq, NULL);
 		free_irq(eqhdl->irq, eqhdl);
 	}
 
@@ -13067,7 +13066,6 @@ lpfc_sli4_disable_intr(struct lpfc_hba *phba)
 		for (index = 0; index < phba->cfg_irq_chann; index++) {
 			eqhdl = lpfc_get_eq_hdl(index);
 			lpfc_irq_clear_aff(eqhdl);
-			irq_set_affinity_hint(eqhdl->irq, NULL);
 			free_irq(eqhdl->irq, eqhdl);
 		}
 	} else {
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 12/14] hinic: Use irq_set_affinity_and_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (10 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] hinic: Use irq_set_affinity_and_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 13/14] net/mlx5: Use irq_set_affinity_and_hint Nitesh Narayan Lal
                   ` (2 subsequent siblings)
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() to:

- Set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- Enforce affinity

As per commit 352f58b0d9f2 ("net-next/hinic: Set Rxq irq to specific cpu
for NUMA"), the hinic driver enforces its own affinity to bind IRQs to the
local NUMA node. However, irq_set_affinity_hint() applying the provided
cpumask as an affinity for the interrupt is an undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
---
 drivers/net/ethernet/huawei/hinic/hinic_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
index fed3b6bc0d76..b33ed4d92b71 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
@@ -548,7 +548,7 @@ static int rx_request_irq(struct hinic_rxq *rxq)
 		goto err_req_irq;
 
 	cpumask_set_cpu(qp->q_id % num_online_cpus(), &rq->affinity_mask);
-	err = irq_set_affinity_hint(rq->irq, &rq->affinity_mask);
+	err = irq_set_affinity_and_hint(rq->irq, &rq->affinity_mask);
 	if (err)
 		goto err_irq_affinity;
 
@@ -565,7 +565,7 @@ static void rx_free_irq(struct hinic_rxq *rxq)
 {
 	struct hinic_rq *rq = rxq->rq;
 
-	irq_set_affinity_hint(rq->irq, NULL);
+	irq_update_affinity_hint(rq->irq, NULL);
 	free_irq(rq->irq, rxq);
 	rx_del_napi(rxq);
 }
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 13/14] net/mlx5: Use irq_set_affinity_and_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (11 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] net/mlx5: Use irq_set_affinity_and_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-03 15:24 ` [PATCH v6 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal
  2021-09-13 14:34 ` [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Lal
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts and to apply
the provided mask as the affinity for the mlx5 interrupts. However,
irq_set_affinity_hint() applying the provided cpumask as an affinity for
the interrupt is an undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
index c79a10b3454d..1c96d136dbac 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
@@ -143,11 +143,11 @@ static void irq_release(struct mlx5_irq *irq)
 	struct mlx5_irq_pool *pool = irq->pool;
 
 	xa_erase(&pool->irqs, irq->index);
-	/* free_irq requires that affinity and rmap will be cleared
+	/* free_irq requires that affinity_hint and rmap will be cleared
 	 * before calling it. This is why there is asymmetry with set_rmap
 	 * which should be called after alloc_irq but before request_irq.
 	 */
-	irq_set_affinity_hint(irq->irqn, NULL);
+	irq_update_affinity_hint(irq->irqn, NULL);
 	free_cpumask_var(irq->mask);
 	free_irq(irq->irqn, &irq->nh);
 	kfree(irq);
@@ -306,7 +306,7 @@ static struct mlx5_irq *irq_pool_create_irq(struct mlx5_irq_pool *pool,
 	if (IS_ERR(irq))
 		return irq;
 	cpumask_copy(irq->mask, affinity);
-	irq_set_affinity_hint(irq->irqn, irq->mask);
+	irq_set_affinity_and_hint(irq->irqn, irq->mask);
 	return irq;
 }
 
@@ -386,7 +386,7 @@ irq_pool_request_vector(struct mlx5_irq_pool *pool, int vecidx,
 	if (IS_ERR(irq) || !affinity)
 		goto unlock;
 	cpumask_copy(irq->mask, affinity);
-	irq_set_affinity_hint(irq->irqn, irq->mask);
+	irq_set_affinity_and_hint(irq->irqn, irq->mask);
 unlock:
 	mutex_unlock(&pool->lock);
 	return irq;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH v6 14/14] net/mlx4: Use irq_update_affinity_hint
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (12 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 13/14] net/mlx5: Use irq_set_affinity_and_hint Nitesh Narayan Lal
@ 2021-09-03 15:24 ` Nitesh Narayan Lal
  2021-12-10 19:54   ` [tip: irq/core] net/mlx4: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
  2021-09-13 14:34 ` [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Lal
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Narayan Lal @ 2021-09-03 15:24 UTC (permalink / raw)
  To: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, mtosatti, juri.lelli, frederic,
	abelits, bhelgaas, rostedt, peterz
  Cc: nilal, jesse.brandeburg, robin.murphy, mingo, jbrandeb, akpm,
	sfr, stephen, rppt, chris.friesen, maz, nhorman, pjwaskiewicz,
	sassmann, thenzl, james.smart, dick.kennedy, jkc, faisal.latif,
	shiraz.saleem, tariqt, ahleihel, kheib, borisp, saeedm,
	tatyana.e.nikolova, mustafa.ismail, ahs3, leonro,
	chandrakanth.patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, poros, minlei, emilne, jejb, martin.petersen,
	kabel, viresh.kumar, kuba, kashyap.desai, sumit.saxena,
	shivasharan.srikanteshwara, sathya.prakash, sreekanth.reddy,
	suganath-prabu.subramani, tglx, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx4/eq.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
index 9e48509ed3b2..414e390e6b48 100644
--- a/drivers/net/ethernet/mellanox/mlx4/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
@@ -244,9 +244,9 @@ static void mlx4_set_eq_affinity_hint(struct mlx4_priv *priv, int vec)
 	    cpumask_empty(eq->affinity_mask))
 		return;
 
-	hint_err = irq_set_affinity_hint(eq->irq, eq->affinity_mask);
+	hint_err = irq_update_affinity_hint(eq->irq, eq->affinity_mask);
 	if (hint_err)
-		mlx4_warn(dev, "irq_set_affinity_hint failed, err %d\n", hint_err);
+		mlx4_warn(dev, "irq_update_affinity_hint failed, err %d\n", hint_err);
 }
 #endif
 
@@ -1123,9 +1123,7 @@ static void mlx4_free_irqs(struct mlx4_dev *dev)
 	for (i = 0; i < dev->caps.num_comp_vectors + 1; ++i)
 		if (eq_table->eq[i].have_irq) {
 			free_cpumask_var(eq_table->eq[i].affinity_mask);
-#if defined(CONFIG_SMP)
-			irq_set_affinity_hint(eq_table->eq[i].irq, NULL);
-#endif
+			irq_update_affinity_hint(eq_table->eq[i].irq, NULL);
 			free_irq(eq_table->eq[i].irq, eq_table->eq + i);
 			eq_table->eq[i].have_irq = 0;
 		}
-- 
2.27.0


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
  2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
                   ` (13 preceding siblings ...)
  2021-09-03 15:24 ` [PATCH v6 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-09-13 14:34 ` Nitesh Lal
  2021-11-24 19:30   ` Thomas Gleixner
  14 siblings, 1 reply; 34+ messages in thread
From: Nitesh Lal @ 2021-09-13 14:34 UTC (permalink / raw)
  To: Thomas Gleixner, Juri Lelli, Marcelo Tosatti
  Cc: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, Frederic Weisbecker, Alex Belits,
	Bjorn Helgaas, rostedt, Peter Zijlstra, Jesse Brandeburg,
	Robin Murphy, Ingo Molnar, jbrandeb, akpm, sfr, stephen, rppt,
	chris.friesen, Marc Zyngier, Neil Horman, pjwaskiewicz,
	Stefan Assmann, Tomas Henzl, james.smart, Dick Kennedy, Ken Cox,
	faisal.latif, shiraz.saleem, tariqt, Alaa Hleihel, Kamal Heib,
	borisp, saeedm, Nikolova, Tatyana E, Ismail, Mustafa, Al Stone,
	Leon Romanovsky, Chandrakanth Patil, bjorn.andersson,
	chunkuang.hu, yongqiang.niu, baolin.wang7, Petr Oros, Ming Lei,
	Ewan Milne, jejb, Martin K. Petersen, kabel, Viresh Kumar,
	Jakub Kicinski, kashyap.desai, Sumit Saxena,
	shivasharan.srikanteshwara, sathya.prakash, Sreekanth Reddy,
	suganath-prabu.subramani, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

On Fri, Sep 3, 2021 at 11:25 AM Nitesh Narayan Lal <nitesh@redhat.com> wrote:
>
> The drivers currently rely on irq_set_affinity_hint() to either set the
> affinity_hint that is consumed by the userspace and/or to enforce a custom
> affinity.
>
> irq_set_affinity_hint() as the name suggests is originally introduced to
> only set the affinity_hint to help the userspace in guiding the interrupts
> and not the affinity itself. However, since the commit
>
>         e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"

[...]

>
> Nitesh Narayan Lal (13):
>   iavf: Use irq_update_affinity_hint
>   i40e: Use irq_update_affinity_hint
>   scsi: megaraid_sas: Use irq_set_affinity_and_hint
>   scsi: mpt3sas: Use irq_set_affinity_and_hint
>   RDMA/irdma: Use irq_update_affinity_hint
>   enic: Use irq_update_affinity_hint
>   be2net: Use irq_update_affinity_hint
>   ixgbe: Use irq_update_affinity_hint
>   mailbox: Use irq_update_affinity_hint
>   scsi: lpfc: Use irq_set_affinity
>   hinic: Use irq_set_affinity_and_hint
>   net/mlx5: Use irq_set_affinity_and_hint
>   net/mlx4: Use irq_update_affinity_hint
>
> Thomas Gleixner (1):
>   genirq: Provide new interfaces for affinity hints
>

Any suggestions on what should be the next steps here? Unfortunately, I haven't
been able to get any reviews on the following two patches:
  be2net: Use irq_update_affinity_hint
  hinic: Use irq_set_affinity_and_hint

One option would be to proceed with the remaining patches and I can try
posting these two again when I post patches for the remaining drivers?

-- 
Thanks
Nitesh


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
  2021-09-13 14:34 ` [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Lal
@ 2021-11-24 19:30   ` Thomas Gleixner
  2021-11-24 22:16     ` Nitesh Lal
  0 siblings, 1 reply; 34+ messages in thread
From: Thomas Gleixner @ 2021-11-24 19:30 UTC (permalink / raw)
  To: Nitesh Lal, Juri Lelli, Marcelo Tosatti
  Cc: linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, Frederic Weisbecker, Alex Belits,
	Bjorn Helgaas, rostedt, Peter Zijlstra, Jesse Brandeburg,
	Robin Murphy, Ingo Molnar, jbrandeb, akpm, sfr, stephen, rppt,
	chris.friesen, Marc Zyngier, Neil Horman, pjwaskiewicz,
	Stefan Assmann, Tomas Henzl, james.smart, Dick Kennedy, Ken Cox,
	faisal.latif, shiraz.saleem, tariqt, Alaa Hleihel, Kamal Heib,
	borisp, saeedm, Nikolova, Tatyana E, Ismail, Mustafa, Al Stone,
	Leon Romanovsky, Chandrakanth Patil, bjorn.andersson,
	chunkuang.hu, yongqiang.niu, baolin.wang7, Petr Oros, Ming Lei,
	Ewan Milne, jejb, Martin K. Petersen, kabel, Viresh Kumar,
	Jakub Kicinski, kashyap.desai, Sumit Saxena,
	shivasharan.srikanteshwara, sathya.prakash, Sreekanth Reddy,
	suganath-prabu.subramani, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

Nitesh,

On Mon, Sep 13 2021 at 10:34, Nitesh Lal wrote:
> On Fri, Sep 3, 2021 at 11:25 AM Nitesh Narayan Lal <nitesh@redhat.com> wrote:
>>
>> The drivers currently rely on irq_set_affinity_hint() to either set the
>> affinity_hint that is consumed by the userspace and/or to enforce a custom
>> affinity.
>>
>> irq_set_affinity_hint() as the name suggests is originally introduced to
>> only set the affinity_hint to help the userspace in guiding the interrupts
>> and not the affinity itself. However, since the commit
>>
>>         e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"

sorry for ignoring this. It fell through the cracks.

>> Thomas Gleixner (1):
>>   genirq: Provide new interfaces for affinity hints

Did I actually write this?

> Any suggestions on what should be the next steps here? Unfortunately, I haven't
> been able to get any reviews on the following two patches:
>   be2net: Use irq_update_affinity_hint
>   hinic: Use irq_set_affinity_and_hint
>
> One option would be to proceed with the remaining patches and I can try
> posting these two again when I post patches for the remaining drivers?

The more general question is whether I should queue all the others or
whether some subsystem would prefer to pull in a tagged commit on top of
rc1. I'm happy to carry them all of course.

Thanks,

        tglx



^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
  2021-11-24 19:30   ` Thomas Gleixner
@ 2021-11-24 22:16     ` Nitesh Lal
  2021-12-10 13:51       ` Nitesh Lal
  0 siblings, 1 reply; 34+ messages in thread
From: Nitesh Lal @ 2021-11-24 22:16 UTC (permalink / raw)
  To: Thomas Gleixner, Martin K. Petersen, Dick Kennedy
  Cc: Juri Lelli, Marcelo Tosatti, linux-kernel, linux-pci, linux-scsi,
	netdev, davem, ajit.khaparde, sriharsha.basavapatna,
	somnath.kotur, huangguangbin2, huangdaode, Frederic Weisbecker,
	Alex Belits, Bjorn Helgaas, rostedt, Peter Zijlstra,
	Jesse Brandeburg, Robin Murphy, Ingo Molnar, jbrandeb, akpm, sfr,
	stephen, rppt, chris.friesen, Marc Zyngier, Neil Horman,
	pjwaskiewicz, Stefan Assmann, Tomas Henzl, james.smart, Ken Cox,
	faisal.latif, shiraz.saleem, tariqt, Alaa Hleihel, Kamal Heib,
	borisp, saeedm, Nikolova, Tatyana E, Ismail, Mustafa, Al Stone,
	Leon Romanovsky, Chandrakanth Patil, bjorn.andersson,
	chunkuang.hu, yongqiang.niu, baolin.wang7, Petr Oros, Ming Lei,
	Ewan Milne, jejb, kabel, Viresh Kumar, Jakub Kicinski,
	kashyap.desai, Sumit Saxena, shivasharan.srikanteshwara,
	sathya.prakash, Sreekanth Reddy, suganath-prabu.subramani,
	ley.foon.tan, jbrunet, johannes, snelson, lewis.hanly, benve,
	_govind, jassisinghbrar

On Wed, Nov 24, 2021 at 2:30 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Nitesh,
>
> On Mon, Sep 13 2021 at 10:34, Nitesh Lal wrote:
> > On Fri, Sep 3, 2021 at 11:25 AM Nitesh Narayan Lal <nitesh@redhat.com> wrote:
> >>
> >> The drivers currently rely on irq_set_affinity_hint() to either set the
> >> affinity_hint that is consumed by the userspace and/or to enforce a custom
> >> affinity.
> >>
> >> irq_set_affinity_hint() as the name suggests is originally introduced to
> >> only set the affinity_hint to help the userspace in guiding the interrupts
> >> and not the affinity itself. However, since the commit
> >>
> >>         e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"
>
> sorry for ignoring this. It fell through the cracks.


No worries, thank you for reviewing.

>
>
> >> Thomas Gleixner (1):
> >>   genirq: Provide new interfaces for affinity hints
>
> Did I actually write this?


Yeap, the idea and the initial patch came from you. :)

>
>
> > Any suggestions on what should be the next steps here? Unfortunately, I haven't
> > been able to get any reviews on the following two patches:
> >   be2net: Use irq_update_affinity_hint
> >   hinic: Use irq_set_affinity_and_hint
> >
> > One option would be to proceed with the remaining patches and I can try
> > posting these two again when I post patches for the remaining drivers?
>
> The more general question is whether I should queue all the others or
> whether some subsystem would prefer to pull in a tagged commit on top of
> rc1. I'm happy to carry them all of course.
>

I am fine either way.
In the past, while I was asking for more testing help I was asked if the
SCSI changes are part of Martins's scsi-fixes tree as that's something
Broadcom folks test to check for regression.
So, maybe Martin can pull this up?

-- 
Thanks
Nitesh


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
  2021-11-24 22:16     ` Nitesh Lal
@ 2021-12-10 13:51       ` Nitesh Lal
  2021-12-10 18:44         ` Thomas Gleixner
  0 siblings, 1 reply; 34+ messages in thread
From: Nitesh Lal @ 2021-12-10 13:51 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: Juri Lelli, Dick Kennedy, Thomas Gleixner, Marcelo Tosatti,
	linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, Frederic Weisbecker, Alex Belits,
	Bjorn Helgaas, rostedt, Peter Zijlstra, Jesse Brandeburg,
	Robin Murphy, Ingo Molnar, jbrandeb, akpm, sfr, stephen, rppt,
	chris.friesen, Marc Zyngier, Neil Horman, pjwaskiewicz,
	Stefan Assmann, Tomas Henzl, james.smart, Ken Cox, faisal.latif,
	shiraz.saleem, tariqt, Alaa Hleihel, Kamal Heib, borisp, saeedm,
	Nikolova, Tatyana E, Ismail, Mustafa, Al Stone, Leon Romanovsky,
	Chandrakanth Patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, Petr Oros, Ming Lei, Ewan Milne, jejb, kabel,
	Viresh Kumar, Jakub Kicinski, kashyap.desai, Sumit Saxena,
	shivasharan.srikanteshwara, sathya.prakash, Sreekanth Reddy,
	suganath-prabu.subramani, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

Hi Martin,

On Wed, Nov 24, 2021 at 5:16 PM Nitesh Lal <nilal@redhat.com> wrote:
>
> On Wed, Nov 24, 2021 at 2:30 PM Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > Nitesh,
> >
> > On Mon, Sep 13 2021 at 10:34, Nitesh Lal wrote:
> > > On Fri, Sep 3, 2021 at 11:25 AM Nitesh Narayan Lal <nitesh@redhat.com> wrote:
> > >>
> > >> The drivers currently rely on irq_set_affinity_hint() to either set the
> > >> affinity_hint that is consumed by the userspace and/or to enforce a custom
> > >> affinity.
> > >>
> > >> irq_set_affinity_hint() as the name suggests is originally introduced to
> > >> only set the affinity_hint to help the userspace in guiding the interrupts
> > >> and not the affinity itself. However, since the commit
> > >>
> > >>         e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"
> >
> > sorry for ignoring this. It fell through the cracks.
>
>
> No worries, thank you for reviewing.
>
> >
> >
> > >> Thomas Gleixner (1):
> > >>   genirq: Provide new interfaces for affinity hints
> >
> > Did I actually write this?
>
>
> Yeap, the idea and the initial patch came from you. :)
>
> >
> >
> > > Any suggestions on what should be the next steps here? Unfortunately, I haven't
> > > been able to get any reviews on the following two patches:
> > >   be2net: Use irq_update_affinity_hint
> > >   hinic: Use irq_set_affinity_and_hint
> > >
> > > One option would be to proceed with the remaining patches and I can try
> > > posting these two again when I post patches for the remaining drivers?
> >
> > The more general question is whether I should queue all the others or
> > whether some subsystem would prefer to pull in a tagged commit on top of
> > rc1. I'm happy to carry them all of course.
> >
>
> I am fine either way.
> In the past, while I was asking for more testing help I was asked if the
> SCSI changes are part of Martins's scsi-fixes tree as that's something
> Broadcom folks test to check for regression.
> So, maybe Martin can pull this up?
>

Gentle ping.
Any thoughts on the above query?

-- 
Thanks
Nitesh


^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
  2021-12-10 13:51       ` Nitesh Lal
@ 2021-12-10 18:44         ` Thomas Gleixner
  2021-12-10 18:54           ` Nitesh Lal
  0 siblings, 1 reply; 34+ messages in thread
From: Thomas Gleixner @ 2021-12-10 18:44 UTC (permalink / raw)
  To: Nitesh Lal, Martin K. Petersen
  Cc: Juri Lelli, Dick Kennedy, Marcelo Tosatti, linux-kernel,
	linux-pci, linux-scsi, netdev, davem, ajit.khaparde,
	sriharsha.basavapatna, somnath.kotur, huangguangbin2, huangdaode,
	Frederic Weisbecker, Alex Belits, Bjorn Helgaas, rostedt,
	Peter Zijlstra, Jesse Brandeburg, Robin Murphy, Ingo Molnar,
	jbrandeb, akpm, sfr, stephen, rppt, chris.friesen, Marc Zyngier,
	Neil Horman, pjwaskiewicz, Stefan Assmann, Tomas Henzl,
	james.smart, Ken Cox, faisal.latif, shiraz.saleem, tariqt,
	Alaa Hleihel, Kamal Heib, borisp, saeedm, Nikolova, Tatyana E,
	Ismail, Mustafa, Al Stone, Leon Romanovsky, Chandrakanth Patil,
	bjorn.andersson, chunkuang.hu, yongqiang.niu, baolin.wang7,
	Petr Oros, Ming Lei, Ewan Milne, jejb, kabel, Viresh Kumar,
	Jakub Kicinski, kashyap.desai, Sumit Saxena,
	shivasharan.srikanteshwara, sathya.prakash, Sreekanth Reddy,
	suganath-prabu.subramani, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

On Fri, Dec 10 2021 at 08:51, Nitesh Lal wrote:
> On Wed, Nov 24, 2021 at 5:16 PM Nitesh Lal <nilal@redhat.com> wrote:
>> > The more general question is whether I should queue all the others or
>> > whether some subsystem would prefer to pull in a tagged commit on top of
>> > rc1. I'm happy to carry them all of course.
>> >
>>
>> I am fine either way.
>> In the past, while I was asking for more testing help I was asked if the
>> SCSI changes are part of Martins's scsi-fixes tree as that's something
>> Broadcom folks test to check for regression.
>> So, maybe Martin can pull this up?
>>
>
> Gentle ping.
> Any thoughts on the above query?

As nobody cares, I'll pick it up.

Thanks,

        tglx

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()
  2021-12-10 18:44         ` Thomas Gleixner
@ 2021-12-10 18:54           ` Nitesh Lal
  0 siblings, 0 replies; 34+ messages in thread
From: Nitesh Lal @ 2021-12-10 18:54 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: Martin K. Petersen, Juri Lelli, Dick Kennedy, Marcelo Tosatti,
	linux-kernel, linux-pci, linux-scsi, netdev, davem,
	ajit.khaparde, sriharsha.basavapatna, somnath.kotur,
	huangguangbin2, huangdaode, Frederic Weisbecker, Alex Belits,
	Bjorn Helgaas, rostedt, Peter Zijlstra, Jesse Brandeburg,
	Robin Murphy, Ingo Molnar, jbrandeb, akpm, sfr, stephen, rppt,
	chris.friesen, Marc Zyngier, Neil Horman, pjwaskiewicz,
	Stefan Assmann, Tomas Henzl, james.smart, Ken Cox, faisal.latif,
	shiraz.saleem, tariqt, Alaa Hleihel, Kamal Heib, borisp, saeedm,
	Nikolova, Tatyana E, Ismail, Mustafa, Al Stone, Leon Romanovsky,
	Chandrakanth Patil, bjorn.andersson, chunkuang.hu, yongqiang.niu,
	baolin.wang7, Petr Oros, Ming Lei, Ewan Milne, jejb, kabel,
	Viresh Kumar, Jakub Kicinski, kashyap.desai, Sumit Saxena,
	shivasharan.srikanteshwara, sathya.prakash, Sreekanth Reddy,
	suganath-prabu.subramani, ley.foon.tan, jbrunet, johannes,
	snelson, lewis.hanly, benve, _govind, jassisinghbrar

On Fri, Dec 10, 2021 at 1:44 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Fri, Dec 10 2021 at 08:51, Nitesh Lal wrote:
> > On Wed, Nov 24, 2021 at 5:16 PM Nitesh Lal <nilal@redhat.com> wrote:
> >> > The more general question is whether I should queue all the others or
> >> > whether some subsystem would prefer to pull in a tagged commit on top of
> >> > rc1. I'm happy to carry them all of course.
> >> >
> >>
> >> I am fine either way.
> >> In the past, while I was asking for more testing help I was asked if the
> >> SCSI changes are part of Martins's scsi-fixes tree as that's something
> >> Broadcom folks test to check for regression.
> >> So, maybe Martin can pull this up?
> >>
> >
> > Gentle ping.
> > Any thoughts on the above query?
>
> As nobody cares, I'll pick it up.
>

Sounds good to me.
Thank you!

--
Nitesh


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] net/mlx4: Use irq_update_affinity_hint()
  2021-09-03 15:24 ` [PATCH v6 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Leon Romanovsky,
	Tariq Toukan, x86, linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     4b3ddc6462e83452182177b48c4bc53607acd68e
Gitweb:        https://git.kernel.org/tip/4b3ddc6462e83452182177b48c4bc53607acd68e
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:30 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:40 +01:00

net/mlx4: Use irq_update_affinity_hint()

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/20210903152430.244937-15-nitesh@redhat.com

---
 drivers/net/ethernet/mellanox/mlx4/eq.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
index 9e48509..414e390 100644
--- a/drivers/net/ethernet/mellanox/mlx4/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
@@ -244,9 +244,9 @@ static void mlx4_set_eq_affinity_hint(struct mlx4_priv *priv, int vec)
 	    cpumask_empty(eq->affinity_mask))
 		return;
 
-	hint_err = irq_set_affinity_hint(eq->irq, eq->affinity_mask);
+	hint_err = irq_update_affinity_hint(eq->irq, eq->affinity_mask);
 	if (hint_err)
-		mlx4_warn(dev, "irq_set_affinity_hint failed, err %d\n", hint_err);
+		mlx4_warn(dev, "irq_update_affinity_hint failed, err %d\n", hint_err);
 }
 #endif
 
@@ -1123,9 +1123,7 @@ static void mlx4_free_irqs(struct mlx4_dev *dev)
 	for (i = 0; i < dev->caps.num_comp_vectors + 1; ++i)
 		if (eq_table->eq[i].have_irq) {
 			free_cpumask_var(eq_table->eq[i].affinity_mask);
-#if defined(CONFIG_SMP)
-			irq_set_affinity_hint(eq_table->eq[i].irq, NULL);
-#endif
+			irq_update_affinity_hint(eq_table->eq[i].irq, NULL);
 			free_irq(eq_table->eq[i].irq, eq_table->eq + i);
 			eq_table->eq[i].have_irq = 0;
 		}

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] net/mlx5: Use irq_set_affinity_and_hint()
  2021-09-03 15:24 ` [PATCH v6 13/14] net/mlx5: Use irq_set_affinity_and_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Leon Romanovsky, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     7451e9ea8e2055af39afe7ff39a5f68d8ec6b98d
Gitweb:        https://git.kernel.org/tip/7451e9ea8e2055af39afe7ff39a5f68d8ec6b98d
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:29 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:39 +01:00

net/mlx5: Use irq_set_affinity_and_hint()

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts and to apply
the provided mask as the affinity for the mlx5 interrupts. However,
irq_set_affinity_hint() applying the provided cpumask as an affinity for
the interrupt is an undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20210903152430.244937-14-nitesh@redhat.com

---
 drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
index 830444f..54fb67c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
@@ -143,11 +143,11 @@ static void irq_release(struct mlx5_irq *irq)
 	struct mlx5_irq_pool *pool = irq->pool;
 
 	xa_erase(&pool->irqs, irq->index);
-	/* free_irq requires that affinity and rmap will be cleared
+	/* free_irq requires that affinity_hint and rmap will be cleared
 	 * before calling it. This is why there is asymmetry with set_rmap
 	 * which should be called after alloc_irq but before request_irq.
 	 */
-	irq_set_affinity_hint(irq->irqn, NULL);
+	irq_update_affinity_hint(irq->irqn, NULL);
 	free_cpumask_var(irq->mask);
 	free_irq(irq->irqn, &irq->nh);
 	kfree(irq);
@@ -316,7 +316,7 @@ static struct mlx5_irq *irq_pool_create_irq(struct mlx5_irq_pool *pool,
 	if (IS_ERR(irq))
 		return irq;
 	cpumask_copy(irq->mask, affinity);
-	irq_set_affinity_hint(irq->irqn, irq->mask);
+	irq_set_affinity_and_hint(irq->irqn, irq->mask);
 	return irq;
 }
 
@@ -399,7 +399,7 @@ irq_pool_request_vector(struct mlx5_irq_pool *pool, int vecidx,
 	if (!irq_pool_is_sf_pool(pool) && !pool->xa_num_irqs.max &&
 	    cpumask_empty(irq->mask))
 		cpumask_set_cpu(0, irq->mask);
-	irq_set_affinity_hint(irq->irqn, irq->mask);
+	irq_set_affinity_and_hint(irq->irqn, irq->mask);
 unlock:
 	mutex_unlock(&pool->lock);
 	return irq;

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] hinic: Use irq_set_affinity_and_hint()
  2021-09-03 15:24 ` [PATCH v6 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, x86, linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     2d1e72f235d665aa699fb821f6da6e8bde84cbde
Gitweb:        https://git.kernel.org/tip/2d1e72f235d665aa699fb821f6da6e8bde84cbde
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:28 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:39 +01:00

hinic: Use irq_set_affinity_and_hint()

The driver uses irq_set_affinity_hint() to:

 - Set the affinity_hint which is consumed by the userspace for
   distributing the interrupts

 - Enforce affinity

As per commit 352f58b0d9f2 ("net-next/hinic: Set Rxq irq to specific cpu
for NUMA"), the hinic driver enforces its own affinity to bind IRQs to the
local NUMA node. However, irq_set_affinity_hint() applying the provided
cpumask as an affinity for the interrupt is an undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210903152430.244937-13-nitesh@redhat.com

---
 drivers/net/ethernet/huawei/hinic/hinic_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
index fed3b6b..b33ed4d 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
@@ -548,7 +548,7 @@ static int rx_request_irq(struct hinic_rxq *rxq)
 		goto err_req_irq;
 
 	cpumask_set_cpu(qp->q_id % num_online_cpus(), &rq->affinity_mask);
-	err = irq_set_affinity_hint(rq->irq, &rq->affinity_mask);
+	err = irq_set_affinity_and_hint(rq->irq, &rq->affinity_mask);
 	if (err)
 		goto err_irq_affinity;
 
@@ -565,7 +565,7 @@ static void rx_free_irq(struct hinic_rxq *rxq)
 {
 	struct hinic_rq *rq = rxq->rq;
 
-	irq_set_affinity_hint(rq->irq, NULL);
+	irq_update_affinity_hint(rq->irq, NULL);
 	free_irq(rq->irq, rxq);
 	rx_del_napi(rxq);
 }

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] scsi: lpfc: Use irq_set_affinity()
  2021-09-03 15:24 ` [PATCH v6 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, James Smart, x86, linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     ce5a58a96ccc241c6e5cbb3360494ddfaf118afe
Gitweb:        https://git.kernel.org/tip/ce5a58a96ccc241c6e5cbb3360494ddfaf118afe
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:27 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:39 +01:00

scsi: lpfc: Use irq_set_affinity()

The driver uses irq_set_affinity_hint to set the affinity for the lpfc
interrupts to a mask corresponding to the local NUMA node to avoid
performance overhead on AMD architectures.

However, irq_set_affinity_hint() setting the affinity is an undocumented
side effect that this function also sets the affinity under the hood.
To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced.

Also, as per the commit dcaa21367938 ("scsi: lpfc: Change default IRQ model
on AMD architectures"):
"On AMD architecture, revert the irq allocation to the normal style
(non-managed) and then use irq_set_affinity_hint() to set the cpu affinity
and disable user-space rebalancing."
we don't really need to set the affinity_hint as user-space rebalancing for
the lpfc interrupts is not desired.

Hence, replace the irq_set_affinity_hint() with irq_set_affinity() which
only applies the affinity for the interrupts.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: James Smart <jsmart2021@gmail.com>
Link: https://lore.kernel.org/r/20210903152430.244937-12-nitesh@redhat.com

---
 drivers/scsi/lpfc/lpfc_init.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index ba17a8f..9457552 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -12709,7 +12709,7 @@ lpfc_irq_set_aff(struct lpfc_hba_eq_hdl *eqhdl, unsigned int cpu)
 	cpumask_clear(&eqhdl->aff_mask);
 	cpumask_set_cpu(cpu, &eqhdl->aff_mask);
 	irq_set_status_flags(eqhdl->irq, IRQ_NO_BALANCING);
-	irq_set_affinity_hint(eqhdl->irq, &eqhdl->aff_mask);
+	irq_set_affinity(eqhdl->irq, &eqhdl->aff_mask);
 }
 
 /**
@@ -12998,7 +12998,6 @@ cfg_fail_out:
 	for (--index; index >= 0; index--) {
 		eqhdl = lpfc_get_eq_hdl(index);
 		lpfc_irq_clear_aff(eqhdl);
-		irq_set_affinity_hint(eqhdl->irq, NULL);
 		free_irq(eqhdl->irq, eqhdl);
 	}
 
@@ -13159,7 +13158,6 @@ lpfc_sli4_disable_intr(struct lpfc_hba *phba)
 		for (index = 0; index < phba->cfg_irq_chann; index++) {
 			eqhdl = lpfc_get_eq_hdl(index);
 			lpfc_irq_clear_aff(eqhdl);
-			irq_set_affinity_hint(eqhdl->irq, NULL);
 			free_irq(eqhdl->irq, eqhdl);
 		}
 	} else {

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] mailbox: Use irq_update_affinity_hint()
  2021-09-03 15:24 ` [PATCH v6 10/14] mailbox: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Jassi Brar, x86, linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     bf886e1ef11a0155714ca93c975bb3f770e79d72
Gitweb:        https://git.kernel.org/tip/bf886e1ef11a0155714ca93c975bb3f770e79d72
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:26 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:39 +01:00

mailbox: Use irq_update_affinity_hint()

The driver uses irq_set_affinity_hint() to:

  - Set the affinity_hint which is consumed by the userspace for
    distributing the interrupts

  - Enforce affinity

As per commit 6ac17fe8c14a ("mailbox: bcm-flexrm-mailbox: Set IRQ affinity
hint for FlexRM ring IRQs") the latter is done to ensure that the FlexRM
ring interrupts are evenly spread across all available CPUs. However, since
commit a0c9259dc4e1 ("irq/matrix: Spread interrupts on allocation") the
spreading of interrupts is dynamically performed at the time of allocation.
Hence, there is no need for the drivers to enforce their own affinity for
the spreading of interrupts.

Also, irq_set_affinity_hint() applying the provided cpumask as an affinity
for the interrupt is an undocumented side effect. To remove this side
effect irq_set_affinity_hint() has been marked as deprecated and new
interfaces have been introduced. Hence, replace the irq_set_affinity_hint()
with the new interface irq_update_affinity_hint() that only sets the
affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Link: https://lore.kernel.org/r/20210903152430.244937-11-nitesh@redhat.com

---
 drivers/mailbox/bcm-flexrm-mailbox.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index 78073ad..16982c1 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1298,7 +1298,7 @@ static int flexrm_startup(struct mbox_chan *chan)
 	val = (num_online_cpus() < val) ? val / num_online_cpus() : 1;
 	cpumask_set_cpu((ring->num / val) % num_online_cpus(),
 			&ring->irq_aff_hint);
-	ret = irq_set_affinity_hint(ring->irq, &ring->irq_aff_hint);
+	ret = irq_update_affinity_hint(ring->irq, &ring->irq_aff_hint);
 	if (ret) {
 		dev_err(ring->mbox->dev,
 			"failed to set IRQ affinity hint for ring%d\n",
@@ -1425,7 +1425,7 @@ static void flexrm_shutdown(struct mbox_chan *chan)
 
 	/* Release IRQ */
 	if (ring->irq_requested) {
-		irq_set_affinity_hint(ring->irq, NULL);
+		irq_update_affinity_hint(ring->irq, NULL);
 		free_irq(ring->irq, ring);
 		ring->irq_requested = false;
 	}

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] ixgbe: Use irq_update_affinity_hint()
  2021-09-03 15:24 ` [PATCH v6 09/14] ixgbe: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Jesse Brandeburg, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     cc493264c01d055742a34cfbaecaffb258dcc58c
Gitweb:        https://git.kernel.org/tip/cc493264c01d055742a34cfbaecaffb258dcc58c
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:25 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:39 +01:00

ixgbe: Use irq_update_affinity_hint()

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Link: https://lore.kernel.org/r/20210903152430.244937-10-nitesh@redhat.com

---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 0f9f022..66068e1 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -3247,8 +3247,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter)
 		/* If Flow Director is enabled, set interrupt affinity */
 		if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE) {
 			/* assign the mask for this irq */
-			irq_set_affinity_hint(entry->vector,
-					      &q_vector->affinity_mask);
+			irq_update_affinity_hint(entry->vector,
+						 &q_vector->affinity_mask);
 		}
 	}
 
@@ -3264,8 +3264,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter)
 free_queue_irqs:
 	while (vector) {
 		vector--;
-		irq_set_affinity_hint(adapter->msix_entries[vector].vector,
-				      NULL);
+		irq_update_affinity_hint(adapter->msix_entries[vector].vector,
+					 NULL);
 		free_irq(adapter->msix_entries[vector].vector,
 			 adapter->q_vector[vector]);
 	}
@@ -3398,7 +3398,7 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter)
 			continue;
 
 		/* clear the affinity_mask in the IRQ descriptor */
-		irq_set_affinity_hint(entry->vector, NULL);
+		irq_update_affinity_hint(entry->vector, NULL);
 
 		free_irq(entry->vector, q_vector);
 	}

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] be2net: Use irq_update_affinity_hint()
  2021-09-03 15:24 ` [PATCH v6 08/14] be2net: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, x86, linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     b8b9dd525203304d36bd123fca3ce0c3b318339b
Gitweb:        https://git.kernel.org/tip/b8b9dd525203304d36bd123fca3ce0c3b318339b
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:24 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:39 +01:00

be2net: Use irq_update_affinity_hint()

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210903152430.244937-9-nitesh@redhat.com

---
 drivers/net/ethernet/emulex/benet/be_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index d51f24c..84b3ba9 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3491,7 +3491,7 @@ static int be_msix_register(struct be_adapter *adapter)
 		if (status)
 			goto err_msix;
 
-		irq_set_affinity_hint(vec, eqo->affinity_mask);
+		irq_update_affinity_hint(vec, eqo->affinity_mask);
 	}
 
 	return 0;
@@ -3552,7 +3552,7 @@ static void be_irq_unregister(struct be_adapter *adapter)
 	/* MSIx */
 	for_all_evt_queues(adapter, eqo, i) {
 		vec = be_msix_vec_get(adapter, eqo);
-		irq_set_affinity_hint(vec, NULL);
+		irq_update_affinity_hint(vec, NULL);
 		free_irq(vec, eqo);
 	}
 

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] enic: Use irq_update_affinity_hint()
  2021-09-03 15:24 ` [PATCH v6 07/14] enic: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Christian Benvenuti, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     cb39ca92eb74d00b5b2e1debdba1f33e6e4c8ebd
Gitweb:        https://git.kernel.org/tip/cb39ca92eb74d00b5b2e1debdba1f33e6e4c8ebd
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:23 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:39 +01:00

enic: Use irq_update_affinity_hint()

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Christian Benvenuti <benve@cisco.com>
Link: https://lore.kernel.org/r/20210903152430.244937-8-nitesh@redhat.com

---
 drivers/net/ethernet/cisco/enic/enic_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index aacf141..2faba07 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -150,10 +150,10 @@ static void enic_set_affinity_hint(struct enic *enic)
 		    !cpumask_available(enic->msix[i].affinity_mask) ||
 		    cpumask_empty(enic->msix[i].affinity_mask))
 			continue;
-		err = irq_set_affinity_hint(enic->msix_entry[i].vector,
-					    enic->msix[i].affinity_mask);
+		err = irq_update_affinity_hint(enic->msix_entry[i].vector,
+					       enic->msix[i].affinity_mask);
 		if (err)
-			netdev_warn(enic->netdev, "irq_set_affinity_hint failed, err %d\n",
+			netdev_warn(enic->netdev, "irq_update_affinity_hint failed, err %d\n",
 				    err);
 	}
 
@@ -173,7 +173,7 @@ static void enic_unset_affinity_hint(struct enic *enic)
 	int i;
 
 	for (i = 0; i < enic->intr_count; i++)
-		irq_set_affinity_hint(enic->msix_entry[i].vector, NULL);
+		irq_update_affinity_hint(enic->msix_entry[i].vector, NULL);
 }
 
 static int enic_udp_tunnel_set_port(struct net_device *netdev,

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] RDMA/irdma: Use irq_update_affinity_hint()
  2021-09-03 15:24 ` [PATCH v6 06/14] RDMA/irdma: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Tatyana Nikolova, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     fb5bd854710e410e5544f8ba348a5be6541e4939
Gitweb:        https://git.kernel.org/tip/fb5bd854710e410e5544f8ba348a5be6541e4939
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:22 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:38 +01:00

RDMA/irdma: Use irq_update_affinity_hint()

The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
Link: https://lore.kernel.org/r/20210903152430.244937-7-nitesh@redhat.com

---
 drivers/infiniband/hw/irdma/hw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
index 4108dca..367f121 100644
--- a/drivers/infiniband/hw/irdma/hw.c
+++ b/drivers/infiniband/hw/irdma/hw.c
@@ -545,7 +545,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
 	struct irdma_sc_dev *dev = &rf->sc_dev;
 
 	dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx);
-	irq_set_affinity_hint(msix_vec->irq, NULL);
+	irq_update_affinity_hint(msix_vec->irq, NULL);
 	free_irq(msix_vec->irq, dev_id);
 }
 
@@ -1095,7 +1095,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq,
 	}
 	cpumask_clear(&msix_vec->mask);
 	cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask);
-	irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask);
+	irq_update_affinity_hint(msix_vec->irq, &msix_vec->mask);
 	if (status) {
 		ibdev_dbg(&rf->iwdev->ibdev, "ERR: ceq irq config fail\n");
 		return IRDMA_ERR_CFG;

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] scsi: mpt3sas: Use irq_set_affinity_and_hint()
  2021-09-03 15:24 ` [PATCH v6 05/14] scsi: mpt3sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Sreekanth Reddy, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     fdb8ed13a77270c8e6e05b3ff9f4cb2f57e16d6a
Gitweb:        https://git.kernel.org/tip/fdb8ed13a77270c8e6e05b3ff9f4cb2f57e16d6a
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:21 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:38 +01:00

scsi: mpt3sas: Use irq_set_affinity_and_hint()

The driver uses irq_set_affinity_hint() specifically for the high IOPS
queue interrupts for two purposes:

 - To set the affinity_hint which is consumed by the userspace for
   distributing the interrupts

 - To apply an affinity that it provides

The driver enforces its own affinity to bind the high IOPS queue interrupts
to the local NUMA node. However, irq_set_affinity_hint() applying the
provided cpumask as an affinity (if not NULL) for the interrupt is an
undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Link: https://lore.kernel.org/r/20210903152430.244937-6-nitesh@redhat.com

---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 81dab9b..511726f 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -3086,6 +3086,7 @@ _base_check_enable_msix(struct MPT3SAS_ADAPTER *ioc)
 void
 mpt3sas_base_free_irq(struct MPT3SAS_ADAPTER *ioc)
 {
+	unsigned int irq;
 	struct adapter_reply_queue *reply_q, *next;
 
 	if (list_empty(&ioc->reply_queue_list))
@@ -3098,9 +3099,10 @@ mpt3sas_base_free_irq(struct MPT3SAS_ADAPTER *ioc)
 			continue;
 		}
 
-		if (ioc->smp_affinity_enable)
-			irq_set_affinity_hint(pci_irq_vector(ioc->pdev,
-			    reply_q->msix_index), NULL);
+		if (ioc->smp_affinity_enable) {
+			irq = pci_irq_vector(ioc->pdev, reply_q->msix_index);
+			irq_update_affinity_hint(irq, NULL);
+		}
 		free_irq(pci_irq_vector(ioc->pdev, reply_q->msix_index),
 			 reply_q);
 		kfree(reply_q);
@@ -3167,18 +3169,15 @@ out:
  * @ioc: per adapter object
  *
  * The enduser would need to set the affinity via /proc/irq/#/smp_affinity
- *
- * It would nice if we could call irq_set_affinity, however it is not
- * an exported symbol
  */
 static void
 _base_assign_reply_queues(struct MPT3SAS_ADAPTER *ioc)
 {
-	unsigned int cpu, nr_cpus, nr_msix, index = 0;
+	unsigned int cpu, nr_cpus, nr_msix, index = 0, irq;
 	struct adapter_reply_queue *reply_q;
-	int local_numa_node;
 	int iopoll_q_count = ioc->reply_queue_count -
 	    ioc->iopoll_q_start_index;
+	const struct cpumask *mask;
 
 	if (!_base_is_controller_msix_enabled(ioc))
 		return;
@@ -3201,11 +3200,11 @@ _base_assign_reply_queues(struct MPT3SAS_ADAPTER *ioc)
 		 * corresponding to high iops queues.
 		 */
 		if (ioc->high_iops_queues) {
-			local_numa_node = dev_to_node(&ioc->pdev->dev);
+			mask = cpumask_of_node(dev_to_node(&ioc->pdev->dev));
 			for (index = 0; index < ioc->high_iops_queues;
 			    index++) {
-				irq_set_affinity_hint(pci_irq_vector(ioc->pdev,
-				    index), cpumask_of_node(local_numa_node));
+				irq = pci_irq_vector(ioc->pdev, index);
+				irq_set_affinity_and_hint(irq, mask);
 			}
 		}
 

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] scsi: megaraid_sas: Use irq_set_affinity_and_hint()
  2021-09-03 15:24 ` [PATCH v6 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Sumit Saxena, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     8049da6f3943d0ac51931b8064b2e4769a69a967
Gitweb:        https://git.kernel.org/tip/8049da6f3943d0ac51931b8064b2e4769a69a967
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:20 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:38 +01:00

scsi: megaraid_sas: Use irq_set_affinity_and_hint()

The driver uses irq_set_affinity_hint() specifically for the high IOPS
queue interrupts for two purposes:

 - To set the affinity_hint which is consumed by the userspace for
   distributing the interrupts

 - To apply an affinity that it provides

The driver enforces its own affinity to bind the high IOPS queue interrupts
to the local NUMA node. However, irq_set_affinity_hint() applying the
provided cpumask as an affinity for the interrupt is an undocumented side
effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Change the megasas_set_high_iops_queue_affinity_hint function name to
megasas_set_high_iops_queue_affinity_and_hint to clearly indicate that the
function is setting both affinity and affinity_hint.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Link: https://lore.kernel.org/r/20210903152430.244937-5-nitesh@redhat.com

---
 drivers/scsi/megaraid/megaraid_sas_base.c | 27 ++++++++++++----------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index aeb95f4..82e1e24 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5720,7 +5720,7 @@ megasas_setup_irqs_msix(struct megasas_instance *instance, u8 is_probe)
 				"Failed to register IRQ for vector %d.\n", i);
 			for (j = 0; j < i; j++) {
 				if (j < instance->low_latency_index_start)
-					irq_set_affinity_hint(
+					irq_update_affinity_hint(
 						pci_irq_vector(pdev, j), NULL);
 				free_irq(pci_irq_vector(pdev, j),
 					 &instance->irq_context[j]);
@@ -5763,7 +5763,7 @@ megasas_destroy_irqs(struct megasas_instance *instance) {
 	if (instance->msix_vectors)
 		for (i = 0; i < instance->msix_vectors; i++) {
 			if (i < instance->low_latency_index_start)
-				irq_set_affinity_hint(
+				irq_update_affinity_hint(
 				    pci_irq_vector(instance->pdev, i), NULL);
 			free_irq(pci_irq_vector(instance->pdev, i),
 				 &instance->irq_context[i]);
@@ -5894,22 +5894,25 @@ int megasas_get_device_list(struct megasas_instance *instance)
 }
 
 /**
- * megasas_set_high_iops_queue_affinity_hint -	Set affinity hint for high IOPS queues
- * @instance:					Adapter soft state
- * return:					void
+ * megasas_set_high_iops_queue_affinity_and_hint -	Set affinity and hint
+ *							for high IOPS queues
+ * @instance:						Adapter soft state
+ * return:						void
  */
 static inline void
-megasas_set_high_iops_queue_affinity_hint(struct megasas_instance *instance)
+megasas_set_high_iops_queue_affinity_and_hint(struct megasas_instance *instance)
 {
 	int i;
-	int local_numa_node;
+	unsigned int irq;
+	const struct cpumask *mask;
 
 	if (instance->perf_mode == MR_BALANCED_PERF_MODE) {
-		local_numa_node = dev_to_node(&instance->pdev->dev);
+		mask = cpumask_of_node(dev_to_node(&instance->pdev->dev));
 
-		for (i = 0; i < instance->low_latency_index_start; i++)
-			irq_set_affinity_hint(pci_irq_vector(instance->pdev, i),
-				cpumask_of_node(local_numa_node));
+		for (i = 0; i < instance->low_latency_index_start; i++) {
+			irq = pci_irq_vector(instance->pdev, i);
+			irq_set_affinity_and_hint(irq, mask);
+		}
 	}
 }
 
@@ -5998,7 +6001,7 @@ megasas_alloc_irq_vectors(struct megasas_instance *instance)
 		instance->msix_vectors = 0;
 
 	if (instance->smp_affinity_enable)
-		megasas_set_high_iops_queue_affinity_hint(instance);
+		megasas_set_high_iops_queue_affinity_and_hint(instance);
 }
 
 /**

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] iavf: Use irq_update_affinity_hint()
  2021-09-03 15:24 ` [PATCH v6 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Jesse Brandeburg, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     0f9744f4ed539f2e847d7ed41993b243e3ba5cff
Gitweb:        https://git.kernel.org/tip/0f9744f4ed539f2e847d7ed41993b243e3ba5cff
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:18 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:38 +01:00

iavf: Use irq_update_affinity_hint()

The driver uses irq_set_affinity_hint() for two purposes:

- To set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- To apply an affinity that it provides for the iavf interrupts

The latter is done to ensure that all the interrupts are evenly spread
across all available CPUs. However, since commit a0c9259dc4e1 ("irq/matrix:
Spread interrupts on allocation") the spreading of interrupts is
dynamically performed at the time of allocation. Hence, there is no need
for the drivers to enforce their own affinity for the spreading of
interrupts.

Also, irq_set_affinity_hint() applying the provided cpumask as an affinity
for the interrupt is an undocumented side effect. To remove this side
effect irq_set_affinity_hint() has been marked as deprecated and new
interfaces have been introduced. Hence, replace the irq_set_affinity_hint()
with the new interface irq_update_affinity_hint() that only sets the
pointer for the affinity_hint.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Link: https://lore.kernel.org/r/20210903152430.244937-3-nitesh@redhat.com

---
 drivers/net/ethernet/intel/iavf/iavf_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 14934a7..1980e62 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -492,10 +492,10 @@ iavf_request_traffic_irqs(struct iavf_adapter *adapter, char *basename)
 		irq_set_affinity_notifier(irq_num, &q_vector->affinity_notify);
 		/* Spread the IRQ affinity hints across online CPUs. Note that
 		 * get_cpu_mask returns a mask with a permanent lifetime so
-		 * it's safe to use as a hint for irq_set_affinity_hint.
+		 * it's safe to use as a hint for irq_update_affinity_hint.
 		 */
 		cpu = cpumask_local_spread(q_vector->v_idx, -1);
-		irq_set_affinity_hint(irq_num, get_cpu_mask(cpu));
+		irq_update_affinity_hint(irq_num, get_cpu_mask(cpu));
 	}
 
 	return 0;
@@ -505,7 +505,7 @@ free_queue_irqs:
 		vector--;
 		irq_num = adapter->msix_entries[vector + NONQ_VECS].vector;
 		irq_set_affinity_notifier(irq_num, NULL);
-		irq_set_affinity_hint(irq_num, NULL);
+		irq_update_affinity_hint(irq_num, NULL);
 		free_irq(irq_num, &adapter->q_vectors[vector]);
 	}
 	return err;
@@ -557,7 +557,7 @@ static void iavf_free_traffic_irqs(struct iavf_adapter *adapter)
 	for (vector = 0; vector < q_vectors; vector++) {
 		irq_num = adapter->msix_entries[vector + NONQ_VECS].vector;
 		irq_set_affinity_notifier(irq_num, NULL);
-		irq_set_affinity_hint(irq_num, NULL);
+		irq_update_affinity_hint(irq_num, NULL);
 		free_irq(irq_num, &adapter->q_vectors[vector]);
 	}
 }

^ permalink raw reply	[flat|nested] 34+ messages in thread

* [tip: irq/core] i40e: Use irq_update_affinity_hint()
  2021-09-03 15:24 ` [PATCH v6 03/14] i40e: Use irq_update_affinity_hint Nitesh Narayan Lal
@ 2021-12-10 19:54   ` tip-bot2 for Nitesh Narayan Lal
  0 siblings, 0 replies; 34+ messages in thread
From: tip-bot2 for Nitesh Narayan Lal @ 2021-12-10 19:54 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nitesh Narayan Lal, Thomas Gleixner, Jesse Brandeburg, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     d34c54d1739c2cdf2e4437b74e6da269147f4987
Gitweb:        https://git.kernel.org/tip/d34c54d1739c2cdf2e4437b74e6da269147f4987
Author:        Nitesh Narayan Lal <nitesh@redhat.com>
AuthorDate:    Fri, 03 Sep 2021 11:24:19 -04:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 10 Dec 2021 20:47:38 +01:00

i40e: Use irq_update_affinity_hint()

The driver uses irq_set_affinity_hint() for two purposes:

 - To set the affinity_hint which is consumed by the userspace for
   distributing the interrupts

 - To apply an affinity that it provides for the i40e interrupts

The latter is done to ensure that all the interrupts are evenly spread
across all available CPUs. However, since commit a0c9259dc4e1 ("irq/matrix:
Spread interrupts on allocation") the spreading of interrupts is
dynamically performed at the time of allocation. Hence, there is no need
for the drivers to enforce their own affinity for the spreading of
interrupts.

Also, irq_set_affinity_hint() applying the provided cpumask as an affinity
for the interrupt is an undocumented side effect. To remove this side
effect irq_set_affinity_hint() has been marked as deprecated and new
interfaces have been introduced. Hence, replace the irq_set_affinity_hint()
with the new interface irq_update_affinity_hint() that only sets the
pointer for the affinity_hint.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Link: https://lore.kernel.org/r/20210903152430.244937-4-nitesh@redhat.com

---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index e118cf9..ef3375e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -3891,10 +3891,10 @@ static int i40e_vsi_request_irq_msix(struct i40e_vsi *vsi, char *basename)
 		 *
 		 * get_cpu_mask returns a static constant mask with
 		 * a permanent lifetime so it's ok to pass to
-		 * irq_set_affinity_hint without making a copy.
+		 * irq_update_affinity_hint without making a copy.
 		 */
 		cpu = cpumask_local_spread(q_vector->v_idx, -1);
-		irq_set_affinity_hint(irq_num, get_cpu_mask(cpu));
+		irq_update_affinity_hint(irq_num, get_cpu_mask(cpu));
 	}
 
 	vsi->irqs_ready = true;
@@ -3905,7 +3905,7 @@ free_queue_irqs:
 		vector--;
 		irq_num = pf->msix_entries[base + vector].vector;
 		irq_set_affinity_notifier(irq_num, NULL);
-		irq_set_affinity_hint(irq_num, NULL);
+		irq_update_affinity_hint(irq_num, NULL);
 		free_irq(irq_num, &vsi->q_vectors[vector]);
 	}
 	return err;
@@ -4726,7 +4726,7 @@ static void i40e_vsi_free_irq(struct i40e_vsi *vsi)
 			/* clear the affinity notifier in the IRQ descriptor */
 			irq_set_affinity_notifier(irq_num, NULL);
 			/* remove our suggested affinity mask for this IRQ */
-			irq_set_affinity_hint(irq_num, NULL);
+			irq_update_affinity_hint(irq_num, NULL);
 			synchronize_irq(irq_num);
 			free_irq(irq_num, vsi->q_vectors[i]);
 

^ permalink raw reply	[flat|nested] 34+ messages in thread

end of thread, other threads:[~2021-12-10 19:54 UTC | newest]

Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 15:24 [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] iavf: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 03/14] i40e: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] i40e: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] scsi: megaraid_sas: Use irq_set_affinity_and_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 05/14] scsi: mpt3sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] scsi: mpt3sas: Use irq_set_affinity_and_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 06/14] RDMA/irdma: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] RDMA/irdma: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 07/14] enic: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] enic: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 08/14] be2net: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] be2net: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 09/14] ixgbe: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] ixgbe: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 10/14] mailbox: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] mailbox: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] scsi: lpfc: Use irq_set_affinity() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] hinic: Use irq_set_affinity_and_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 13/14] net/mlx5: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] net/mlx5: Use irq_set_affinity_and_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-03 15:24 ` [PATCH v6 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-12-10 19:54   ` [tip: irq/core] net/mlx4: Use irq_update_affinity_hint() tip-bot2 for Nitesh Narayan Lal
2021-09-13 14:34 ` [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Lal
2021-11-24 19:30   ` Thomas Gleixner
2021-11-24 22:16     ` Nitesh Lal
2021-12-10 13:51       ` Nitesh Lal
2021-12-10 18:44         ` Thomas Gleixner
2021-12-10 18:54           ` Nitesh Lal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).