LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking
Date: Fri, 17 Sep 2021 14:54:11 +0100	[thread overview]
Message-ID: <87ee9nb94s.wl-maz@kernel.org> (raw)
In-Reply-To: <64fd8ea9-1d78-5e3a-8097-6206f03e69de@socionext.com>

On Thu, 16 Sep 2021 12:30:52 +0100,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote:
> 
> Gentle ping, are there any comments about this series?
> 
> Thank you,
> 
> On 2021/08/30 11:22, Kunihiko Hayashi wrote:
> > This series includes some fixes to INTx masking/unmasking for UniPhier PCIe
> > host controller driver.
> > 
> > - Remove unnecessary bit clears to INTX mask field
> > - Remove unnecessary irq_ack() function because write access to status field
> >    doesn't work
> > - Add lock into callback functions to avoid race condition
> > 
> > Kunihiko Hayashi (2):
> >    PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack
> >      function
> >    PCI: uniphier: Serialize INTx masking/unmasking
> > 
> >   drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++----------------
> >   1 file changed, 10 insertions(+), 16 deletions(-)
> > 

Patches look OK, although I would personally squash them into a single
one (INTx masking never really worked before that). FWIW:

Acked-by: Marc Zyngier <maz@kernel.org>

	N,

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2021-09-17 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  2:22 Kunihiko Hayashi
2021-08-30  2:22 ` [PATCH v2 1/2] PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack function Kunihiko Hayashi
2021-08-30 15:59   ` Pali Rohár
2021-08-30  2:22 ` [PATCH v2 2/2] PCI: uniphier: Serialize INTx masking/unmasking Kunihiko Hayashi
2021-09-16 11:30 ` [PATCH v2 0/2] PCI: uniphier: Fix " Kunihiko Hayashi
2021-09-17 13:54   ` Marc Zyngier [this message]
2021-09-17 23:48     ` Kunihiko Hayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee9nb94s.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=pali@kernel.org \
    --cc=robh@kernel.org \
    --subject='Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).