From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56687C433F5 for ; Fri, 17 Sep 2021 13:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EB9A611C8 for ; Fri, 17 Sep 2021 13:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241780AbhIQNzm (ORCPT ); Fri, 17 Sep 2021 09:55:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:36744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241589AbhIQNzk (ORCPT ); Fri, 17 Sep 2021 09:55:40 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E310C611C3; Fri, 17 Sep 2021 13:54:18 +0000 (UTC) Received: from [198.52.44.129] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mREJl-00BNoO-0m; Fri, 17 Sep 2021 14:54:17 +0100 Date: Fri, 17 Sep 2021 14:54:11 +0100 Message-ID: <87ee9nb94s.wl-maz@kernel.org> From: Marc Zyngier To: Kunihiko Hayashi Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Bjorn Helgaas , Pali =?UTF-8?B?Um9ow6Fy?= , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking In-Reply-To: <64fd8ea9-1d78-5e3a-8097-6206f03e69de@socionext.com> References: <1630290158-31264-1-git-send-email-hayashi.kunihiko@socionext.com> <64fd8ea9-1d78-5e3a-8097-6206f03e69de@socionext.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 198.52.44.129 X-SA-Exim-Rcpt-To: hayashi.kunihiko@socionext.com, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, pali@kernel.org, mhiramat@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Sep 2021 12:30:52 +0100, Kunihiko Hayashi wrote: > > Gentle ping, are there any comments about this series? > > Thank you, > > On 2021/08/30 11:22, Kunihiko Hayashi wrote: > > This series includes some fixes to INTx masking/unmasking for UniPhier PCIe > > host controller driver. > > > > - Remove unnecessary bit clears to INTX mask field > > - Remove unnecessary irq_ack() function because write access to status field > > doesn't work > > - Add lock into callback functions to avoid race condition > > > > Kunihiko Hayashi (2): > > PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack > > function > > PCI: uniphier: Serialize INTx masking/unmasking > > > > drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- > > 1 file changed, 10 insertions(+), 16 deletions(-) > > Patches look OK, although I would personally squash them into a single one (INTx masking never really worked before that). FWIW: Acked-by: Marc Zyngier N, -- Without deviation from the norm, progress is not possible.