LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ASoC: simple-card-utils: Avoid over-allocating DLCs
@ 2021-08-05  5:07 Samuel Holland
  2021-08-05  5:14 ` Kuninori Morimoto
  2021-08-06  0:47 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Samuel Holland @ 2021-08-05  5:07 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown
  Cc: Kuninori Morimoto, alsa-devel, linux-kernel, Samuel Holland

The allocation of the DAI link components (DLCs) passed the wrong
pointer to sizeof. Since simple_dai_props is much larger than
snd_soc_dai_link_component, there was no out of bounds access, only
wasted memory.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---
 sound/soc/generic/simple-card-utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index 677f7da93b4b..10c63b73900c 100644
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -640,8 +640,8 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
 			cnf_num += li->num[i].codecs;
 	}
 
-	dais = devm_kcalloc(dev, dai_num, sizeof(*dais),      GFP_KERNEL);
-	dlcs = devm_kcalloc(dev, dlc_num, sizeof(*dai_props), GFP_KERNEL);
+	dais = devm_kcalloc(dev, dai_num, sizeof(*dais), GFP_KERNEL);
+	dlcs = devm_kcalloc(dev, dlc_num, sizeof(*dlcs), GFP_KERNEL);
 	if (!dais || !dlcs)
 		return -ENOMEM;
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-06  0:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05  5:07 [PATCH] ASoC: simple-card-utils: Avoid over-allocating DLCs Samuel Holland
2021-08-05  5:14 ` Kuninori Morimoto
2021-08-05 12:32   ` Mark Brown
2021-08-06  0:47 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).