LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: paul@pwsan.com
Cc: tony@atomide.com
Cc: r-woodruff2@ti.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] omap2: fix DPLL_FREQSEL calculation
Date: Thu, 20 Jan 2011 11:42:24 +0100	[thread overview]
Message-ID: <87ei8726wf.fsf@vostro.fn.ogness.net> (raw)

Hi,

This patch fixes the calculation of the internal frequency. The value
of "n" is one less than the actual divider. 0 is a valid value.

An example where the internal frequency is calculated correctly can be
found here: clkt_dpll.c:_dpll_test_fint()

This patch is against linux-next-20110120.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
 arch/arm/mach-omap2/dpll3xxx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/arm/mach-omap2/dpll3xxx.c	2011-01-20 11:20:41.706860086 +0100
+++ b/arch/arm/mach-omap2/dpll3xxx.c	2011-01-20 11:21:27.966860086 +0100
@@ -93,7 +93,7 @@ static u16 _omap3_dpll_compute_freqsel(s
 	unsigned long fint;
 	u16 f = 0;
 
-	fint = clk->dpll_data->clk_ref->rate / n;
+	fint = clk->dpll_data->clk_ref->rate / (n + 1);
 
 	pr_debug("clock: fint is %lu\n", fint);
 

             reply	other threads:[~2011-01-20 10:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 10:42 John Ogness [this message]
2011-01-20 11:16 ` Felipe Balbi
2011-01-20 14:29   ` [PATCH v2] " John Ogness
2011-01-21  3:15     ` Felipe Balbi
2011-01-21  8:33       ` [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL John Ogness
2011-02-08  3:09         ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ei8726wf.fsf@vostro.fn.ogness.net \
    --to=john.ogness@linutronix.de \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    --subject='Re: [PATCH] omap2: fix DPLL_FREQSEL calculation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).