From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5ADDC4338F for ; Wed, 11 Aug 2021 12:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D04360FC3 for ; Wed, 11 Aug 2021 12:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237446AbhHKMJL (ORCPT ); Wed, 11 Aug 2021 08:09:11 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:49910 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236679AbhHKMJE (ORCPT ); Wed, 11 Aug 2021 08:09:04 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1628683718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cCPYmftPfGiygaluib21F8+dmifVxGxWYVTKWjQffJE=; b=0MLwhpEjGT+kB+aY1hx2dkGme4FZ8aWIh4nQPVyMhWmCpTxlGDJ9oma/iDNXvZtZkofrib UIDbFXmIg73MeJjr1YObjHi5d5ZLYppBEkH9aO2hqz/vVQy3KIeAthzlZYWLykQ6Y/F/e3 lRIofXSBIYnKKeeZdjZXKMpQaR/ZXh35fX5c0h3DGh8E3HgSlUJg8YY/fdDQbT+0ngq9d1 ayxJTW2RDM4ptP2SMSlsCu00XBa6X33MUnINFhePNEavDY246s8rr1m10L+RT8tfIYxtm0 uEKpIQ1I3w+KJxgbpPsSxUF8pOOF1emFNhhjtJ+9pr+YWUtMxL5rEzTr1jO9yQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1628683718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cCPYmftPfGiygaluib21F8+dmifVxGxWYVTKWjQffJE=; b=ivSogjaZ4TJIiOeQj5iu4L3Rp8xGmuzTiApoq3dCjFocOi4UqCBZHaThKPBbQxbr1bOk3c nJ8ZqNTWiYP0hPBQ== To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ming Lei , Hannes Reinecke Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG In-Reply-To: References: <20210617073136.315723-1-lee.jones@linaro.org> <8735rhs7n6.ffs@tglx> Date: Wed, 11 Aug 2021 14:08:38 +0200 Message-ID: <87fsvgp4jd.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 11 2021 at 08:57, Lee Jones wrote: > On Tue, 10 Aug 2021, Thomas Gleixner wrote: >> > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d) >> > * If this happens then there was a missed IRQ fixup at some >> > * point. Warn about it and enforce fixup. >> > */ >> > - pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", >> >> This one is clearly a warning as this should not happen. See the >> comments around that. >> >> > + pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", >> > cpumask_pr_args(m), d->irq, cpu); >> > return true; >> > } >> > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void) >> > raw_spin_unlock(&desc->lock); >> > >> > if (affinity_broken) { >> > - pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n", >> > + pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n", >> > irq, smp_processor_id()); >> >> Maybe, but distro people might have opinions on that. > > The trouble is, even if these are real warnings, they have an affect > on performance on real products. To the point where so much logging > builds up during pre-release testing, that it sets off the watchdog(s) > on some high profile consumer devices. I'm fine with making the second one debug, but the first one really should not trigger at all. Thanks, tglx