LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Carlos Bilbao <bilbao@vt.edu>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	jianyong.wu@arm.com, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2] include: linux: Reorganize timekeeping and ktime headers
Date: Wed, 21 Jul 2021 23:09:50 +0200	[thread overview]
Message-ID: <87fsw7pe5d.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <4663325.31r3eYUQgx@iron-maiden>

Carlos,

On Mon, Jul 19 2021 at 11:19, Carlos Bilbao wrote:
> Reorganize and separate the headers by making ktime.h take care of the 
> ktime_get() family of functions, and reserve timekeeping.h for the actual 
> timekeeping. This also helps to avoid implicit function errors and strengthens
> the header dependencies, since timekeeping.h was using ktime_to_ns(), a static 
> function defined in a header it does no include, ktime.h.

I have no objections against this change per se, but I'm missing the
actual problem it is trying to solve. What's the fail it fixes or is it
just a general consolidation? The above is blury in that regard.

> This patch also includes the header timekeeping.h wherever it is
> necessary for a successful compilation after the header code
> reorganization.

Please do:

  git grep 'This patch' Documentation/process/

and follow the instructions there.

Aside of that I assume that you only covered x86 in build testing which
is not cutting it as this is generic infrastructure affecting _all_
architectures.

Thanks,

        tglx

  reply	other threads:[~2021-07-21 21:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5729424.lOV4Wx5bFT@iron-maiden>
     [not found] ` <2591466.mvXUDI8C0e@iron-maiden>
     [not found]   ` <5481808.DvuYhMxLoT@iron-maiden>
2021-07-15 16:12     ` [PATCH] " Carlos Bilbao
2021-07-15 18:57       ` Arnd Bergmann
2021-07-19 15:16         ` Carlos Bilbao
2021-07-19 15:19           ` [PATCH v2] " Carlos Bilbao
2021-07-21 21:09             ` Thomas Gleixner [this message]
2021-07-22 11:54               ` Carlos Bilbao
2021-07-22 15:31                 ` [PATCH v3] " Carlos Bilbao
2021-07-22 18:19                   ` kernel test robot
2021-07-22 18:41                   ` kernel test robot
2021-07-22 19:19                   ` kernel test robot
2021-07-31 16:29                     ` [PATCH v4] " Carlos Bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsw7pe5d.ffs@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=bilbao@vt.edu \
    --cc=geert@linux-m68k.org \
    --cc=jianyong.wu@arm.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH v2] include: linux: Reorganize timekeeping and ktime headers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).