LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] powerpc/syscalls: Remove __NR__exit
@ 2021-08-23  6:45 Christophe Leroy
  2021-08-23  8:33 ` Andreas Schwab
  2021-08-27 13:15 ` Michael Ellerman
  0 siblings, 2 replies; 5+ messages in thread
From: Christophe Leroy @ 2021-08-23  6:45 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: linux-kernel, linuxppc-dev

__NR_exit is nowhere used. On most architectures it was removed by
commit 135ab6ec8fda ("[PATCH] remove remaining errno and
__KERNEL_SYSCALLS__ references") but not on powerpc.

powerpc removed __KERNEL_SYSCALLS__ in commit 3db03b4afb3e ("[PATCH]
rename the provided execve functions to kernel_execve"), but __NR_exit
was left over.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
 arch/powerpc/include/asm/unistd.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/include/asm/unistd.h b/arch/powerpc/include/asm/unistd.h
index b541c690a31c..5eb462af6766 100644
--- a/arch/powerpc/include/asm/unistd.h
+++ b/arch/powerpc/include/asm/unistd.h
@@ -9,8 +9,6 @@
 
 #define NR_syscalls	__NR_syscalls
 
-#define __NR__exit __NR_exit
-
 #ifndef __ASSEMBLY__
 
 #include <linux/types.h>
-- 
2.25.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/syscalls: Remove __NR__exit
  2021-08-23  6:45 [PATCH] powerpc/syscalls: Remove __NR__exit Christophe Leroy
@ 2021-08-23  8:33 ` Andreas Schwab
  2021-08-23  8:36   ` Christophe Leroy
  2021-08-27 13:15 ` Michael Ellerman
  1 sibling, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2021-08-23  8:33 UTC (permalink / raw)
  To: Christophe Leroy
  Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
	linux-kernel, linuxppc-dev

On Aug 23 2021, Christophe Leroy wrote:

> __NR_exit is nowhere used. On most architectures it was removed by

ITYM __NR__exit, which is what you are removing.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/syscalls: Remove __NR__exit
  2021-08-23  8:33 ` Andreas Schwab
@ 2021-08-23  8:36   ` Christophe Leroy
  2021-08-23  9:27     ` Michael Ellerman
  0 siblings, 1 reply; 5+ messages in thread
From: Christophe Leroy @ 2021-08-23  8:36 UTC (permalink / raw)
  To: Andreas Schwab
  Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
	linux-kernel, linuxppc-dev



Le 23/08/2021 à 10:33, Andreas Schwab a écrit :
> On Aug 23 2021, Christophe Leroy wrote:
> 
>> __NR_exit is nowhere used. On most architectures it was removed by
> 
> ITYM __NR__exit, which is what you are removing.
> 

Indeed.

Michael, can you fix when applying or do you prefer a new patch ?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/syscalls: Remove __NR__exit
  2021-08-23  8:36   ` Christophe Leroy
@ 2021-08-23  9:27     ` Michael Ellerman
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2021-08-23  9:27 UTC (permalink / raw)
  To: Christophe Leroy, Andreas Schwab
  Cc: Benjamin Herrenschmidt, Paul Mackerras, linux-kernel, linuxppc-dev

Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 23/08/2021 à 10:33, Andreas Schwab a écrit :
>> On Aug 23 2021, Christophe Leroy wrote:
>> 
>>> __NR_exit is nowhere used. On most architectures it was removed by
>> 
>> ITYM __NR__exit, which is what you are removing.
>> 
>
> Indeed.
>
> Michael, can you fix when applying or do you prefer a new patch ?

I can fix.

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/syscalls: Remove __NR__exit
  2021-08-23  6:45 [PATCH] powerpc/syscalls: Remove __NR__exit Christophe Leroy
  2021-08-23  8:33 ` Andreas Schwab
@ 2021-08-27 13:15 ` Michael Ellerman
  1 sibling, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2021-08-27 13:15 UTC (permalink / raw)
  To: Michael Ellerman, Christophe Leroy, Paul Mackerras,
	Benjamin Herrenschmidt
  Cc: linuxppc-dev, linux-kernel

On Mon, 23 Aug 2021 06:45:20 +0000 (UTC), Christophe Leroy wrote:
> __NR_exit is nowhere used. On most architectures it was removed by
> commit 135ab6ec8fda ("[PATCH] remove remaining errno and
> __KERNEL_SYSCALLS__ references") but not on powerpc.
> 
> powerpc removed __KERNEL_SYSCALLS__ in commit 3db03b4afb3e ("[PATCH]
> rename the provided execve functions to kernel_execve"), but __NR_exit
> was left over.
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/syscalls: Remove __NR__exit
      https://git.kernel.org/powerpc/c/a00ea5b6f2bbef8b004b0b7228c61680a50c7c3f

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-27 13:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23  6:45 [PATCH] powerpc/syscalls: Remove __NR__exit Christophe Leroy
2021-08-23  8:33 ` Andreas Schwab
2021-08-23  8:36   ` Christophe Leroy
2021-08-23  9:27     ` Michael Ellerman
2021-08-27 13:15 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).