LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
@ 2021-07-02 22:31 Justin M. Forbes
  2021-07-09 17:32 ` Justin Forbes
  2021-09-02 16:39 ` Kalle Valo
  0 siblings, 2 replies; 9+ messages in thread
From: Justin M. Forbes @ 2021-07-02 22:31 UTC (permalink / raw)
  To: Luca Coelho, Kalle Valo, David S. Miller, Jakub Kicinski,
	Matti Gottlieb, ybaruch, Johannes Berg, Ihab Zhaika,
	Emmanuel Grumbach, linux-wireless, netdev, linux-kernel
  Cc: jforbes, jmforbes

The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
This works fine with the existing driver once it knows to claim it.
Simple patch to add the device.

Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
---
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 16baee3d52ae..63f5598ebe3f 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -558,6 +558,7 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
 	IWL_DEV_INFO(0xA0F0, 0x1652, killer1650i_2ax_cfg_qu_b0_hr_b0, NULL),
 	IWL_DEV_INFO(0xA0F0, 0x2074, iwl_ax201_cfg_qu_hr, NULL),
 	IWL_DEV_INFO(0xA0F0, 0x4070, iwl_ax201_cfg_qu_hr, NULL),
+	IWL_DEV_INFO(0xA0F0, 0x6074, iwl_ax201_cfg_qu_hr, NULL),
 	IWL_DEV_INFO(0x02F0, 0x0070, iwl_ax201_cfg_quz_hr, NULL),
 	IWL_DEV_INFO(0x02F0, 0x0074, iwl_ax201_cfg_quz_hr, NULL),
 	IWL_DEV_INFO(0x02F0, 0x6074, iwl_ax201_cfg_quz_hr, NULL),
-- 
2.31.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
  2021-07-02 22:31 [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha Justin M. Forbes
@ 2021-07-09 17:32 ` Justin Forbes
  2021-08-08 23:09   ` Jaehoon Chung
  2021-09-02 16:39 ` Kalle Valo
  1 sibling, 1 reply; 9+ messages in thread
From: Justin Forbes @ 2021-07-09 17:32 UTC (permalink / raw)
  To: Luca Coelho, Kalle Valo, David S. Miller, Jakub Kicinski,
	Matti Gottlieb, ybaruch, Johannes Berg, Ihab Zhaika,
	Emmanuel Grumbach, linux-wireless,
	open list:BPF (Safe dynamic programs and tools),
	LKML

On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
<jforbes@fedoraproject.org> wrote:
>
> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> This works fine with the existing driver once it knows to claim it.
> Simple patch to add the device.
>
> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> ---

Just an update from the user with this hardware that I built a test kernel for:
"Still going strong w/ AX201, speed OK, on par w/ speeds on windows,
no crashes, no weird messages about the driver."

Justin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
  2021-07-09 17:32 ` Justin Forbes
@ 2021-08-08 23:09   ` Jaehoon Chung
  2021-08-12 22:26     ` Jaehoon Chung
  0 siblings, 1 reply; 9+ messages in thread
From: Jaehoon Chung @ 2021-08-08 23:09 UTC (permalink / raw)
  To: Justin Forbes, Luca Coelho, Kalle Valo, David S. Miller,
	Jakub Kicinski, Matti Gottlieb, ybaruch, Johannes Berg,
	Ihab Zhaika, Emmanuel Grumbach, linux-wireless,
	open list:BPF (Safe dynamic programs and tools),
	LKML, yj99.shin

Hi

On 7/10/21 2:32 AM, Justin Forbes wrote:
> On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
> <jforbes@fedoraproject.org> wrote:
>>
>> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
>> This works fine with the existing driver once it knows to claim it.
>> Simple patch to add the device.
>>
>> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>


Before sending patch, I have found same patch to solve the Wifi problem.
Is there any progress about this patch? 

I hope that this patch will be applied.

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung


>> ---
> 
> Just an update from the user with this hardware that I built a test kernel for:
> "Still going strong w/ AX201, speed OK, on par w/ speeds on windows,
> no crashes, no weird messages about the driver."
> 
> Justin
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
  2021-08-08 23:09   ` Jaehoon Chung
@ 2021-08-12 22:26     ` Jaehoon Chung
  2021-08-21 13:34       ` Kalle Valo
  0 siblings, 1 reply; 9+ messages in thread
From: Jaehoon Chung @ 2021-08-12 22:26 UTC (permalink / raw)
  To: Justin Forbes, Luca Coelho, Kalle Valo, David S. Miller,
	Jakub Kicinski, Matti Gottlieb, ybaruch, Johannes Berg,
	Ihab Zhaika, Emmanuel Grumbach, linux-wireless,
	open list:BPF (Safe dynamic programs and tools),
	LKML, yj99.shin

Hi

On 8/9/21 8:09 AM, Jaehoon Chung wrote:
> Hi
> 
> On 7/10/21 2:32 AM, Justin Forbes wrote:
>> On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
>> <jforbes@fedoraproject.org> wrote:
>>>
>>> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
>>> This works fine with the existing driver once it knows to claim it.
>>> Simple patch to add the device.
>>>
>>> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>

If this patch is merged, can this patch be also applied on stable tree?

Best Regards,
Jaehoon Chung

> 
> 
> Before sending patch, I have found same patch to solve the Wifi problem.
> Is there any progress about this patch? 
> 
> I hope that this patch will be applied.
> 
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
> 
> Best Regards,
> Jaehoon Chung
> 
> 
>>> ---
>>
>> Just an update from the user with this hardware that I built a test kernel for:
>> "Still going strong w/ AX201, speed OK, on par w/ speeds on windows,
>> no crashes, no weird messages about the driver."
>>
>> Justin
>>
> 
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
  2021-08-12 22:26     ` Jaehoon Chung
@ 2021-08-21 13:34       ` Kalle Valo
  2021-08-25 18:07         ` Justin Forbes
  0 siblings, 1 reply; 9+ messages in thread
From: Kalle Valo @ 2021-08-21 13:34 UTC (permalink / raw)
  To: Jaehoon Chung
  Cc: Justin Forbes, Luca Coelho, David S. Miller, Jakub Kicinski,
	Matti Gottlieb, ybaruch, Johannes Berg, Ihab Zhaika,
	Emmanuel Grumbach, linux-wireless,
	open list:BPF (Safe dynamic programs and tools),
	LKML, yj99.shin

Jaehoon Chung <jh80.chung@samsung.com> writes:

> Hi
>
> On 8/9/21 8:09 AM, Jaehoon Chung wrote:
>> Hi
>> 
>> On 7/10/21 2:32 AM, Justin Forbes wrote:
>>> On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
>>> <jforbes@fedoraproject.org> wrote:
>>>>
>>>> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
>>>> This works fine with the existing driver once it knows to claim it.
>>>> Simple patch to add the device.
>>>>
>>>> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
>
> If this patch is merged, can this patch be also applied on stable tree?

Luca, what should we do with this patch?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
  2021-08-21 13:34       ` Kalle Valo
@ 2021-08-25 18:07         ` Justin Forbes
  2021-08-31  6:36           ` Coelho, Luciano
  0 siblings, 1 reply; 9+ messages in thread
From: Justin Forbes @ 2021-08-25 18:07 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Jaehoon Chung, Luca Coelho, David S. Miller, Jakub Kicinski,
	Matti Gottlieb, ybaruch, Johannes Berg, Ihab Zhaika,
	Emmanuel Grumbach, linux-wireless,
	open list:BPF (Safe dynamic programs and tools),
	LKML, yj99.shin

On Sat, Aug 21, 2021 at 8:34 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Jaehoon Chung <jh80.chung@samsung.com> writes:
>
> > Hi
> >
> > On 8/9/21 8:09 AM, Jaehoon Chung wrote:
> >> Hi
> >>
> >> On 7/10/21 2:32 AM, Justin Forbes wrote:
> >>> On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
> >>> <jforbes@fedoraproject.org> wrote:
> >>>>
> >>>> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> >>>> This works fine with the existing driver once it knows to claim it.
> >>>> Simple patch to add the device.
> >>>>
> >>>> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> >
> > If this patch is merged, can this patch be also applied on stable tree?
>
> Luca, what should we do with this patch?
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


Is that to imply that there is an issue with the submission?  Happy to
fix any problems, but it would nice to get this in soon.  I know the
5.14 merge window was already opened when I sent it, but the 5.15 MR
is opening soon.  Hardware is definitely shipping and in users hands.

Justin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
  2021-08-25 18:07         ` Justin Forbes
@ 2021-08-31  6:36           ` Coelho, Luciano
  2021-08-31  6:49             ` Kalle Valo
  0 siblings, 1 reply; 9+ messages in thread
From: Coelho, Luciano @ 2021-08-31  6:36 UTC (permalink / raw)
  To: kvalo, jmforbes
  Cc: yj99.shin, davem, Berg, Johannes, Baruch, Yaara, ihab.zhaika,
	linux-kernel, linux-wireless, kuba, Gottlieb, Matti, Grumbach,
	Emmanuel, jh80.chung, netdev

On Wed, 2021-08-25 at 13:07 -0500, Justin Forbes wrote:
> On Sat, Aug 21, 2021 at 8:34 AM Kalle Valo <kvalo@codeaurora.org> wrote:
> > 
> > Jaehoon Chung <jh80.chung@samsung.com> writes:
> > 
> > > Hi
> > > 
> > > On 8/9/21 8:09 AM, Jaehoon Chung wrote:
> > > > Hi
> > > > 
> > > > On 7/10/21 2:32 AM, Justin Forbes wrote:
> > > > > On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
> > > > > <jforbes@fedoraproject.org> wrote:
> > > > > > 
> > > > > > The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> > > > > > This works fine with the existing driver once it knows to claim it.
> > > > > > Simple patch to add the device.
> > > > > > 
> > > > > > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> > > 
> > > If this patch is merged, can this patch be also applied on stable tree?
> > 
> > Luca, what should we do with this patch?
> > 
> > --
> > https://patchwork.kernel.org/project/linux-wireless/list/
> > 
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> 
> 
> Is that to imply that there is an issue with the submission?  Happy to
> fix any problems, but it would nice to get this in soon.  I know the
> 5.14 merge window was already opened when I sent it, but the 5.15 MR
> is opening soon.  Hardware is definitely shipping and in users hands.

Sorry for the delay here.  This fell between the cracks.

Kalle can you apply this directly to your tree? I'll assign it to you.
And, if possible, add the cc-stable tag so it gets picked up. :)

Longer reasoning: generally we detect the hardware in a more
programmatic way, by checking the type from registers (and not relying
entirely on the PCI IDs), but for some reason this type of device is
still using the legacy way of matching the exact PCI ID to a device
type.  Thus, this patch is needed, at least for now.

Thanks!

--
Cheers,
Luca.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
  2021-08-31  6:36           ` Coelho, Luciano
@ 2021-08-31  6:49             ` Kalle Valo
  0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2021-08-31  6:49 UTC (permalink / raw)
  To: Coelho, Luciano
  Cc: jmforbes, yj99.shin, davem, Berg, Johannes, Baruch, Yaara,
	ihab.zhaika, linux-kernel, linux-wireless, kuba, Gottlieb, Matti,
	Grumbach, Emmanuel, jh80.chung, netdev

"Coelho, Luciano" <luciano.coelho@intel.com> writes:

> On Wed, 2021-08-25 at 13:07 -0500, Justin Forbes wrote:
>> On Sat, Aug 21, 2021 at 8:34 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>> > 
>> > Jaehoon Chung <jh80.chung@samsung.com> writes:
>> > 
>> > > Hi
>> > > 
>> > > On 8/9/21 8:09 AM, Jaehoon Chung wrote:
>> > > > Hi
>> > > > 
>> > > > On 7/10/21 2:32 AM, Justin Forbes wrote:
>> > > > > On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
>> > > > > <jforbes@fedoraproject.org> wrote:
>> > > > > > 
>> > > > > > The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
>> > > > > > This works fine with the existing driver once it knows to claim it.
>> > > > > > Simple patch to add the device.
>> > > > > > 
>> > > > > > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
>> > > 
>> > > If this patch is merged, can this patch be also applied on stable tree?
>> > 
>> > Luca, what should we do with this patch?
>> > 
>> > --
>> > https://patchwork.kernel.org/project/linux-wireless/list/
>> > 
>> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>> 
>> 
>> Is that to imply that there is an issue with the submission?  Happy to
>> fix any problems, but it would nice to get this in soon.  I know the
>> 5.14 merge window was already opened when I sent it, but the 5.15 MR
>> is opening soon.  Hardware is definitely shipping and in users hands.
>
> Sorry for the delay here.  This fell between the cracks.
>
> Kalle can you apply this directly to your tree? I'll assign it to you.

Ok, I'll queue this to v5.15.

> And, if possible, add the cc-stable tag so it gets picked up. :)

Ok.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha
  2021-07-02 22:31 [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha Justin M. Forbes
  2021-07-09 17:32 ` Justin Forbes
@ 2021-09-02 16:39 ` Kalle Valo
  1 sibling, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2021-09-02 16:39 UTC (permalink / raw)
  To: Justin M. Forbes
  Cc: Luca Coelho, David S. Miller, Jakub Kicinski, Matti Gottlieb,
	ybaruch, Johannes Berg, Ihab Zhaika, Emmanuel Grumbach,
	linux-wireless, netdev, linux-kernel, jforbes, jmforbes

"Justin M. Forbes" <jforbes@fedoraproject.org> wrote:

> The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> This works fine with the existing driver once it knows to claim it.
> Simple patch to add the device.
> 
> Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Patch applied to wireless-drivers.git, thanks.

2f32c147a381 iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210702223155.1981510-1-jforbes@fedoraproject.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-09-02 16:39 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 22:31 [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha Justin M. Forbes
2021-07-09 17:32 ` Justin Forbes
2021-08-08 23:09   ` Jaehoon Chung
2021-08-12 22:26     ` Jaehoon Chung
2021-08-21 13:34       ` Kalle Valo
2021-08-25 18:07         ` Justin Forbes
2021-08-31  6:36           ` Coelho, Luciano
2021-08-31  6:49             ` Kalle Valo
2021-09-02 16:39 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).