LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Nadezda Lutovinova <lutovinova@ispras.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Johan Hovold <johan@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	ldv-project@linuxtesting.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: gadget: mv_u3d: request_irq() after initializing UDC
Date: Wed, 18 Aug 2021 17:33:16 +0300	[thread overview]
Message-ID: <87k0kig6v2.fsf@kernel.org> (raw)
In-Reply-To: <20210818141247.4794-1-lutovinova@ispras.ru>


Nadezda Lutovinova <lutovinova@ispras.ru> writes:

> If IRQ occurs between calling  request_irq() and  mv_u3d_eps_init(),
> then null pointer dereference occurs since u3d->eps[] wasn't
> initialized yet but used in mv_u3d_nuke().
>
> The patch puts registration of the interrupt handler after
> initializing of neccesery data.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Fixes: 90fccb529d24 ("usb: gadget: Gadget directory cleanup - group UDC drivers")
> Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>

Thanks for updating so quickly:

Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi

      reply	other threads:[~2021-08-18 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 13:01 [PATCH] usb: gadget: mv_u3d: Change functon call in mv_u3d_probe() Nadezda Lutovinova
2021-08-18 13:10 ` Felipe Balbi
2021-08-18 14:12   ` [PATCH v2] usb: gadget: mv_u3d: request_irq() after initializing UDC Nadezda Lutovinova
2021-08-18 14:33     ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0kig6v2.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lutovinova@ispras.ru \
    --cc=stable@vger.kernel.org \
    --subject='Re: [PATCH v2] usb: gadget: mv_u3d: request_irq() after initializing UDC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).