LKML Archive on
help / color / mirror / Atom feed
From: Stewart Smith <>
To: Michael Ellerman <>,
	Akshay Adiga <>,,
	Akshay Adiga <>
Subject: Re: [PATCH] cpuidle/powernv : init all present cpus for deep states
Date: Mon, 28 May 2018 10:46:11 +1000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Michael Ellerman <> writes:
> Akshay Adiga <> writes:
>> Init all present cpus for deep states instead of "all possible" cpus.
>> Init fails if the possible cpu is gaurded. Resulting in making only
>> non-deep states available for cpuidle/hotplug.
> This is basically the opposite of what we just did for IMC.
> There we switched from present to possible, to make it work when some
> CPUs are guarded.
> Which makes me think we need a better way of dealing with guarded CPUs,
> because working out which code should use present or possible seems to
> be basically trial-and-error.
> I'm not actually sure why Guarded CPUs are showing up as possible but
> not present, did we do that on purpose or is it just happening by
> accident?

My guess is that it flows through from firmware putting the guarded out
CPUs in the device tree with a not "okay" status (which, I just
realised, we're putting something in 'status' that isn't what the
current DeviceTree spec says we should... gah - filed for that one).

The idea behind that is that you can answer "where did all my CPUs go?"
by looking at the device tree rather than having to know the platform
specific way of how guards are stored.

Stewart Smith
OPAL Architect, IBM.

  reply	other threads:[~2018-05-28  0:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 12:02 [PATCH] cpuidle/powernv : init all present cpus for deep states Akshay Adiga
2018-05-16 15:22 ` Stewart Smith
2018-05-17  5:55   ` Akshay Adiga
2018-05-25 10:52     ` Michael Ellerman
2018-05-24  6:53 ` Akshay Adiga
2018-05-25 10:50 ` Michael Ellerman
2018-05-28  0:46   ` Stewart Smith [this message]
2018-06-01 15:54 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).