LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com> To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org> Cc: Daniel Vetter <daniel.vetter@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Daniel Thompson <daniel.thompson@linaro.org>, Lee Jones <lee.jones@linaro.org>, Jingoo Han <jingoohan1@gmail.com> Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state Date: Mon, 30 Apr 2018 13:21:16 +0300 [thread overview] Message-ID: <87lgd59eqr.fsf@intel.com> (raw) In-Reply-To: <20180425174253.4616-2-daniel.vetter@ffwll.ch> On Wed, 25 Apr 2018, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Nothing in the entire tree ever sets this, which means this is dead > code. Remove it. > > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Jingoo Han <jingoohan1@gmail.com> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/video/backlight/generic_bl.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c > index 67dfb939a514..4dea91acea13 100644 > --- a/drivers/video/backlight/generic_bl.c > +++ b/drivers/video/backlight/generic_bl.c > @@ -21,9 +21,6 @@ static int genericbl_intensity; > static struct backlight_device *generic_backlight_device; > static struct generic_bl_info *bl_machinfo; > > -/* Flag to signal when the battery is low */ > -#define GENERICBL_BATTLOW BL_CORE_DRIVER1 > - > static int genericbl_send_intensity(struct backlight_device *bd) > { > int intensity = bd->props.brightness; > @@ -34,8 +31,6 @@ static int genericbl_send_intensity(struct backlight_device *bd) > intensity = 0; > if (bd->props.state & BL_CORE_SUSPENDED) > intensity = 0; > - if (bd->props.state & GENERICBL_BATTLOW) > - intensity &= bl_machinfo->limit_mask; > > bl_machinfo->set_bl_intensity(intensity); -- Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2018-04-30 10:18 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-25 17:42 [PATCH 1/6] backlight: Nuke unused backlight.props.state states Daniel Vetter 2018-04-25 17:42 ` [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state Daniel Vetter 2018-04-30 10:21 ` Jani Nikula [this message] 2018-04-25 17:42 ` [PATCH 3/6] backlight/pandora: Stop using BL_CORE_DRIVER1 Daniel Vetter 2018-04-30 10:22 ` Jani Nikula 2018-04-25 17:42 ` [PATCH 4/6] staging/fbtft: " Daniel Vetter 2018-04-30 9:54 ` Lee Jones 2018-04-30 10:59 ` Greg KH 2018-04-30 10:22 ` Jani Nikula 2018-04-25 17:42 ` [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1 Daniel Vetter 2018-04-30 10:24 ` Jani Nikula 2018-04-30 12:14 ` Lee Jones 2018-04-25 17:42 ` [PATCH 6/6] MAINTAINERS: add dri-devel for backlight subsystem patches Daniel Vetter 2018-04-25 19:43 ` Jingoo Han 2018-04-25 19:42 ` [PATCH 1/6] backlight: Nuke unused backlight.props.state states Jingoo Han 2018-04-30 10:21 ` Jani Nikula 2018-04-30 12:27 ` Lee Jones -- strict thread matches above, loose matches on Subject: below -- 2018-01-17 14:01 Daniel Vetter 2018-01-17 14:01 ` [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state Daniel Vetter 2018-01-17 14:36 ` Emil Velikov 2018-01-17 16:37 ` Daniel Thompson 2018-01-18 13:08 ` Emil Velikov 2018-01-17 16:44 ` Daniel Thompson 2018-01-17 17:13 ` Daniel Vetter 2018-01-18 9:20 ` Daniel Thompson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87lgd59eqr.fsf@intel.com \ --to=jani.nikula@linux.intel.com \ --cc=daniel.thompson@linaro.org \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jingoohan1@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).