LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: paulmck@kernel.org
Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org,
	kernel-team@fb.com, ak@linux.intel.com, rong.a.chen@intel.com,
	sboyd@kernel.org
Subject: Re: [GIT PULL clocksource] Clocksource watchdog commits for v5.15
Date: Thu, 12 Aug 2021 19:11:55 +0200	[thread overview]
Message-ID: <87mtpmh9k4.ffs@tglx> (raw)
In-Reply-To: <20210812163753.GW4126399@paulmck-ThinkPad-P17-Gen-1>

On Thu, Aug 12 2021 at 09:37, Paul E. McKenney wrote:

> On Thu, Aug 12, 2021 at 03:46:42PM +0200, Thomas Gleixner wrote:
>> On Wed, Aug 11 2021 at 17:01, Paul E. McKenney wrote:
>> > This pull request contains a single change that prevents clocksource
>> > watchdog testing on systems with HZ < 100, thus preventing the integer
>> > underflow that can occur on leisurely HZed systems.  This has been
>> > posted to LKML:
>> >
>> > https://lore.kernel.org/lkml/20210721212755.GA2066078@paulmck-ThinkPad-P17-Gen-1/
>> 
>> So with HZ < 100 .mult overflows, but why not simply adjusting the
>> mult, shift value to be
>> 
>>       .mult	= TICK_NSEC,
>>       .shift	= 0,
>> 
>> which is effectively the same as
>> 
>>       .mult	= TICK_NSEC << 8,
>>       .shift	= 8,
>> 
>> Hmm?
>
> Another option would be for me to be less lazy and to move this code:
>
> 	/* Since jiffies uses a simple TICK_NSEC multiplier
> 	 * conversion, the .shift value could be zero. However
> 	 * this would make NTP adjustments impossible as they are
> 	 * in units of 1/2^.shift. Thus we use JIFFIES_SHIFT to
> 	 * shift both the nominator and denominator the same
> 	 * amount, and give ntp adjustments in units of 1/2^8
> 	 *
> 	 * The value 8 is somewhat carefully chosen, as anything
> 	 * larger can result in overflows. TICK_NSEC grows as HZ
> 	 * shrinks, so values greater than 8 overflow 32bits when
> 	 * HZ=100.
> 	 */
> 	#if HZ < 34
> 	#define JIFFIES_SHIFT	6
> 	#elif HZ < 67
> 	#define JIFFIES_SHIFT	7
> 	#else
> 	#define JIFFIES_SHIFT	8
> 	#endif
>
> from kernel/time/jiffies.c to include/linux/clocksource.h.

No need to expose this globaly.

  kernel/time/tick-internal.h or kernel/time/jiffies.h

Thanks,

        tglx

  reply	other threads:[~2021-08-12 17:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  0:01 Paul E. McKenney
2021-08-12 13:46 ` Thomas Gleixner
2021-08-12 16:37   ` Paul E. McKenney
2021-08-12 17:11     ` Thomas Gleixner [this message]
2021-08-12 20:01       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtpmh9k4.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=ak@linux.intel.com \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rong.a.chen@intel.com \
    --cc=sboyd@kernel.org \
    --subject='Re: [GIT PULL clocksource] Clocksource watchdog commits for v5.15' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).