LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] reiserfs: remove workaround code for GCC 3.x
@ 2018-08-27  2:33 Masahiro Yamada
  2018-10-19 21:59 ` Jeff Mahoney
  2018-10-31  5:50 ` Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-08-27  2:33 UTC (permalink / raw)
  To: reiserfs-devel
  Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
	Masahiro Yamada, linux-kernel, Thomas Gleixner,
	Philippe Ombredanne, Kate Stewart, Greg Kroah-Hartman

Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.

The workaround code in fs/reiserfs/Makefile is obsolete now.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 fs/reiserfs/Makefile | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/fs/reiserfs/Makefile b/fs/reiserfs/Makefile
index a39a562..bd29c58 100644
--- a/fs/reiserfs/Makefile
+++ b/fs/reiserfs/Makefile
@@ -26,14 +26,5 @@ ifeq ($(CONFIG_REISERFS_FS_POSIX_ACL),y)
 reiserfs-objs += xattr_acl.o
 endif
 
-# gcc -O2 (the kernel default)  is overaggressive on ppc32 when many inline
-# functions are used.  This causes the compiler to advance the stack
-# pointer out of the available stack space, corrupting kernel space,
-# and causing a panic. Since this behavior only affects ppc32, this ifeq
-# will work around it. If any other architecture displays this behavior,
-# add it here.
-ccflags-$(CONFIG_PPC32) := $(call cc-ifversion, -lt, 0400, -O1)
-
 TAGS:
 	etags *.c
-
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] reiserfs: remove workaround code for GCC 3.x
  2018-08-27  2:33 [PATCH] reiserfs: remove workaround code for GCC 3.x Masahiro Yamada
@ 2018-10-19 21:59 ` Jeff Mahoney
  2018-10-31  5:50 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Jeff Mahoney @ 2018-10-19 21:59 UTC (permalink / raw)
  To: Masahiro Yamada, reiserfs-devel
  Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
	linux-kernel, Thomas Gleixner, Philippe Ombredanne, Kate Stewart,
	Greg Kroah-Hartman


[-- Attachment #1.1: Type: text/plain, Size: 1280 bytes --]

On 8/26/18 10:33 PM, Masahiro Yamada wrote:
> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> bumped the minimum GCC version to 4.6 for all architectures.
> 
> The workaround code in fs/reiserfs/Makefile is obsolete now.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Jeff Mahoney <jeffm@suse.com>

Thanks,

-Jeff

> ---
> 
>  fs/reiserfs/Makefile | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/fs/reiserfs/Makefile b/fs/reiserfs/Makefile
> index a39a562..bd29c58 100644
> --- a/fs/reiserfs/Makefile
> +++ b/fs/reiserfs/Makefile
> @@ -26,14 +26,5 @@ ifeq ($(CONFIG_REISERFS_FS_POSIX_ACL),y)
>  reiserfs-objs += xattr_acl.o
>  endif
>  
> -# gcc -O2 (the kernel default)  is overaggressive on ppc32 when many inline
> -# functions are used.  This causes the compiler to advance the stack
> -# pointer out of the available stack space, corrupting kernel space,
> -# and causing a panic. Since this behavior only affects ppc32, this ifeq
> -# will work around it. If any other architecture displays this behavior,
> -# add it here.
> -ccflags-$(CONFIG_PPC32) := $(call cc-ifversion, -lt, 0400, -O1)
> -
>  TAGS:
>  	etags *.c
> -
> 

-- 
Jeff Mahoney
SUSE Labs



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] reiserfs: remove workaround code for GCC 3.x
  2018-08-27  2:33 [PATCH] reiserfs: remove workaround code for GCC 3.x Masahiro Yamada
  2018-10-19 21:59 ` Jeff Mahoney
@ 2018-10-31  5:50 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2018-10-31  5:50 UTC (permalink / raw)
  To: Masahiro Yamada, reiserfs-devel
  Cc: Benjamin Herrenschmidt, Paul Mackerras, Masahiro Yamada,
	linux-kernel, Thomas Gleixner, Philippe Ombredanne, Kate Stewart,
	Greg Kroah-Hartman

Masahiro Yamada <yamada.masahiro@socionext.com> writes:

> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> bumped the minimum GCC version to 4.6 for all architectures.
>
> The workaround code in fs/reiserfs/Makefile is obsolete now.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  fs/reiserfs/Makefile | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/fs/reiserfs/Makefile b/fs/reiserfs/Makefile
> index a39a562..bd29c58 100644
> --- a/fs/reiserfs/Makefile
> +++ b/fs/reiserfs/Makefile
> @@ -26,14 +26,5 @@ ifeq ($(CONFIG_REISERFS_FS_POSIX_ACL),y)
>  reiserfs-objs += xattr_acl.o
>  endif
>  
> -# gcc -O2 (the kernel default)  is overaggressive on ppc32 when many inline
> -# functions are used.  This causes the compiler to advance the stack
> -# pointer out of the available stack space, corrupting kernel space,
> -# and causing a panic. Since this behavior only affects ppc32, this ifeq
> -# will work around it. If any other architecture displays this behavior,
> -# add it here.
> -ccflags-$(CONFIG_PPC32) := $(call cc-ifversion, -lt, 0400, -O1)
> -
>  TAGS:
>  	etags *.c

Oh wow that's gross. Thanks for cleaning it up.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-31  5:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-27  2:33 [PATCH] reiserfs: remove workaround code for GCC 3.x Masahiro Yamada
2018-10-19 21:59 ` Jeff Mahoney
2018-10-31  5:50 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).