LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency
@ 2018-05-25 16:07 Arnd Bergmann
  2018-05-28 23:49 ` Benjamin Herrenschmidt
  2018-05-30 12:29 ` Felipe Balbi
  0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2018-05-25 16:07 UTC (permalink / raw)
  To: Felipe Balbi, Greg Kroah-Hartman
  Cc: Arnd Bergmann, Joel Stanley, Andrew Jeffery,
	Benjamin Herrenschmidt, linux-usb, linux-arm-kernel,
	linux-aspeed, linux-kernel

Without that option, we run into a link failure:

drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request':
hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string'

Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
index f0cdf89b8503..83ba8a2eb6af 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
+++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
@@ -2,6 +2,7 @@
 config USB_ASPEED_VHUB
 	tristate "Aspeed vHub UDC driver"
 	depends on ARCH_ASPEED || COMPILE_TEST
+	depends on USB_LIBCOMPOSITE
 	help
 	  USB peripheral controller for the Aspeed AST2500 family
 	  SoCs supporting the "vHub" functionality and USB2.0
-- 
2.9.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency
  2018-05-25 16:07 [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency Arnd Bergmann
@ 2018-05-28 23:49 ` Benjamin Herrenschmidt
  2018-05-30 12:29 ` Felipe Balbi
  1 sibling, 0 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2018-05-28 23:49 UTC (permalink / raw)
  To: Arnd Bergmann, Felipe Balbi, Greg Kroah-Hartman
  Cc: Joel Stanley, Andrew Jeffery, linux-usb, linux-arm-kernel,
	linux-aspeed, linux-kernel

On Fri, 2018-05-25 at 18:07 +0200, Arnd Bergmann wrote:
> Without that option, we run into a link failure:
> 
> drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request':
> hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string'

Thanks ! I hadn't realized these functions were part of an optional
library.

> Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
> index f0cdf89b8503..83ba8a2eb6af 100644
> --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
> +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig
> @@ -2,6 +2,7 @@
>  config USB_ASPEED_VHUB
>  	tristate "Aspeed vHub UDC driver"
>  	depends on ARCH_ASPEED || COMPILE_TEST
> +	depends on USB_LIBCOMPOSITE
>  	help
>  	  USB peripheral controller for the Aspeed AST2500 family
>  	  SoCs supporting the "vHub" functionality and USB2.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency
  2018-05-25 16:07 [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency Arnd Bergmann
  2018-05-28 23:49 ` Benjamin Herrenschmidt
@ 2018-05-30 12:29 ` Felipe Balbi
  2018-06-12  4:29   ` Benjamin Herrenschmidt
  1 sibling, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2018-05-30 12:29 UTC (permalink / raw)
  To: Arnd Bergmann, Greg Kroah-Hartman
  Cc: Arnd Bergmann, Joel Stanley, Andrew Jeffery,
	Benjamin Herrenschmidt, linux-usb, linux-arm-kernel,
	linux-aspeed, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]


Hi,

Arnd Bergmann <arnd@arndb.de> writes:
> Without that option, we run into a link failure:
>
> drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request':
> hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string'
>
> Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency
  2018-05-30 12:29 ` Felipe Balbi
@ 2018-06-12  4:29   ` Benjamin Herrenschmidt
  2018-06-14 20:20     ` Randy Dunlap
  0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2018-06-12  4:29 UTC (permalink / raw)
  To: Felipe Balbi, Arnd Bergmann, Greg Kroah-Hartman
  Cc: Joel Stanley, Andrew Jeffery, linux-usb, linux-arm-kernel,
	linux-aspeed, linux-kernel

On Wed, 2018-05-30 at 15:29 +0300, Felipe Balbi wrote:
> Hi,
> 
> Arnd Bergmann <arnd@arndb.de> writes:
> > Without that option, we run into a link failure:
> > 
> > drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request':
> > hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string'
> > 
> > Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

Greg, can you send this to Linus asap ? Some people are hitting build
breakages upstream because of this.

Thanks !

Cheers,
Ben,



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency
  2018-06-12  4:29   ` Benjamin Herrenschmidt
@ 2018-06-14 20:20     ` Randy Dunlap
  0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2018-06-14 20:20 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Felipe Balbi, Arnd Bergmann, Greg Kroah-Hartman
  Cc: Joel Stanley, Andrew Jeffery, linux-usb, linux-arm-kernel,
	linux-aspeed, linux-kernel

On 06/11/2018 09:29 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2018-05-30 at 15:29 +0300, Felipe Balbi wrote:
>> Hi,
>>
>> Arnd Bergmann <arnd@arndb.de> writes:
>>> Without that option, we run into a link failure:
>>>
>>> drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request':
>>> hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string'
>>>
>>> Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> 
> Greg, can you send this to Linus asap ? Some people are hitting build
> breakages upstream because of this.

Agreed.

> Thanks !

ditto.

-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-06-14 20:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-25 16:07 [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency Arnd Bergmann
2018-05-28 23:49 ` Benjamin Herrenschmidt
2018-05-30 12:29 ` Felipe Balbi
2018-06-12  4:29   ` Benjamin Herrenschmidt
2018-06-14 20:20     ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).