From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FBEC433F5 for ; Fri, 24 Sep 2021 16:45:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63DC460EE7 for ; Fri, 24 Sep 2021 16:45:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343842AbhIXQqx (ORCPT ); Fri, 24 Sep 2021 12:46:53 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:58756 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343764AbhIXQqw (ORCPT ); Fri, 24 Sep 2021 12:46:52 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]:41616) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mToK4-00DD1A-6l; Fri, 24 Sep 2021 10:45:16 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:48876 helo=email.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mToK2-00GHdg-8U; Fri, 24 Sep 2021 10:45:15 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Manfred Spraul Cc: Alexander Mihalicyn , Andrew Morton , "linux-kernel\@vger.kernel.org" , Milton Miller , Jack Miller , Pavel Tikhomirov , Davidlohr Bueso , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrei Vagin , Christian Brauner References: <20210706132259.71740-1-alexander.mikhalitsyn@virtuozzo.com> <20210709181241.cca57cf83c52964b2cd0dcf0@linux-foundation.org> <87y2ab9w8u.fsf@disp2133> <00ce7bff-e432-8244-1765-12460817baab@colorfullife.com> Date: Fri, 24 Sep 2021 11:45:07 -0500 In-Reply-To: <00ce7bff-e432-8244-1765-12460817baab@colorfullife.com> (Manfred Spraul's message of "Thu, 23 Sep 2021 18:36:16 +0200") Message-ID: <87pmsxorcc.fsf@disp2133> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1mToK2-00GHdg-8U;;;mid=<87pmsxorcc.fsf@disp2133>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18aWtGQ0imt7CbQjqrTDEas2KQJw3Y/wn8= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 0/2] shm: omit forced shm destroy if task IPC namespace was changed X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Manfred Spraul writes: > Hi Eric, > > I'd like to restart the discussion, the issue should be fixed. Agreed. I am going to come right out and say having read through everything my suggests were confused and wrong. Somehow I thought the cleanups I was suggesting world result in shm_clist only being modified from the task that owns the list. Which would result in no need to use a per-task list. Having looked through my suggestions again I was completely wrong. The only useful bit I have to contribute from that original suggestion is let's please have smallish patches that change one thing at a time. That code is sufficiently interesting that it is way too easy to get lost in big patches. I am not going to discuss my broken suggestions right now because every time I look into them I go into a rabbit hole and I don't get anything productive done on fixing these issues, just something close and frustrating. Apologies if I derailed your patch. Eric