LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ipw2x00: no need to initilise statics to 0
@ 2021-08-17 11:54 Jason Wang
  2021-08-21 14:11 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2021-08-17 11:54 UTC (permalink / raw)
  To: kvalo
  Cc: stas.yakovlev, davem, kuba, linux-wireless, netdev, linux-kernel,
	Jason Wang

Global static variables dont need to be initialised to 0. Because
the compiler will initilise them.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/net/wireless/intel/ipw2x00/ipw2100.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index 47eb89b773cf..6bfe55d79ce1 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -173,11 +173,11 @@ MODULE_VERSION(DRV_VERSION);
 MODULE_AUTHOR(DRV_COPYRIGHT);
 MODULE_LICENSE("GPL");
 
-static int debug = 0;
-static int network_mode = 0;
-static int channel = 0;
-static int associate = 0;
-static int disable = 0;
+static int debug;
+static int network_mode;
+static int channel;
+static int associate;
+static int disable;
 #ifdef CONFIG_PM
 static struct ipw2100_fw ipw2100_firmware;
 #endif
@@ -7197,7 +7197,7 @@ static int ipw2100_wx_set_txpow(struct net_device *dev,
 {
 	struct ipw2100_priv *priv = libipw_priv(dev);
 	int err = 0, value;
-	
+
 	if (ipw_radio_kill_sw(priv, wrqu->txpower.disabled))
 		return -EINPROGRESS;
 
-- 
2.32.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipw2x00: no need to initilise statics to 0
  2021-08-17 11:54 [PATCH] ipw2x00: no need to initilise statics to 0 Jason Wang
@ 2021-08-21 14:11 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-08-21 14:11 UTC (permalink / raw)
  To: Jason Wang
  Cc: stas.yakovlev, davem, kuba, linux-wireless, netdev, linux-kernel

Jason Wang <wangborong@cdjrlc.com> writes:

> Global static variables dont need to be initialised to 0. Because
> the compiler will initilise them.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  drivers/net/wireless/intel/ipw2x00/ipw2100.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
> index 47eb89b773cf..6bfe55d79ce1 100644
> --- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
> +++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c

[...]

> @@ -7197,7 +7197,7 @@ static int ipw2100_wx_set_txpow(struct net_device *dev,
>  {
>  	struct ipw2100_priv *priv = libipw_priv(dev);
>  	int err = 0, value;
> -	
> +

Unrelated change.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-21 14:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 11:54 [PATCH] ipw2x00: no need to initilise statics to 0 Jason Wang
2021-08-21 14:11 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).