LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>,
	linux-kernel@vger.kernel.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: fix failure to power off after hibernate
Date: Thu, 26 Feb 2015 21:29:31 +0100	[thread overview]
Message-ID: <87pp8w2z84.fsf@nemi.mork.no> (raw)
In-Reply-To: <20150226200556.GF11371@intel.com> ("Ville =?utf-8?B?U3lyasOk?= =?utf-8?B?bMOkIidz?= message of "Thu, 26 Feb 2015 22:05:56 +0200")

Ville Syrjälä <ville.syrjala@linux.intel.com> writes:

>> @@ -651,7 +651,14 @@ static int i915_drm_suspend_late(struct drm_device *drm_dev)
>>  	}
>>  
>>  	pci_disable_device(drm_dev->pdev);
>> -	pci_set_power_state(drm_dev->pdev, PCI_D3hot);
>> +	/*
>> +	 * During hibernation on some GM45 platforms the BIOS may try to access
>> +	 * the device even though it's already in D3 and hang the machine. So
>> +	 * leave the device in D0 on those platforms and hope the BIOS will
>> +	 * power down the device properly.
>
> Please include the model of the known bad machine in this comment, to
> help future archaeologists.

Here are some details:

bjorn@nemi:~$ grep . /sys/class/dmi/id/{bios,product}* 2>/dev/null 
/sys/class/dmi/id/bios_date:12/19/2011
/sys/class/dmi/id/bios_vendor:LENOVO
/sys/class/dmi/id/bios_version:6EET55WW (3.15 )
/sys/class/dmi/id/product_name:2776LEG
/sys/class/dmi/id/product_version:ThinkPad X301

Please let me know if you need some other data.


Bjørn

      reply	other threads:[~2015-02-26 20:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 14:49 [BISECTED REGRESSION v3.18->v3.19-rc1] drm/i915: failure to poweroff after hibernation Bjørn Mork
2015-02-24 14:58 ` [PATCH] drm/i915: fix failure to power off after hibernate Bjørn Mork
2015-02-24 16:12   ` Imre Deak
2015-02-24 19:00     ` Bjørn Mork
2015-02-25 18:33       ` Imre Deak
2015-02-26  9:34         ` Bjørn Mork
2015-02-26 18:50           ` Imre Deak
2015-02-26 19:20             ` Bjørn Mork
2015-02-26 20:01             ` [Intel-gfx] " Daniel Vetter
2015-02-27 12:15               ` David Weinehall
2015-02-27 18:23                 ` Imre Deak
2015-03-02  8:55                   ` David Weinehall
2015-02-26 20:05             ` Ville Syrjälä
2015-02-26 20:29               ` Bjørn Mork [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pp8w2z84.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    --subject='Re: [PATCH] drm/i915: fix failure to power off after hibernate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).