LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Johannes Weiner <hannes@saeurebad.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: thinkpad_acpi: define _sta only when needed
Date: Wed, 16 Jan 2008 22:10:27 +0100	[thread overview]
Message-ID: <87sl0xcw8s.fsf@saeurebad.de> (raw)
In-Reply-To: <20080116191317.GA29449@khazad-dum.debian.net> (Henrique de Moraes Holschuh's message of "Wed, 16 Jan 2008 17:13:17 -0200")

Hi Henrique,

Henrique de Moraes Holschuh <hmh@hmh.eng.br> writes:

> On Wed, 16 Jan 2008, Johannes Weiner wrote:
>> Define _sta() helper conditionally; also remove its prototype from
>> the internal header and also some other unneeded ones.
>> 
>> This function is only needed when the bay or the dock subdriver is
>> enabled.  Otherwise, gcc complains about an unused static function.
>
> Johannes, thanks for the patches, but NAK.  A similar group of patches that
> clean up the _sta and heander file (kills it, actually) has already been
> sent to Len Brown to be merged for 2.6.25.

Sorry, I missed to check his tree in advance.  And if the work is
already done - even better! :)

	Hannes

  reply	other threads:[~2008-01-16 21:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 13:01 thinkpad_acpi: define _sta only when needed Johannes Weiner
2008-01-16 13:01 ` [PATCH] thinkpad_acpi: Remove superfluous prototypes from internal header Johannes Weiner
2008-01-16 13:01   ` [PATCH] thinkpad_acpi: Define _sta() only when there are callsites Johannes Weiner
2008-01-16 19:14     ` Henrique de Moraes Holschuh
2008-01-16 19:13   ` [PATCH] thinkpad_acpi: Remove superfluous prototypes from internal header Henrique de Moraes Holschuh
2008-01-16 19:13 ` thinkpad_acpi: define _sta only when needed Henrique de Moraes Holschuh
2008-01-16 21:10   ` Johannes Weiner [this message]
2008-01-16 21:54     ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sl0xcw8s.fsf@saeurebad.de \
    --to=hannes@saeurebad.de \
    --cc=hmh@hmh.eng.br \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).