LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Collins <paul@burly.ondioline.org>
To: benh@kernel.crashing.org
Cc: James Cloos <cloos@jhcloos.com>,
	linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: [Linux-fbdev-devel] radeonfb lockup in .28-rc (bisected)
Date: Tue, 04 Nov 2008 19:49:54 +1300	[thread overview]
Message-ID: <87wsfkrnn1.fsf@burly.wgtn.ondioline.org> (raw)
In-Reply-To: <1225697689.8004.245.camel@pasglop> (Benjamin Herrenschmidt's message of "Mon, 03 Nov 2008 18:34:49 +1100")

Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:

> One thing you may want to try .. it will result in crap results on
> screen but would help telling us if that's the cause, is to hack
> radeonfb to round the image size to a multiple of 32 and see if that
> stops the lockup.

I took a guess at how to do this and ended up with the patch below.

With the patch applied, the screen turns almost completely to gibberish
at console handover and the machine hangs.  At the top I get two lines
of old output from the previous boot.  (I'm pretty sure it's hung
because the optical drive init happens after console handover, and I
don't get the usual chunka-chunka noise.)

The corruption I get is very similar to what I got when I originally
reported the problem when I was using my patched-in 12x24 font.  (I
created the .psf version later and switched back to default 8x16 to
verify my problem was the same as James's.)


diff --git a/drivers/video/aty/radeon_accel.c b/drivers/video/aty/radeon_accel.c
index 8718f73..848e9bc 100644
--- a/drivers/video/aty/radeon_accel.c
+++ b/drivers/video/aty/radeon_accel.c
@@ -208,7 +208,11 @@ static void radeonfb_prim_imageblit(struct radeonfb_info *rinfo,
 	 * work ok for me without that and the doco doesn't seem to imply
 	 * there is such a restriction.
 	 */
-	OUTREG(DST_WIDTH_HEIGHT, (image->width << 16) | image->height);
+	{
+		/* Hack attack. */
+		int width = ((image->width - 1) / 32 + 1) * 32;
+		OUTREG(DST_WIDTH_HEIGHT, (width << 16) | image->height);
+	}
 
 	src_bytes = (((image->width * image->depth) + 7) / 8) * image->height;
 	dwords = (src_bytes + 3) / 4;


-- 
Paul Collins
Wellington, New Zealand

Dag vijandelijk luchtschip de huismeester is dood

  reply	other threads:[~2008-11-04  6:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m31vy1k3ea.fsf@lugabout.jhcloos.org>
2008-10-28  0:00 ` David Miller
2008-10-28  1:46   ` James Cloos
2008-10-28  0:05 ` Benjamin Herrenschmidt
2008-10-28  1:50   ` James Cloos
2008-10-28  9:24   ` James Cloos
2008-11-02 21:48     ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2008-11-03  7:01       ` Paul Collins
2008-11-03  7:34         ` Benjamin Herrenschmidt
2008-11-04  6:49           ` Paul Collins [this message]
2008-11-04 21:33             ` Benjamin Herrenschmidt
2008-11-06  6:00               ` Paul Collins
2008-11-06  7:52                 ` Benjamin Herrenschmidt
2008-11-04 21:36             ` Benjamin Herrenschmidt
2008-11-05  8:39         ` Benjamin Herrenschmidt
2008-11-05 10:28           ` Paul Collins
2008-11-05 20:31             ` Benjamin Herrenschmidt
2008-11-06  3:49             ` Benjamin Herrenschmidt
2008-11-06  4:49               ` Paul Collins
2008-11-03 15:33       ` James Cloos
2008-11-03 20:22         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wsfkrnn1.fsf@burly.wgtn.ondioline.org \
    --to=paul@burly.ondioline.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=cloos@jhcloos.com \
    --cc=davem@davemloft.net \
    --cc=khc@pm.waw.pl \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [Linux-fbdev-devel] radeonfb lockup in .28-rc (bisected)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).