LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: balbi@ti.com
Subject: [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL
Date: Fri, 21 Jan 2011 09:33:33 +0100 [thread overview]
Message-ID: <87y66e3bc2.fsf_-_@vostro.fn.ogness.net> (raw)
In-Reply-To: <20110121031553.GA2448@legolas.emea.dhcp.ti.com> (Felipe Balbi's message of "Fri\, 21 Jan 2011 05\:15\:53 +0200")
From: John Ogness <john.ogness@linutronix.de>
In OMAP35X TRM Rev 2010-05 Figure 7-18 "DPLL With EMI Reduction
Feature", it is shown that the internal frequency is calculated by
CLK_IN/(N+1). However, the value passed to _dpll_test_fint() is
already "N+1" since Linux is using the values to divide by. In the
technical reference manual, "N" is referring to the divider's register
value (0-127).
Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
patch v3:
Patch against linux-next-20110121.
I have improved the commit message so that it is acceptable for the
git commit log.
arch/arm/mach-omap2/clkt_dpll.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/clkt_dpll.c b/arch/arm/mach-omap2/clkt_dpll.c
index 337392c..acb7ae5 100644
--- a/arch/arm/mach-omap2/clkt_dpll.c
+++ b/arch/arm/mach-omap2/clkt_dpll.c
@@ -77,7 +77,7 @@ static int _dpll_test_fint(struct clk *clk, u8 n)
dd = clk->dpll_data;
/* DPLL divider must result in a valid jitter correction val */
- fint = clk->parent->rate / (n + 1);
+ fint = clk->parent->rate / n;
if (fint < DPLL_FINT_BAND1_MIN) {
pr_debug("rejecting n=%d due to Fint failure, "
--
1.5.6.5
next prev parent reply other threads:[~2011-01-21 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 10:42 [PATCH] omap2: fix DPLL_FREQSEL calculation John Ogness
2011-01-20 11:16 ` Felipe Balbi
2011-01-20 14:29 ` [PATCH v2] " John Ogness
2011-01-21 3:15 ` Felipe Balbi
2011-01-21 8:33 ` John Ogness [this message]
2011-02-08 3:09 ` [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y66e3bc2.fsf_-_@vostro.fn.ogness.net \
--to=john.ogness@linutronix.de \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--subject='Re: [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).