LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Bart Dopheide <dopheide@fmf.nl>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
	Bartlomiej Zolnierkiewicz <mzolnier@gmail.com>
Subject: Re: Kernel BUG at fs/mpage.c:489
Date: Thu, 14 Feb 2008 02:40:20 +0900	[thread overview]
Message-ID: <87zlu492m3.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <20080213010145.76ee9714.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 13 Feb 2008 01:01:45 -0800")

Andrew Morton <akpm@linux-foundation.org> writes:

> On Wed, 13 Feb 2008 08:26:27 +0100 Bart Dopheide <dopheide@fmf.nl> wrote:
>
>> On Wed, Feb 13, 2008 at 12:05:45PM +1100, Nick Piggin wrote:
>> :)On Wednesday 13 February 2008 08:50, Alan Cox wrote:
>> :)> Almost certainly a hardware fail of some sort.
>> :)
>> :)Right, but the kernel shouldn't go bug...
>> 
>> Indeed, that's why I'm reporting.
>> 
>> 
>> :)I don't have a copy of your exact source code... which condition in
>> :)__mpage_writepage went BUG?
>> 
>> BUG_ON(buffer_locked(bh));
>> 
>> In a bit of context:
>> 482:    if (page_has_buffers(page)) {
>> 483:            struct buffer_head *head = page_buffers(page);
>> 484:            struct buffer_head *bh = head;
>> 485:
>> 486:            /* If they're all mapped and dirty, do it */
>> 487:            page_block = 0;
>> 488:            do {
>> 489:                    BUG_ON(buffer_locked(bh));
>> 490:                    if (!buffer_mapped(bh)) {
>> 491:                            /*
>> 492:                             * unmapped dirty buffers are created by
>> 493:                             * __set_page_dirty_buffers -> mmapped data
>> 494:                             */
>> 495:                            if (buffer_dirty(bh))
>> 496:                                    goto confused;
>> 497:                            if (first_unmapped == blocks_per_page)
>> 498:                                    first_unmapped = page_block;
>> 499:                            continue;
>> 500:                    }
>> 
>
> Probably means that either fat, IDE, block or fs/buffer.c failed to unlock a buffer_head
> when the IO error happened.  It's unlikely to be fat.

Yes. FAT does almost nothing on this path. Um...
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

      parent reply	other threads:[~2008-02-13 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 19:45 Bart Dopheide
2008-02-12 21:50 ` Alan Cox
2008-02-13  1:05   ` Nick Piggin
2008-02-13  7:26     ` Bart Dopheide
2008-02-13  9:01       ` Andrew Morton
2008-02-13  9:24         ` Nick Piggin
2008-02-13  9:32           ` Andrew Morton
2008-02-13  9:39             ` Nick Piggin
2008-02-13 17:40         ` OGAWA Hirofumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zlu492m3.fsf@duaron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dopheide@fmf.nl \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mzolnier@gmail.com \
    --cc=nickpiggin@yahoo.com.au \
    --subject='Re: Kernel BUG at fs/mpage.c:489' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).