LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Quel Qun <kelk1@comcast.net>,
	David Woodhouse <dwmw2@infradead.org>,
	Dave Young <hidave.darkstar@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Jiri Kosina <jkosina@suse.cz>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()
Date: Tue, 26 Feb 2008 20:38:25 +0100	[thread overview]
Message-ID: <88042B50-9057-4589-ADF0-E37A2096BD54@holtmann.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0802260926550.7583@apollo.tec.linutronix.de>

Hi Quel,

> Delete a possibly armed timer before kfree'ing the connection object.
>
> Solves: http://lkml.org/lkml/2008/2/15/514
>
> Reported-by:Quel Qun <kelk1@comcast.net>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> ---
> net/bluetooth/l2cap.c |    2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6/net/bluetooth/l2cap.c
> ===================================================================
> --- linux-2.6.orig/net/bluetooth/l2cap.c
> +++ linux-2.6/net/bluetooth/l2cap.c
> @@ -417,6 +417,8 @@ static void l2cap_conn_del(struct hci_co
> 		l2cap_sock_kill(sk);
> 	}
>
> +	del_timer_sync(&conn->info_timer);
> +
> 	hcon->l2cap_data = NULL;
> 	kfree(conn);
> }

can you confirm that this actually fixes the issue.

Thomas, if confirmed, this is Acked-by me.

Regards

Marcel


  reply	other threads:[~2008-02-26 19:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26  0:03 Kernel oops with bluetooth usb dongle Quel Qun
2008-02-26  3:13 ` Marcel Holtmann
2008-02-26  8:28 ` [PATCH] bluetooth: delete timer in l2cap_conn_del() Thomas Gleixner
2008-02-26 19:38   ` Marcel Holtmann [this message]
2008-02-27  1:43   ` David Miller
2008-02-27  9:55     ` Marcel Holtmann
2008-02-27 12:20       ` Thomas Gleixner
2008-02-27 19:07       ` David Miller
2008-02-27 22:08         ` David Miller
2008-02-28  1:03 ` Kernel oops with bluetooth usb dongle Dave Young
2008-02-28  1:37   ` Dave Young
2008-02-27 20:21 [PATCH] bluetooth: delete timer in l2cap_conn_del() Quel Qun
2008-02-27 20:31 ` Thomas Gleixner
2008-02-28  1:17 Quel Qun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88042B50-9057-4589-ADF0-E37A2096BD54@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=dwmw2@infradead.org \
    --cc=hidave.darkstar@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=kelk1@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).