LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Michal Suchanek <msuchanek@suse.de> To: linuxppc-dev@lists.ozlabs.org Cc: "Kate Stewart" <kstewart@linuxfoundation.org>, "Madhavan Srinivasan" <maddy@linux.vnet.ibm.com>, "Paul Mackerras" <paulus@samba.org>, "Michael Neuling" <mikey@neuling.org>, "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>, "Mahesh Salgaonkar" <mahesh@linux.vnet.ibm.com>, "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>, "Daniel Axtens" <dja@axtens.net>, "Nicholas Piggin" <npiggin@gmail.com>, "Al Viro" <viro@zeniv.linux.org.uk>, "David Gibson" <david@gibson.dropbear.id.au>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, "Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, "Masami Hiramatsu" <mhiramat@kernel.org>, "Andrew Donnellan" <andrew.donnellan@au1.ibm.com>, "Philippe Ombredanne" <pombredanne@nexb.com>, "Joe Perches" <joe@perches.com>, "Oliver O'Halloran" <oohall@gmail.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Tobin C. Harding" <me@tobin.cc>, "Michal Suchanek" <msuchanek@suse.de> Subject: [PATCH RFC rebase 4/9] powerpc/64s: Use barrier_nospec in RFI_FLUSH_SLOT Date: Thu, 15 Mar 2018 20:15:53 +0100 [thread overview] Message-ID: <89e52fff32b76d01d5c0c961f6558dade0676f7a.1521141122.git.msuchanek@suse.de> (raw) In-Reply-To: <cover.1521141122.git.msuchanek@suse.de> In-Reply-To: <cover.1521141122.git.msuchanek@suse.de> The RFI flush support patches the speculation barrier into RFI_FLUSH_SLOT as part of the RFI flush. Use separate barrier_nospec instead. Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- arch/powerpc/include/asm/exception-64s.h | 2 +- arch/powerpc/lib/feature-fixups.c | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/include/asm/exception-64s.h b/arch/powerpc/include/asm/exception-64s.h index 471b2274fbeb..bb5a3052b29b 100644 --- a/arch/powerpc/include/asm/exception-64s.h +++ b/arch/powerpc/include/asm/exception-64s.h @@ -81,9 +81,9 @@ * L1-D cache when returning to userspace or a guest. */ #define RFI_FLUSH_SLOT \ + barrier_nospec_asm; \ RFI_FLUSH_FIXUP_SECTION; \ nop; \ - nop; \ nop #define RFI_TO_KERNEL \ diff --git a/arch/powerpc/lib/feature-fixups.c b/arch/powerpc/lib/feature-fixups.c index 35f80ab7cbd8..4cc2f0c5c863 100644 --- a/arch/powerpc/lib/feature-fixups.c +++ b/arch/powerpc/lib/feature-fixups.c @@ -119,7 +119,7 @@ void do_feature_fixups(unsigned long value, void *fixup_start, void *fixup_end) #ifdef CONFIG_PPC_BOOK3S_64 void do_rfi_flush_fixups(enum l1d_flush_type types) { - unsigned int instrs[3], *dest; + unsigned int instrs[2], *dest; long *start, *end; int i; @@ -128,15 +128,13 @@ void do_rfi_flush_fixups(enum l1d_flush_type types) instrs[0] = 0x60000000; /* nop */ instrs[1] = 0x60000000; /* nop */ - instrs[2] = 0x60000000; /* nop */ if (types & L1D_FLUSH_FALLBACK) - /* b .+16 to fallback flush */ - instrs[0] = 0x48000010; + /* b .+12 to fallback flush */ + instrs[0] = 0x4800000c; i = 0; if (types & L1D_FLUSH_ORI) { - instrs[i++] = 0x63ff0000; /* ori 31,31,0 speculation barrier */ instrs[i++] = 0x63de0000; /* ori 30,30,0 L1d flush*/ } @@ -150,7 +148,6 @@ void do_rfi_flush_fixups(enum l1d_flush_type types) patch_instruction(dest, instrs[0]); patch_instruction(dest + 1, instrs[1]); - patch_instruction(dest + 2, instrs[2]); } printk(KERN_DEBUG "rfi-flush: patched %d locations (%s flush)\n", i, -- 2.13.6
next prev parent reply other threads:[~2018-03-15 19:15 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-13 18:32 [PATCH RFC 0/8] powerpc barrier_nospec Michal Suchanek 2018-03-13 18:32 ` [PATCH RFC 1/8] powerpc: Add barrier_nospec Michal Suchanek 2018-03-13 20:01 ` Peter Zijlstra 2018-03-15 19:15 ` [PATCH RFC rebase 0/9] powerpc barrier_nospec Michal Suchanek 2018-03-15 19:15 ` [PATCH RFC rebase 1/9] powerpc: Add barrier_nospec Michal Suchanek 2018-03-15 19:15 ` [PATCH RFC rebase 2/9] powerpc: Use barrier_nospec in copy_from_user Michal Suchanek 2018-03-15 21:37 ` Linus Torvalds 2018-03-16 13:22 ` Michael Ellerman 2018-03-15 19:15 ` [PATCH RFC rebase 3/9] powerpc/64: Use barrier_nospec in syscall entry Michal Suchanek 2018-03-16 5:18 ` Nicholas Piggin 2018-03-16 9:15 ` Michal Suchánek 2018-03-16 10:46 ` Nicholas Piggin 2018-03-16 13:28 ` Michael Ellerman 2018-03-16 17:08 ` Linus Torvalds 2018-03-15 19:15 ` Michal Suchanek [this message] 2018-03-15 19:15 ` [PATCH RFC rebase 5/9] powerpc/64s: Add support for ori barrier_nospec patching Michal Suchanek 2018-03-15 19:15 ` [PATCH RFC rebase 6/9] powerpc/64: Patch barrier_nospec in modules Michal Suchanek 2018-03-15 19:15 ` [PATCH RFC rebase 7/9] powerpc/64: barrier_nospec: Add debugfs trigger Michal Suchanek 2018-03-15 19:15 ` [PATCH RFC rebase 8/9] powerpc/64s: barrier_nospec: Add hcall triggerr Michal Suchanek 2018-03-15 19:15 ` [PATCH RFC rebase 9/9] powerpc/64: barrier_nospec: Add commandline trigger Michal Suchanek 2018-03-23 15:59 ` Diana Madalina Craciun 2018-03-16 8:08 ` [PATCH RFC rebase 0/9] powerpc barrier_nospec Greg Kroah-Hartman 2018-03-16 9:31 ` Michal Suchánek 2018-03-13 18:33 ` [PATCH RFC 2/8] powerpc: Use barrier_nospec in copy_from_user Michal Suchanek 2018-03-13 18:33 ` [PATCH RFC 3/8] powerpc/64: Use barrier_nospec in syscall entry Michal Suchanek 2018-03-13 18:33 ` [PATCH RFC 4/8] powerpc/64s: Add support for ori barrier_nospec Michal Suchanek 2018-03-13 18:33 ` [PATCH RFC 5/8] powerpc/64: Patch barrier_nospec in modules Michal Suchanek 2018-03-13 18:33 ` [PATCH RFC 6/8] powerpc/64: barrier_nospec: Add debugfs trigger Michal Suchanek 2018-03-13 18:33 ` [PATCH RFC 7/8] powerpc/64s: barrier_nospec: Add hcall triggerr Michal Suchanek 2018-03-13 18:33 ` [PATCH RFC 8/8] powerpc/64: barrier_nospec: Add commandline trigger Michal Suchanek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=89e52fff32b76d01d5c0c961f6558dade0676f7a.1521141122.git.msuchanek@suse.de \ --to=msuchanek@suse.de \ --cc=akpm@linux-foundation.org \ --cc=andrew.donnellan@au1.ibm.com \ --cc=bryantly@linux.vnet.ibm.com \ --cc=clg@kaod.org \ --cc=david@gibson.dropbear.id.au \ --cc=dja@axtens.net \ --cc=gregkh@linuxfoundation.org \ --cc=joe@perches.com \ --cc=kstewart@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=maddy@linux.vnet.ibm.com \ --cc=mahesh@linux.vnet.ibm.com \ --cc=me@tobin.cc \ --cc=mhiramat@kernel.org \ --cc=mikey@neuling.org \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=npiggin@gmail.com \ --cc=oohall@gmail.com \ --cc=paulus@samba.org \ --cc=pombredanne@nexb.com \ --cc=sergey.senozhatsky@gmail.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).