LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Timothy Shimmin <tes@sgi.com>
To: xfs-masters@oss.sgi.com, David Chinner <dgc@sgi.com>, bunk@stusta.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [xfs-masters] [2.6 patch] make xfs_buftarg_list static again
Date: Tue, 20 Feb 2007 12:08:20 +1100	[thread overview]
Message-ID: <8A32D9770F6D2A7EAB6016A0@timothy-shimmins-power-mac-g5.local> (raw)
In-Reply-To: <20070220000747.GC13958@stusta.de>

Hi Adrian,

--On 20 February 2007 1:07:47 AM +0100 Adrian Bunk <bunk@stusta.de> wrote:

> xfs_buftarg_list became global for no good reason.
>

That's true. I'll make the change for git if Dave has no objections.

It happened because in the SGI tree we want it global for use in kdb by xfsidbg.o,
and that used to happen in the CONFIG_XFS_DEBUG case where STATIC would define
to nothing - looks like it is global always in our tree now since Dave's patch.
i.e. it was actually becoming global previously via STATIC on CONFIG_XFS_DEBUG
but one wouldn't have noticed that :) AFAICT.
Hmmm, I'll talk to Dave about this.

--Tim

> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
> --- linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c.old	2007-02-18 22:55:40.000000000 +0100
> +++ linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c	2007-02-18 22:56:08.000000000 +0100
> @@ -1424,7 +1424,7 @@
>  /*
>   *	buftarg list for delwrite queue processing
>   */
> -LIST_HEAD(xfs_buftarg_list);
> +static LIST_HEAD(xfs_buftarg_list);
>  static DEFINE_SPINLOCK(xfs_buftarg_lock);
>
>  STATIC void
>
>





      parent reply	other threads:[~2007-02-20  1:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20  0:07 Adrian Bunk
2007-02-20  0:41 ` David Chinner
2007-02-20  1:08 ` Timothy Shimmin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8A32D9770F6D2A7EAB6016A0@timothy-shimmins-power-mac-g5.local \
    --to=tes@sgi.com \
    --cc=bunk@stusta.de \
    --cc=dgc@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs-masters@oss.sgi.com \
    --subject='Re: [xfs-masters] [2.6 patch] make xfs_buftarg_list static again' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).