LKML Archive on
help / color / mirror / Atom feed
From: Lee Duncan <>
	Jianchao Wang <>,,,,
Subject: Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled
Date: Thu, 15 Mar 2018 04:37:24 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

I reviewed this several days before but mistakenly replied only to the open-iscsi list. 

Signed-off-by: Lee Duncan <>

Lee-Man Duncan
Sent from my iPhone, dude

> On Mar 14, 2018, at 10:11 PM, Martin K. Petersen <> wrote:
>> iscsi tcp will first send out data, then calculate and send data
>> digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will
>> be written in spite of the on going writeback. Consequently, wrong
>> digest will be got and sent to target.
>> To fix this, set BDI_CAP_STABLE_WRITES when data digest is enabled
>> in iscsi_tcp .slave_configure callback.
> Lee, Chris: Please review!
> -- 
> Martin K. Petersen    Oracle Linux Engineering
> -- 
> You received this message because you are subscribed to a topic in the Google Groups "open-iscsi" group.
> To unsubscribe from this topic, visit
> To unsubscribe from this group and all its topics, send an email to
> To post to this group, send email to
> Visit this group at
> For more options, visit

  reply	other threads:[~2018-03-15 10:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 12:29 [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled Jianchao Wang
2018-03-14  7:00 `
2018-03-15  4:11 ` Martin K. Petersen
2018-03-15 10:37   ` Lee Duncan [this message]
2018-03-15 18:05 ` Chris Leech
2018-03-20  3:26 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).