LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hareesh Gundu <hareeshg@codeaurora.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	jcrouse@codeaurora.org, Mel Gorman <mgorman@suse.de>,
	efault@gmx.de, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/plist.c: Export plist_*() APIs
Date: Wed, 30 May 2018 17:55:05 +0530	[thread overview]
Message-ID: <8a59865a-1143-3ba1-8be7-cf590d422c36@codeaurora.org> (raw)
In-Reply-To: <20171206155917.se5mmw2gf5qz4otf@hirez.programming.kicks-ass.net>



On 12/6/2017 9:29 PM, Peter Zijlstra wrote:
> On Wed, Dec 06, 2017 at 08:59:27PM +0530, Hareesh Gundu wrote:
>> On 12/5/2017 8:11 PM, Peter Zijlstra wrote:
>>> On Tue, Dec 05, 2017 at 08:05:43PM +0530, Hareesh Gundu wrote:
>>>> Allow plist_add(), plist_del() and plist_requeue() APIs to
>>>> be referenced by kernel modules by adding the EXPORT_SYMBOL().
>> This change is not for in-tree kernel module. It's for modules built outside
>> of kernel tree modules.
>>
>> Is it really required to show out tree kernel modules ?
> Typically we don't add EXPORTs for functions not used in in-tree
> modules.
We changed our design and planned to have our module in-tree kernel 
instead of out tree kernel module.
Below is the reference for in-tree kernel module proposal for 
"drviers/gpu/msm" which is referring to plist_* symbols.

https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/gpu/msm/adreno_dispatch.c?h=msm-4.9#n533

Could you please revisit the patch and approve for upstream.

  reply	other threads:[~2018-05-30 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 14:35 Hareesh Gundu
2017-12-05 14:41 ` Peter Zijlstra
2017-12-06 15:29   ` Hareesh Gundu
2017-12-06 15:59     ` Peter Zijlstra
2018-05-30 12:25       ` Hareesh Gundu [this message]
2018-05-30 14:12         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a59865a-1143-3ba1-8be7-cf590d422c36@codeaurora.org \
    --to=hareeshg@codeaurora.org \
    --cc=efault@gmx.de \
    --cc=jcrouse@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] lib/plist.c: Export plist_*() APIs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).