LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, ebiggers@kernel.org, pvanleeuwen@rambus.com,
	zohar@linux.ibm.com, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, gilad@benyossef.com
Subject: Re: [PATCH] crypto: sm3 - export crypto_sm3_final function
Date: Sun, 23 Feb 2020 12:21:25 +0800	[thread overview]
Message-ID: <8acc79e8-8b3d-856d-06d2-5322c9a66be9@linux.alibaba.com> (raw)
In-Reply-To: <20200222011926.GA18695@gondor.apana.org.au>



On 2020/2/22 9:19, Herbert Xu wrote:
> On Sun, Feb 16, 2020 at 05:02:33PM +0800, Tianjia Zhang wrote:
>> Both crypto_sm3_update and crypto_sm3_finup have been
>> exported, exporting crypto_sm3_final, to avoid having to
>> use crypto_sm3_finup(desc, NULL, 0, dgst) to calculate
>> the hash in some cases.
>>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>> ---
>>   crypto/sm3_generic.c | 7 ++++---
>>   include/crypto/sm3.h | 2 ++
>>   2 files changed, 6 insertions(+), 3 deletions(-)
> 
> Please add this into the series that actually uses the function.
> It makes no sense on its own.
> 
> Thanks,
> 

The actual use of this function is in sm2 and OSCCA certificates. This 
set of patches has been submitted to the community. Please review them.

      reply	other threads:[~2020-02-23  4:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-16  9:02 Tianjia Zhang
2020-02-22  1:19 ` Herbert Xu
2020-02-23  4:21   ` Tianjia Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8acc79e8-8b3d-856d-06d2-5322c9a66be9@linux.alibaba.com \
    --to=tianjia.zhang@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=gilad@benyossef.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pvanleeuwen@rambus.com \
    --cc=zohar@linux.ibm.com \
    --subject='Re: [PATCH] crypto: sm3 - export crypto_sm3_final function' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).