LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Adrian McMenamin" <lkmladrian@gmail.com>
To: "Paul Mundt" <lethal@linux-sh.org>,
	"Adrian McMenamin" <adrian@newgolddream.dyndns.info>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Jens Axboe" <jens.axboe@oracle.com>,
	linux-sh <linux-sh@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast
Date: Tue, 15 Jan 2008 20:41:39 +0000	[thread overview]
Message-ID: <8b67d60801151241p31ade7ald4421dc0f34d5212@mail.gmail.com> (raw)
In-Reply-To: <20080115002958.GA27597@linux-sh.org>

On 15/01/2008, Paul Mundt <lethal@linux-sh.org> wrote:
> On Mon, Jan 14, 2008 at 11:17:15PM +0000, Adrian McMenamin wrote:

>
> > +static bool gdrom_data_request(void)
> > +{
> > +     return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8;
> > +}
> > +
> Andrew first pointed this out, and this is still broken.
>

Eh, no, he didn't. What is wrong with it?

He compalined about excessively long busy waiting and then not
checking if the busy wait failed. Both those have been fixed.

  reply	other threads:[~2008-01-15 20:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 23:25 Adrian McMenamin
2008-01-11 21:56 ` Adrian McMenamin
2008-01-12 11:57   ` Jens Axboe
2008-01-12 13:36   ` Andrew Morton
2008-01-12 14:14     ` Adrian McMenamin
2008-01-12 19:15       ` Andrew Morton
2008-01-13 18:24         ` Adrian McMenamin
2008-01-14 23:00     ` Adrian McMenamin
2008-01-14 23:17       ` Adrian McMenamin
2008-01-15  0:29         ` Paul Mundt
2008-01-15 20:41           ` Adrian McMenamin [this message]
2008-01-16  1:57             ` Paul Mundt
2008-01-16 23:57         ` Adrian McMenamin
2008-01-17  1:27           ` Paul Mundt
2008-01-17 22:30             ` Adrian McMenamin
2008-01-18  0:56               ` Paul Mundt
2008-01-28  5:33                 ` Andrew Morton
2008-01-28  5:53                   ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b67d60801151241p31ade7ald4421dc0f34d5212@mail.gmail.com \
    --to=lkmladrian@gmail.com \
    --cc=adrian@newgolddream.dyndns.info \
    --cc=akpm@linux-foundation.org \
    --cc=jens.axboe@oracle.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --subject='Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).