LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Will Newton" <will.newton@gmail.com>
Cc: "Bryan Wu" <bryan.wu@analog.com>,
	dwmw2@infradead.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Mike Frysinger" <michael.frysinger@analog.com>
Subject: Re: [PATCH 1/1] [MTD/MAPS] Blackfin BF5xx Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank
Date: Wed, 30 Jan 2008 09:14:30 -0500	[thread overview]
Message-ID: <8bd0f97a0801300614g3f7bce03p668fca354d49761@mail.gmail.com> (raw)
In-Reply-To: <87a5b0800801300401o1b0b631dt55cefaeb31b2da22@mail.gmail.com>

On Jan 30, 2008 7:01 AM, Will Newton <will.newton@gmail.com> wrote:
> On Jan 30, 2008 10:02 AM, Bryan Wu <bryan.wu@analog.com> wrote:
>
> switch_to_flash is calling SSYNC():
>
> > +static void switch_to_flash(struct flash_save *save)
> > +{
> > +       local_irq_save(save->flags);
> > +
> > +       gpio_set_value(enet_flash_pin, 0);
> > +       SSYNC();
> > +
> > +       save->ambctl0 = bfin_read_EBIU_AMBCTL0();
> > +       save->ambctl1 = bfin_read_EBIU_AMBCTL1();
> > +       bfin_write_EBIU_AMBCTL0(BFIN_FLASH_AMBCTL0VAL);
> > +       bfin_write_EBIU_AMBCTL1(BFIN_FLASH_AMBCTL1VAL);
> > +       SSYNC();
> > +}
> > +
> > +static void switch_back(struct flash_save *save)
> > +{
> > +       bfin_write_EBIU_AMBCTL0(save->ambctl0);
> > +       bfin_write_EBIU_AMBCTL1(save->ambctl1);
> > +       SSYNC();
> > +
> > +       gpio_set_value(enet_flash_pin, 1);
> > +
> > +       local_irq_restore(save->flags);
> > +}
> > +
> > +static map_word bf5xx_read(struct map_info *map, unsigned long ofs)
> > +{
> > +       int nValue = 0x0;
> > +       map_word test;
> > +       struct flash_save save;
> > +
> > +       switch_to_flash(&save);
> > +       SSYNC();
>
> Is it necessary to SSYNC() here as well?
>
> > +       nValue = readw(map->virt + ofs);
> > +       SSYNC();
> > +       switch_back(&save);
> > +
> > +       test.x[0] = (u16)nValue;
> > +       return test;
> > +}
> > +
> > +static void bf5xx_copy_from(struct map_info *map, void *to, unsigned long from, ssize_t len)
> > +{
> > +       unsigned long i;
> > +       map_word test;
> > +
> > +       if ((unsigned long)to & 0x1) {
> > +               for (i = 0; i < len / 2 * 2; i += 2) {
> > +                       test = bf5xx_read(map, from + i);
> > +                       put_unaligned(test.x[0], (__le16 *)(to + i));
> > +               }
> > +       } else {
> > +               for (i = 0; i < len / 2 * 2; i += 2) {
> > +                       test = bf5xx_read(map, from + i);
> > +                       *((u16*)(to + i)) = test.x[0];
> > +               }
> > +       }
> > +
> > +       if (len & 0x1) {
> > +               test = bf5xx_read(map, from + i);
> > +               *((u8*)(to + i)) = (u8)test.x[0];
> > +       }
> > +}
> > +
> > +static void bf5xx_write(struct map_info *map, map_word d1, unsigned long ofs)
> > +{
> > +       u16 d;
> > +       struct flash_save save;
> > +
> > +       d = (u16)d1.x[0];
> > +
> > +       switch_to_flash(&save);
> > +
> > +       SSYNC();
>
> Also here?
>
> > +       writew(d, map->virt + ofs);
> > +       SSYNC();
> > +
> > +       switch_back(&save);
> > +}

thanks ... it should be fixed now
http://blackfin.uclinux.org/gf/project/linux-kernel/scmsvn/?action=browse&path=/&view=rev&root=linux-kernel&revision=4173
-mike

      reply	other threads:[~2008-01-30 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 10:02 Bryan Wu
2008-01-30 12:01 ` Will Newton
2008-01-30 14:14   ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0801300614g3f7bce03p668fca354d49761@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=bryan.wu@analog.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael.frysinger@analog.com \
    --cc=will.newton@gmail.com \
    --subject='Re: [PATCH 1/1] [MTD/MAPS] Blackfin BF5xx Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).