LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: schwidefsky@de.ibm.com, "Bryan Wu" <Bryan.Wu@analog.com>
Cc: "Adrian Bunk" <bunk@kernel.org>,
	gerg@uclinux.org, linux-kernel@vger.kernel.org,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: m68knommu compile error
Date: Sat, 9 Feb 2008 12:59:50 -0500	[thread overview]
Message-ID: <8bd0f97a0802090959g367ef6a4h304b01e6f930781f@mail.gmail.com> (raw)
In-Reply-To: <1202554715.8936.18.camel@localhost>

On Feb 9, 2008 5:58 AM, Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> On Sat, 2008-02-09 at 11:21 +0100, Martin Schwidefsky wrote:
> > On Sat, 2008-02-09 at 00:25 +0200, Adrian Bunk wrote:
> > > Commit 2f569afd9ced9ebec9a6eb3dbf6f83429be0a7b4 breaks m68knommu:
> >
> > Does the patch below fixes the problem? I tried to cross compile for
> > m68knommu but it seems like you need a special m68k compiler to get it
> > compile all the way through. With the patch it did fail with a different
> > error, so I assume it is fixed. The problem is that the pgtable_t is
> > simply missing for m68knommu, I must have overlooked a reject for one of
> > the constant regenerations of the patch to keep up with upstream. Sorry
> > about that.
>
> This is a problem for all nommu architectures. The patch fixed all four
> of them.
>
> ---
> [PATCH] Add pgtable_t to nommu architectures.
>
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> The pte_fn_t in include/linux/mm.h make it necessary for all
> architecture to define a pgtable_t type, even those that do
> not have an mmu.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> ---
>
>  include/asm-blackfin/page.h  |    1 +
>  include/asm-h8300/page.h     |    1 +
>  include/asm-m68knommu/page.h |    1 +
>  include/asm-v850/page.h      |    1 +
>  4 files changed, 4 insertions(+)
>
> diff -urpN linux-2.6/include/asm-blackfin/page.h linux-2.6-patched/include/asm-blackfin/page.h
> --- linux-2.6/include/asm-blackfin/page.h       2008-02-09 11:46:28.000000000 +0100
> +++ linux-2.6-patched/include/asm-blackfin/page.h       2008-02-09 11:46:36.000000000 +0100
> @@ -39,6 +39,7 @@ typedef struct {
>  typedef struct {
>         unsigned long pgprot;
>  } pgprot_t;
> +typedef struct page *pgtable_t;
>
>  #define pte_val(x)     ((x).pte)
>  #define pmd_val(x)     ((&x)->pmd[0])

thanks, this fixed building Blackfin for me.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
-mike

  reply	other threads:[~2008-02-09 17:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 22:25 Adrian Bunk
2008-02-09 10:21 ` Martin Schwidefsky
2008-02-09 10:53   ` Adrian Bunk
2008-02-09 10:58   ` Martin Schwidefsky
2008-02-09 17:59     ` Mike Frysinger [this message]
2008-02-11  5:22     ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0802090959g367ef6a4h304b01e6f930781f@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=Bryan.Wu@analog.com \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --subject='Re: m68knommu compile error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).