Re: m68knommu compile error

["Mike Frysinger" <vapier.adi@gmail.com>]

On Feb 9, 2008 5:58 AM, Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> On Sat, 2008-02-09 at 11:21 +0100, Martin Schwidefsky wrote:
> > On Sat, 2008-02-09 at 00:25 +0200, Adrian Bunk wrote:
> > > Commit 2f569afd9ced9ebec9a6eb3dbf6f83429be0a7b4 breaks m68knommu:
> >
> > Does the patch below fixes the problem? I tried to cross compile for
> > m68knommu but it seems like you need a special m68k compiler to get it
> > compile all the way through. With the patch it did fail with a different
> > error, so I assume it is fixed. The problem is that the pgtable_t is
> > simply missing for m68knommu, I must have overlooked a reject for one of
> > the constant regenerations of the patch to keep up with upstream. Sorry
> > about that.
>
> This is a problem for all nommu architectures. The patch fixed all four
> of them.
>
> ---
> [PATCH] Add pgtable_t to nommu architectures.
>
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> The pte_fn_t in include/linux/mm.h make it necessary for all
> architecture to define a pgtable_t type, even those that do
> not have an mmu.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> ---
>
>  include/asm-blackfin/page.h  |    1 +
>  include/asm-h8300/page.h     |    1 +
>  include/asm-m68knommu/page.h |    1 +
>  include/asm-v850/page.h      |    1 +
>  4 files changed, 4 insertions(+)
>
> diff -urpN linux-2.6/include/asm-blackfin/page.h linux-2.6-patched/include/asm-blackfin/page.h
> --- linux-2.6/include/asm-blackfin/page.h       2008-02-09 11:46:28.000000000 +0100
> +++ linux-2.6-patched/include/asm-blackfin/page.h       2008-02-09 11:46:36.000000000 +0100
> @@ -39,6 +39,7 @@ typedef struct {
>  typedef struct {
>         unsigned long pgprot;
>  } pgprot_t;
> +typedef struct page *pgtable_t;
>
>  #define pte_val(x)     ((x).pte)
>  #define pmd_val(x)     ((&x)->pmd[0])

thanks, this fixed building Blackfin for me.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
-mike