LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: schwidefsky@de.ibm.com
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: CONFIG_HIGHPTE vs. sub-page page tables.
Date: Sun, 10 Feb 2008 04:25:13 -0500	[thread overview]
Message-ID: <8bd0f97a0802100125va445d5ci81122da279b80d5f@mail.gmail.com> (raw)
In-Reply-To: <1202635061.21652.8.camel@localhost>

On Feb 10, 2008 4:17 AM, Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> On Sat, 2008-02-09 at 12:56 -0500, Mike Frysinger wrote:
> > On Feb 9, 2008 5:56 AM, Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> > > On Sat, 2008-02-09 at 11:37 +0100, Ingo Molnar wrote:
> > > > i think the worst is over already and i'm reasonably sure that there are
> > > > no more bugs in it - this _is_ a 1:1 patch after all, so in theory the
> > > > worst side-effect should be build breakages due to include file
> > > > spaghetti. The window for this particular breakage was just 256 commits,
> > > > that's OK i think.
> > >
> > > Except for the breakage of all nommu architectures .. they need the
> > > pgtable_t as well due to the pte_fn_t type.
> >
> > so why wasnt this in the original patch ?  why do no-mmu arches have
> > to add the pgtable_t typedefs themselves ?
>
> I do cross-compiles for some architectures but not all. None of the
> nommu architectures are covered (I should change that). I actually did
> cross compile m68knommu for the first versions of the patch, that didn't
> went to well because of the standard m68k compiler. The pte_fn_t change
> has been added after the test compile for m68knommu. This is how is
> slipped through my fingers. The problem wasn't noticed either while the
> patch has been aging in Andrews -mm tree.

i guess my point was more: the pgtable_t typdef is new therefore it
must be defined for every architecture.  your ability to directly
cross-compile and/or test a subset is great, but posting a change that
is know for a fact to break arches you didnt update seems like a bad
idea.  even if you just included the obvious-but-not-compile-tested
changes and included the linux-arch@vger alias instead would have been
better than nothing
-mike

  reply	other threads:[~2008-02-10  9:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200802081902.m18J2nOm005840@hera.kernel.org>
2008-02-08 23:04 ` Ingo Molnar
2008-02-08 23:15   ` Ingo Molnar
2008-02-09 10:06     ` Martin Schwidefsky
2008-02-09 10:37       ` Ingo Molnar
2008-02-09 10:56         ` Martin Schwidefsky
2008-02-09 17:56           ` Mike Frysinger
2008-02-10  9:17             ` Martin Schwidefsky
2008-02-10  9:25               ` Mike Frysinger [this message]
2008-02-10  9:41                 ` Martin Schwidefsky
2008-02-10 10:06                   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0802100125va445d5ci81122da279b80d5f@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: CONFIG_HIGHPTE vs. sub-page page tables.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).