LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: schwidefsky@de.ibm.com
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: CONFIG_HIGHPTE vs. sub-page page tables.
Date: Sun, 10 Feb 2008 05:06:00 -0500	[thread overview]
Message-ID: <8bd0f97a0802100206n7b79cd0es4d79409678880a34@mail.gmail.com> (raw)
In-Reply-To: <1202636468.21652.26.camel@localhost>

On Feb 10, 2008 4:41 AM, Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> On Sun, 2008-02-10 at 04:25 -0500, Mike Frysinger wrote:
> > i guess my point was more: the pgtable_t typdef is new therefore it
> > must be defined for every architecture.  your ability to directly
> > cross-compile and/or test a subset is great, but posting a change that
> > is know for a fact to break arches you didnt update seems like a bad
> > idea.  even if you just included the obvious-but-not-compile-tested
> > changes and included the linux-arch@vger alias instead would have been
> > better than nothing
>
> The patch was posted multiple times on linux-arch and it has been part
> of -mm for 3 months. Plenty of time for the arch maintainers to notice.
> And without the pte_pfn_t change it would compile on a nommu
> architecture even without the typedef. That is why I didn't add the new
> typedef to the nommu archs.

generally things are posted to linux-arch for the arch maintainers to
review.  the person posting the changes does all the footwork to make
sure no one is left behind since they're the ones proposing the
change.  it isnt "hey, unless you do something, your arch is going to
be broken, sorry".

> Which turned out to be a mistake after the
> pte_pfn_t change has been added but the problem is fixed with the patch
> sent yesterday, isn't?

yes, the patch you posted for the remaining arches should fix the
arches left broken.
-mike

      reply	other threads:[~2008-02-10 10:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200802081902.m18J2nOm005840@hera.kernel.org>
2008-02-08 23:04 ` Ingo Molnar
2008-02-08 23:15   ` Ingo Molnar
2008-02-09 10:06     ` Martin Schwidefsky
2008-02-09 10:37       ` Ingo Molnar
2008-02-09 10:56         ` Martin Schwidefsky
2008-02-09 17:56           ` Mike Frysinger
2008-02-10  9:17             ` Martin Schwidefsky
2008-02-10  9:25               ` Mike Frysinger
2008-02-10  9:41                 ` Martin Schwidefsky
2008-02-10 10:06                   ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0802100206n7b79cd0es4d79409678880a34@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: CONFIG_HIGHPTE vs. sub-page page tables.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).