LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Takashi Iwai" <tiwai@suse.de>
Cc: "Mike Frysinger" <vapier@gentoo.org>,
	alsa-devel@alsa-project.org, "Jaroslav Kysela" <perex@perex.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments
Date: Fri, 7 Nov 2008 02:09:04 -0500	[thread overview]
Message-ID: <8bd0f97a0811062309m4029f612k4d3fe380e6d124df@mail.gmail.com> (raw)
In-Reply-To: <s5hod0sqcmt.wl%tiwai@suse.de>

On Fri, Nov 7, 2008 at 01:22, Takashi Iwai wrote:
> At Thu,  6 Nov 2008 21:05:21 -0500,
> Mike Frysinger wrote:
>> The snd_BUG_ON() macro should always expand its argument even if we're
>> forcing it to false.  This kills off unused warnings that did not exist
>> before the snd_assert() -> snd_BUG_ON() conversion.
>
> Andrew already change this differently.  Check with the latest version.

what are you defining as "latest version" ?  i'm looking in torvalds
linux-2.6.git.

> And which warning did you get actually?

a few codecs define local vars which only get used in snd_BUG_ON() ...
so if snd_BUG_ON() doesnt utilize cond, gcc whines that the var is
unused.
-mike

  reply	other threads:[~2008-11-07  7:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07  2:05 Mike Frysinger
2008-11-07  6:22 ` Takashi Iwai
2008-11-07  7:09   ` Mike Frysinger [this message]
2008-11-07  7:15     ` [alsa-devel] " Takashi Iwai
2008-11-07  7:29       ` Mike Frysinger
2008-11-07  7:36         ` Takashi Iwai
2008-11-07  7:56           ` Mike Frysinger
2008-11-07  7:38         ` Takashi Iwai
2008-11-07  7:57           ` Mike Frysinger
2008-11-07  8:03             ` Takashi Iwai
2008-11-07  8:05               ` Mike Frysinger
2008-11-07  8:22                 ` Takashi Iwai
2008-11-07  9:30                   ` Mike Frysinger
2008-11-07  9:56                     ` Takashi Iwai
2008-11-07 10:03                       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0811062309m4029f612k4d3fe380e6d124df@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --cc=vapier@gentoo.org \
    --subject='Re: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).