LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
	Paul Menzel <pmenzel@molgen.mpg.de>,
	Realtek linux nic maintainers <nic_swsd@realtek.com>
Cc: netdev@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: r8169: Link only up after 16 s (A link change request failed with some changes committed already. Interface enp3s0 may have been left with an inconsistent configuration, please check.)
Date: Fri, 24 May 2019 11:04:43 -0700	[thread overview]
Message-ID: <8c138b300290efbff43631f2c527a37390c504d8.camel@perches.com> (raw)
In-Reply-To: <5d25b4f3-20d3-6c93-2c0a-b95fde9e4c40@gmail.com>

On Fri, 2019-05-24 at 19:55 +0200, Heiner Kallweit wrote:
> On 24.05.2019 17:14, Paul Menzel wrote:
> > I applied the simple change below to `net/core/rtnetlink.c`.
> > 
> >                 if (err < 0)
> > -                       net_warn_ratelimited("A link change request failed with some changes committed already. Interface %s may have been left with an inconsistent configuration, please check.\n",
> > -                                            dev->name);
> > +                       net_warn_ratelimited("A link change request failed with some changes committed already (err = %i). Interface %s may have been left with an inconsistent configuration, please check.\n",
> > +                                            dev->name, err);
> > 
> > I get different results each time.
> > 
> > -304123904
> > -332128256
> > 
> > Any idea, how that can happen?
> > 
> Instead of %i you should use %d, and the order of arguments needs to be reversed.

Doesn't the patch generate a compilation warning?



      reply	other threads:[~2019-05-24 18:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 11:00 Paul Menzel
2019-05-23 17:44 ` Heiner Kallweit
2019-05-24 15:14   ` Paul Menzel
2019-05-24 17:55     ` Heiner Kallweit
2019-05-24 18:04       ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c138b300290efbff43631f2c527a37390c504d8.camel@perches.com \
    --to=joe@perches.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pmenzel@molgen.mpg.de \
    --subject='Re: r8169: Link only up after 16 s (A link change request failed with some changes committed already. Interface enp3s0 may have been left with an inconsistent configuration, please check.)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).